From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 477CAC43331 for ; Thu, 26 Mar 2020 04:37:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D7B9E20719 for ; Thu, 26 Mar 2020 04:37:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="NnPN28SR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7B9E20719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5C7516B000D; Thu, 26 Mar 2020 00:37:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 550646B000E; Thu, 26 Mar 2020 00:37:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 417A36B0010; Thu, 26 Mar 2020 00:37:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 259446B000D for ; Thu, 26 Mar 2020 00:37:01 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 02428180AD817 for ; Thu, 26 Mar 2020 04:37:01 +0000 (UTC) X-FDA: 76636253400.14.toes58_3d390dc50f228 X-HE-Tag: toes58_3d390dc50f228 X-Filterd-Recvd-Size: 4856 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Thu, 26 Mar 2020 04:37:00 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id i24so5424961eds.1 for ; Wed, 25 Mar 2020 21:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=y20CeGQScdwXv2e5cBbGORXlmOAQqvqGM8Tbmxh+s8U=; b=NnPN28SRXi1uUhX29Dz/ecQfFMQ9NJKJyWfz57OCY+So4pdu/YOtIs8TLBwkfsbit8 L86CQNndJIPSxbZw7+4McwCfFyqnS6QAt1fSE5U6H3Nkqv2JcsH+BTOz8r1B0Uc8Po1Z FgR6DJqLubRVXNqXIs/ECINnaIo/eKg3fGwLnsgMno5LAY1Pq7LQB8Q8gF3vAkoCcfMl vnzZaNxFqEbBn7VWrLnFQoq2BGEYck/v2nPHqISNO3LxmmA59JHDiQBRYPWN1ddlZtC/ o2henSodF7cP9rrq67FXCK5UY4MkegV791GX8DXKjyZFfwDOuyMKqMfSIUGM48MvD7s8 I4OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=y20CeGQScdwXv2e5cBbGORXlmOAQqvqGM8Tbmxh+s8U=; b=oAIIFWU21QXoZyWKu5ucHWwzQgfDCSYmZUPk4DZxPPyc67ZvZ3CYWrJVKq+ViHJeCm Ck+cficcupaJZL4M7D8Gd+ETxNuN6VI//f1ccIEW1gPytZFFZjR7UzyiWkCj3EeuwaH4 AnOr/xNlV2iT0w4shFkan2rgCPGyxmiaS473OrYeYP3It+q2tfo7OmyH1aesWY5Ye0Q1 26ooMvgiKY0BvGes9YgwZNUlAqNMwjUl5PxxcLPHz6F7QwY+uE4CIhcjF1cB9SAPJjQh eOOwCyDTIRUi71xkFBunmbcGK6s3V9Wj7PsvlM7c09ZBdTNJwV4DCLRY/D3NdbXF30eC PChA== X-Gm-Message-State: ANhLgQ2GAM5vbaej74VR65YU8EUX0XKW+0psPqJRdoMlxxRK9Ficz1MH pV4guzdcn1GDEqb9G1CqcNtOnLAW56UEBdIEZn76/w== X-Google-Smtp-Source: ADFU+vuEqHrADScJDNrE5jEmfQwLB6omwEtMI9r+jBDuPZsEKbUtAYrdc7Maiu+s44RUM2179JuB/uQYQyUXcglHnqw= X-Received: by 2002:a17:906:6987:: with SMTP id i7mr6196042ejr.12.1585197418839; Wed, 25 Mar 2020 21:36:58 -0700 (PDT) MIME-Version: 1.0 References: <20200220122719.4302-1-thomas_os@shipmail.org> <20200220122719.4302-2-thomas_os@shipmail.org> In-Reply-To: <20200220122719.4302-2-thomas_os@shipmail.org> From: Dan Williams Date: Wed, 25 Mar 2020 21:36:47 -0700 Message-ID: Subject: Re: [PATCH v4 1/9] fs: Constify vma argument to vma_is_dax To: =?UTF-8?Q?Thomas_Hellstr=C3=B6m_=28VMware=29?= Cc: Linux MM , Maling list - DRI developers , Linux Kernel Mailing List , pv-drivers@vmware.com, linux-graphics-maintainer@vmware.com, Thomas Hellstrom , Andrew Morton , Michal Hocko , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Ralph Campbell , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , =?UTF-8?Q?Christian_K=C3=B6nig?= , Roland Scheidegger Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 20, 2020 at 4:27 AM Thomas Hellstr=C3=B6m (VMware) wrote: > > From: Thomas Hellstrom > > The vma argument is only dereferenced for reading. > > Cc: Andrew Morton > Cc: Michal Hocko > Cc: "Matthew Wilcox (Oracle)" > Cc: "Kirill A. Shutemov" > Cc: Ralph Campbell > Cc: "J=C3=A9r=C3=B4me Glisse" > Cc: "Christian K=C3=B6nig" > Cc: Dan Williams > Signed-off-by: Thomas Hellstrom > Reviewed-by: Roland Scheidegger > Acked-by: Christian K=C3=B6nig > --- > include/linux/fs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 98e0349adb52..4f41fdbf402f 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -3367,7 +3367,7 @@ static inline bool io_is_direct(struct file *filp) > return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host= ); > } > > -static inline bool vma_is_dax(struct vm_area_struct *vma) > +static inline bool vma_is_dax(const struct vm_area_struct *vma) > { > return vma->vm_file && IS_DAX(vma->vm_file->f_mapping->host); > } Looks good to me: Acked-by: Dan Williams