linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Qian Cai <cai@lca.pw>
Cc: Andrew Morton <akpm@linux-foundation.org>, Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH -mmotm] mm: fix SHUFFLE_PAGE_ALLOCATOR help texts
Date: Thu, 25 Apr 2019 13:36:38 -0700	[thread overview]
Message-ID: <CAPcyv4hxdyo=_9B3HtkBsCS-UdLR2CnoVqbaf8bBF6t_rRmMWA@mail.gmail.com> (raw)
In-Reply-To: <20190425201300.75650-1-cai@lca.pw>

On Thu, Apr 25, 2019 at 1:13 PM Qian Cai <cai@lca.pw> wrote:
>
> The help texts for SHUFFLE_PAGE_ALLOCATOR makes a wrong assumption that
> a page size is 4KB everywhere.
>
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
>
> Fix mm-shuffle-initial-free-memory-to-improve-memory-side-cache-utilization.patch.
>
>  init/Kconfig | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index b050890f69dc..d96a910369c7 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1764,8 +1764,9 @@ config SHUFFLE_PAGE_ALLOCATOR
>           the presence of a memory-side-cache. There are also incidental
>           security benefits as it reduces the predictability of page
>           allocations to compliment SLAB_FREELIST_RANDOM, but the
> -         default granularity of shuffling on 4MB (MAX_ORDER) pages is
> -         selected based on cache utilization benefits.
> +         default granularity of shuffling on the "MAX_ORDER - 1" i.e,
> +         10th order of pages is selected based on cache utilization
> +         benefits on x86.
>
>           While the randomization improves cache utilization it may
>           negatively impact workloads on platforms without a cache. For

Looks good,

Reviewed-by: Dan Williams <dan.j.williams@intel.com>


      reply	other threads:[~2019-04-25 20:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-25 20:13 [PATCH -mmotm] mm: fix SHUFFLE_PAGE_ALLOCATOR help texts Qian Cai
2019-04-25 20:36 ` Dan Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPcyv4hxdyo=_9B3HtkBsCS-UdLR2CnoVqbaf8bBF6t_rRmMWA@mail.gmail.com' \
    --to=dan.j.williams@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=cai@lca.pw \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).