From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EE4FC35646 for ; Fri, 21 Feb 2020 16:24:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 103F020578 for ; Fri, 21 Feb 2020 16:24:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="cBEVhpXs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 103F020578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9F4BA6B0005; Fri, 21 Feb 2020 11:24:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CBA16B0006; Fri, 21 Feb 2020 11:24:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BAF26B0007; Fri, 21 Feb 2020 11:24:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 74D0D6B0005 for ; Fri, 21 Feb 2020 11:24:31 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2E8DB824805A for ; Fri, 21 Feb 2020 16:24:31 +0000 (UTC) X-FDA: 76514657142.07.boats13_27680d1099553 X-HE-Tag: boats13_27680d1099553 X-Filterd-Recvd-Size: 5030 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Fri, 21 Feb 2020 16:24:30 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id z9so2499825oth.5 for ; Fri, 21 Feb 2020 08:24:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2necOtKPRGOvCKSmF/mkYAKx6vUj3EgsCgdFv1SUhI0=; b=cBEVhpXst0AzntwHO7MAAC8tPgH/lHhw3JRg1tiTU84YvfHSiop6h5HEb7dD7ijKuo Tkw/ZNf20go4KH7TnldYOoZEAs0/HjhdC6mtapS6+Q3y/I7Q+YrEMV84Zr3jKw37sWpE U9Jl8f/7cOVM1MQYH54S4Vp6WSWKpzS2B9dUJOJpX4zoeMiFs4UP17D4CccHDAg8ZFR1 vCZ/8RYSCxh9NQiUxEt36OEadxPUC7ds7oA0vIxw+TkYSm380z9btYwB+23YYwbo8b8g 7XRdvaaGovLDozll686+2N7fCxFPusnOHgUUDjTiUfiXQ3pTNjxbkIR85nNqgJmQT6GQ 8i+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2necOtKPRGOvCKSmF/mkYAKx6vUj3EgsCgdFv1SUhI0=; b=dPhzc+yoE6TzCXiggOWBUZF62CPGJI4icmO2s9RLTztbWNqf98uc45qptLPTfwblg1 hwSl5LRSbaoQuYd5OwsIowMPoONncSeKp0sZYyzeodlLWbAUtyDet74dV6xi1Rcd8IQ+ pQ1fRQMoaourv6UrLKEBlXdKgvp8315hIdrsrudnbvTeVXenwgHqrDTXRSJIOsPYY8Gp ddiX9Xvf3XVLrPtqx7labJuQaG1mCSmbl9Ik6i7/jpD2pGrWWQcpyBNRuby6sp22i+je 82vLf7xT4nlnyy2J2YKAyjMC9civs7aQrJBH+T0leAuwXDorDGHZ/nFjNiZE7h0I1tZl kJGA== X-Gm-Message-State: APjAAAVhbFLJzxPqGgkYxDXvpSRvkFEXUOwtAjlFMCGLqmsKfCtrfuZU f4n2dpLUErJpN5GSc1e0NZbqX1ElNYECy0mBy6YYYw== X-Google-Smtp-Source: APXvYqxaf5u3WFzaIFaCrcTuxeBbhT11NwRGTSO9X8QeSchk7dKOD/6D3Clq0uqWRzW41IL9WLcTtDJa9yoQ436XJig= X-Received: by 2002:a9d:64d8:: with SMTP id n24mr27053866otl.71.1582302269868; Fri, 21 Feb 2020 08:24:29 -0800 (PST) MIME-Version: 1.0 References: <20200221032720.33893-1-alastair@au1.ibm.com> In-Reply-To: From: Dan Williams Date: Fri, 21 Feb 2020 08:24:18 -0800 Message-ID: Subject: Re: [PATCH v3 00/27] Add support for OpenCAPI Persistent Memory devices To: "Alastair D'Silva" Cc: alastair@d-silva.org, "Aneesh Kumar K . V" , "Oliver O'Halloran" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Anton Blanchard , Krzysztof Kozlowski , Mahesh Salgaonkar , Madhavan Srinivasan , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Anju T Sudhakar , Hari Bathini , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , Linux Kernel Mailing List , linuxppc-dev , linux-nvdimm , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 21, 2020 at 8:21 AM Dan Williams wrote: > > On Thu, Feb 20, 2020 at 7:28 PM Alastair D'Silva wrote: > > > > From: Alastair D'Silva > > > > This series adds support for OpenCAPI Persistent Memory devices, exposing > > them as nvdimms so that we can make use of the existing infrastructure. > > A single sentence to introduce: > > 24 files changed, 3029 insertions(+), 97 deletions(-) > > ...is inadequate. What are OpenCAPI Persistent Memory devices? How do > they compare, in terms relevant to libnvdimm, to other persistent > memory devices? What challenges do they pose to the existing enabling? > What is the overall approach taken with this 27 patch break down? What > are the changes since v2, v1? If you incorporated someone's review > feedback note it in the cover letter changelog, if you didn't Assumptions and tradeoffs the implementation considered are also critical for reviewing the approach.