From: Dan Williams <email@example.com> To: Shiyang Ruan <firstname.lastname@example.org> Cc: Linux Kernel Mailing List <email@example.com>, linux-xfs <firstname.lastname@example.org>, Linux NVDIMM <email@example.com>, Linux MM <firstname.lastname@example.org>, linux-fsdevel <email@example.com>, device-mapper development <firstname.lastname@example.org>, "Darrick J. Wong" <email@example.com>, david <firstname.lastname@example.org>, Christoph Hellwig <email@example.com>, Alasdair Kergon <firstname.lastname@example.org>, Mike Snitzer <email@example.com> Subject: Re: [PATCH RESEND v6 7/9] dm: Introduce ->rmap() to find bdev offset Date: Fri, 20 Aug 2021 16:46:27 -0700 [thread overview] Message-ID: <CAPcyv4ic+LDagR8uF18tO3cCb6t=YTZNkAOK=vnsnERqY6Ze_g@mail.gmail.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Fri, Jul 30, 2021 at 3:02 AM Shiyang Ruan <email@example.com> wrote: > > Pmem device could be a target of mapped device. In order to find out > the global location on a mapped device, we introduce this to translate > offset from target device to mapped device. > > Currently, we implement it on linear target, which is easy to do the > translation. Other targets will be supported in the future. However, > some targets may not support it because of the non-linear mapping. > > Signed-off-by: Shiyang Ruan <firstname.lastname@example.org> > --- > block/genhd.c | 56 +++++++++++++++++++++++++++++++++++ > drivers/md/dm-linear.c | 20 +++++++++++++ > include/linux/device-mapper.h | 5 ++++ > include/linux/genhd.h | 1 + > 4 files changed, 82 insertions(+) This might be where dax-device support needs to part ways with the block layer. As Christoph has mentioned before the long term goal for dax-devices (direct mapped byte-addressable media) is to have filesystems mount on them directly and abandon block-layer entanglements. This patch goes the opposite direct and adds more block layer infrastructure to support a dax-device need. Now, I'm not opposed to this moving forward, but I'm not sure block and DM maintainers will be excited about this additional maintenance burden. At the same time a lot of effort has been poured into dax-reflink and I want that support to move forward. So, my proposal while we figure out what to do about device-mapper rmap is to have fs_dax_register_holder() fail on device-mapper dax-devices until we get wider agreement amongst all involved that this is an additional burden worth carrying. In the meantime XFS on PMEM will see fs_dax_register_holder() succeed and DAX reflink support can be gated on whether the dax-device allowed the notify failure handler to be registered. Now, there may be room to allow reflink on device-mapper-dax for CONFIG_MEMORY_FAILURE=n builds, but that would collide with future work to use notify_failure for more than memory_failure, but also NVDIMM_REVALIDATE_POISON, and surprise memory-device-remove events. The code in this patch looks ok to me, just not the direction the dax-device layer was looking to go. It might be time to revive the discussions around support for concatenation and striping in the pmem driver itself, especially as the CXL label specification is already adding support for physically discontiguous namespaces. At a minimum if the patch set is organized to support XFS-reflink on PMEM-DAX and later XFS-reflink on DM-DAX some progress can be made without waiting for the whole set to be accepted.
next prev parent reply other threads:[~2021-08-20 23:46 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-30 10:01 [PATCH RESEND v6 0/9] fsdax: introduce fs query to support reflink Shiyang Ruan 2021-07-30 10:01 ` [PATCH RESEND v6 1/9] pagemap: Introduce ->memory_failure() Shiyang Ruan 2021-08-06 1:17 ` Jane Chu 2021-08-16 17:20 ` Jane Chu 2021-08-17 1:44 ` ruansy.fnst 2021-08-18 5:43 ` Jane Chu 2021-08-18 6:08 ` Jane Chu 2021-08-18 7:52 ` ruansy.fnst 2021-08-18 17:10 ` Dan Williams 2021-08-23 13:21 ` hch 2021-08-18 15:52 ` Darrick J. Wong 2021-08-19 7:18 ` Jane Chu 2021-08-19 8:11 ` Jane Chu 2021-08-19 9:10 ` ruansy.fnst 2021-08-19 20:50 ` Jane Chu 2021-08-20 16:07 ` Dan Williams 2021-07-30 10:01 ` [PATCH RESEND v6 2/9] dax: Introduce holder for dax_device Shiyang Ruan 2021-08-06 1:02 ` Jane Chu 2021-08-17 1:45 ` ruansy.fnst 2021-08-20 16:06 ` Dan Williams 2021-08-20 20:19 ` Dan Williams 2021-07-30 10:01 ` [PATCH RESEND v6 3/9] mm: factor helpers for memory_failure_dev_pagemap Shiyang Ruan 2021-08-06 1:00 ` Jane Chu 2021-08-20 16:54 ` Dan Williams 2021-07-30 10:01 ` [PATCH RESEND v6 4/9] pmem,mm: Implement ->memory_failure in pmem driver Shiyang Ruan 2021-08-20 20:51 ` Dan Williams 2021-07-30 10:01 ` [PATCH RESEND v6 5/9] mm: Introduce mf_dax_kill_procs() for fsdax case Shiyang Ruan 2021-08-06 0:59 ` Jane Chu 2021-08-20 22:40 ` Dan Williams 2021-07-30 10:01 ` [PATCH RESEND v6 6/9] xfs: Implement ->notify_failure() for XFS Shiyang Ruan 2021-08-06 0:50 ` Jane Chu 2021-08-20 22:56 ` Dan Williams 2021-08-20 22:59 ` Dan Williams 2021-07-30 10:01 ` [PATCH RESEND v6 7/9] dm: Introduce ->rmap() to find bdev offset Shiyang Ruan 2021-08-20 23:46 ` Dan Williams [this message] 2021-07-30 10:01 ` [PATCH RESEND v6 8/9] md: Implement dax_holder_operations Shiyang Ruan 2021-08-06 0:48 ` Jane Chu 2021-08-17 1:59 ` ruansy.fnst 2021-07-30 10:01 ` [PATCH RESEND v6 9/9] fsdax: add exception for reflinked files Shiyang Ruan 2021-08-06 0:46 ` Jane Chu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPcyv4ic+LDagR8uF18tO3cCb6t=YTZNkAOK=vnsnERqY6Ze_g@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH RESEND v6 7/9] dm: Introduce ->rmap() to find bdev offset' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).