From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97128C433FE for ; Tue, 12 Apr 2022 23:22:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05E176B0073; Tue, 12 Apr 2022 19:22:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00BF86B0074; Tue, 12 Apr 2022 19:22:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E16466B0075; Tue, 12 Apr 2022 19:22:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id D226D6B0073 for ; Tue, 12 Apr 2022 19:22:46 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 99D996250C for ; Tue, 12 Apr 2022 23:22:46 +0000 (UTC) X-FDA: 79349803932.05.F0FA4FF Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) by imf01.hostedemail.com (Postfix) with ESMTP id 33F2340005 for ; Tue, 12 Apr 2022 23:22:46 +0000 (UTC) Received: by mail-oi1-f180.google.com with SMTP id q129so352532oif.4 for ; Tue, 12 Apr 2022 16:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cXG2uBz6lRa6SmsxOh4UHnvAS1v6j3gtk2oaRONS+x4=; b=VPl1Lq9jWUOfdQHl/1KZuWWM6wCjlya9ZIm56mGgKOGxFiC5BaCc1BSVeUdc1pyItB BIIRsGb7m/uTTFP7EQ9bwdIRf6Qc2mw3gELQG2VwZAg2xJ2tVel9MI1+ME9SUoGaJ8Ck Z8ts0Cz8Sv7S9Fzd/Im/JfbGqbs45u5Dpd4A8hT36LVn0vEKF5gJNhz9Xj3HxeT5GFx9 3orzrVLxvjY3XUMpiLuJPsctZxiLUWVgCZp6UZHqMNblOrfxFCYbsUPAtL6PjFLKvIYv yR16Pm/ZW/nafNyxKUqk8z/2UQ0ECbaF4NEyEpOJWqi+m9FgHi5wKcizOSX3GGI9F65b O8Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cXG2uBz6lRa6SmsxOh4UHnvAS1v6j3gtk2oaRONS+x4=; b=xdbQ+jqUXNFEbgOfJz08pEhs1fsHTVoPKJ1AgpsjAkiZn/KNB4cXWsceCisD3lNhcZ xF10CUo+VIO+4fObsyK/CBnETbE6Dx6+ZqOZ7gJddX+guQrvaTrRUVz2awALVWhXT4Tw VZvQ2JsGdYbcVi/MUa0i+WX+H4M9S+MnM1KH/+4NnmTahzcYlCVjIpkD7UeB/BOp4xM2 CYzO3pO5bI9VJMt7OQn9GYbKTeqXEZ/WRIO8R8k9VBO8COdMrKSh4oy7vj4EdU/nHUCE qyGOxjsfvKSNpckSlXEeV94jsB/yxxmG3D6rrrKvZbe+RUOI4T1Qw0SVh7U0Vq2LDqFA yD1A== X-Gm-Message-State: AOAM533Tvos1SjEBmKxtTktsPR3dMhcaix5556WzODq6bDRDSWTe/S8B tt33kpDOLpKNaA7efiMR10W3WSZQ8lJFiUCFQ9j1cw== X-Google-Smtp-Source: ABdhPJzEsDa0QPWqZoKnqzlrHygJjKtOSvpADAV6Jhisjm10RxdCfr8ioS/LCXNm6BQQZeX47QnFzwejPCzwj9rtzOk= X-Received: by 2002:a05:6808:1154:b0:2da:2fbd:eba9 with SMTP id u20-20020a056808115400b002da2fbdeba9mr2979048oiu.133.1649805765445; Tue, 12 Apr 2022 16:22:45 -0700 (PDT) MIME-Version: 1.0 References: <20220410160904.3758789-1-ruansy.fnst@fujitsu.com> <20220410160904.3758789-2-ruansy.fnst@fujitsu.com> In-Reply-To: <20220410160904.3758789-2-ruansy.fnst@fujitsu.com> From: Dan Williams Date: Tue, 12 Apr 2022 16:22:34 -0700 Message-ID: Subject: Re: [PATCH v12 1/7] dax: Introduce holder for dax_device To: Shiyang Ruan Cc: Linux Kernel Mailing List , linux-xfs , Linux NVDIMM , Linux MM , linux-fsdevel , "Darrick J. Wong" , david , Christoph Hellwig , Jane Chu Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 33F2340005 X-Stat-Signature: qasz4r5qzfdfkgzjsgn9yudcyhzqxteb Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel-com.20210112.gappssmtp.com header.s=20210112 header.b=VPl1Lq9j; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=none (imf01.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.167.180) smtp.mailfrom=dan.j.williams@intel.com X-Rspam-User: X-HE-Tag: 1649805766-802007 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 10, 2022 at 9:09 AM Shiyang Ruan wrote: > > To easily track filesystem from a pmem device, we introduce a holder for > dax_device structure, and also its operation. This holder is used to > remember who is using this dax_device: > - When it is the backend of a filesystem, the holder will be the > instance of this filesystem. > - When this pmem device is one of the targets in a mapped device, the > holder will be this mapped device. In this case, the mapped device > has its own dax_device and it will follow the first rule. So that we > can finally track to the filesystem we needed. > > The holder and holder_ops will be set when filesystem is being mounted, > or an target device is being activated. > Looks good to me: Reviewed-by: Dan Williams I am assuming this will be staged in a common DAX branch, but holler now if this should go through the XFS tree.