From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A49C47409 for ; Fri, 31 Jan 2020 05:14:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E187520661 for ; Fri, 31 Jan 2020 05:14:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="YB4BUNeP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E187520661 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6ACAE6B04BA; Fri, 31 Jan 2020 00:14:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 636456B04BB; Fri, 31 Jan 2020 00:14:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D64D6B04BC; Fri, 31 Jan 2020 00:14:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 336506B04BA for ; Fri, 31 Jan 2020 00:14:47 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C4B568248047 for ; Fri, 31 Jan 2020 05:14:46 +0000 (UTC) X-FDA: 76436764572.04.mass05_63cbc1ad47757 X-HE-Tag: mass05_63cbc1ad47757 X-Filterd-Recvd-Size: 6129 Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Fri, 31 Jan 2020 05:14:45 +0000 (UTC) Received: by mail-oi1-f195.google.com with SMTP id i1so6102539oie.8 for ; Thu, 30 Jan 2020 21:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PMcuS4LHry0i7DZ7ldtekzqzj8KrQxFLARw5rUFC3dY=; b=YB4BUNePIM6enPmASfYT3cwjHuMA+cOwjd5AU1JFMP5dn8Yq9YXqx0L53gjl6Gyzkl 5kG1BNLepiYkWJbao814Aj5KzNKw/SxFciSCG9pAPQ1Vl31Lb+FRijSu2RlvWwqxmz1V t5OFCVsaMUxgTHH27jx3c7DfQTOYiNeCNZHhh4U1dkxfAuDoeJ0RoCD5pWybXaXBKCgR 5lg6a4vN6IMCyAVqu8i3QQhIjzPPi0qOUgutCMcqCoyTr/+f3QgmReQ1QgRvUUQDoQAM nEeQT5nqUOxl1z7kuLI9kthwhBXP3Zyf9wOXQ/9C1+PkspbY4Qep23XKZEohNh4rbaAF 79HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PMcuS4LHry0i7DZ7ldtekzqzj8KrQxFLARw5rUFC3dY=; b=uCUf888WmYdWuVoELeg8Jd3BUenyZtIzZyjCrW0x5DFeT/qciEqOvJr3te06hr+a1W xQZQ6ntnQ8gX+I1nYMq3kW/h0KNXN8gFC0w5dk6K1tkwr3TMfAXlrehVeWUnbraRbgRJ /UEzLYuS1aZ/NLC3irJXKmFQIp97CpubtRkKLmypLlTP69YjogMjkfIqRUNZz+nfHjCD F0JQYVyJJcrIgHX01rpkLI8o2Vpwp4i77Q77CF5imzDDk4Ul5nMhEHWL6WrlTE46Ys8D 9hoMnWiTKB9iGbyRhX7gfj3Okqa22qggr0foMF4ybXL0eMQkyxc58RHkPTO9BY0Qf6YS MDtg== X-Gm-Message-State: APjAAAW6M//4RsZV3jHAsYteC4FivMKXZIAV+77WclpKHOEiT6/bqREE Q7xfPUCxqOjWiVSXsWeyxGYvKNv52jxsM/UkCcTgrA== X-Google-Smtp-Source: APXvYqxj9SjLEO7AhYfAHVo9xLBu9Nup8mW6BzzYMbNeUvMlioFhNe3oNXeD4an0sNTe/yFKjrfStHsB04BMKeaIBuc= X-Received: by 2002:a05:6808:a83:: with SMTP id q3mr5446118oij.0.1580447684795; Thu, 30 Jan 2020 21:14:44 -0800 (PST) MIME-Version: 1.0 References: <20191025044721.16617-1-alastair@au1.ibm.com> <20191025044721.16617-10-alastair@au1.ibm.com> <3ba57ce6-9135-0d83-b99d-1c5b0c744855@linux.ibm.com> In-Reply-To: From: Dan Williams Date: Thu, 30 Jan 2020 21:14:33 -0800 Message-ID: Subject: Re: [PATCH 09/10] powerpc: Enable OpenCAPI Storage Class Memory driver on bare metal To: "Alastair D'Silva" Cc: Frederic Barrat , Oscar Salvador , Madhavan Srinivasan , Geert Uytterhoeven , David Hildenbrand , Wei Yang , Keith Busch , Linux MM , Michal Hocko , Paul Mackerras , Ira Weiny , Thomas Gleixner , Pavel Tatashin , Dave Jiang , linux-nvdimm , Vishal Verma , Krzysztof Kozlowski , Anju T Sudhakar , Mahesh Salgaonkar , Andrew Donnellan , Arnd Bergmann , Greg Kurz , Qian Cai , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Hari Bathini , Greg Kroah-Hartman , Linux Kernel Mailing List , Vasant Hegde , Andrew Morton , linuxppc-dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 30, 2020 at 8:57 PM Alastair D'Silva wro= te: > > On Fri, 2019-11-08 at 08:10 +0100, Frederic Barrat wrote: > > > > Le 25/10/2019 =C3=A0 06:47, Alastair D'Silva a =C3=A9crit : > > > From: Alastair D'Silva > > > > > > Enable OpenCAPI Storage Class Memory driver on bare metal > > > > > > Signed-off-by: Alastair D'Silva > > > --- > > > arch/powerpc/configs/powernv_defconfig | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/arch/powerpc/configs/powernv_defconfig > > > b/arch/powerpc/configs/powernv_defconfig > > > index 6658cceb928c..45c0eff94964 100644 > > > --- a/arch/powerpc/configs/powernv_defconfig > > > +++ b/arch/powerpc/configs/powernv_defconfig > > > @@ -352,3 +352,7 @@ CONFIG_KVM_BOOK3S_64=3Dm > > > CONFIG_KVM_BOOK3S_64_HV=3Dm > > > CONFIG_VHOST_NET=3Dm > > > CONFIG_PRINTK_TIME=3Dy > > > +CONFIG_OCXL_SCM=3Dm > > > +CONFIG_DEV_DAX=3Dy > > > +CONFIG_DEV_DAX_PMEM=3Dy This specific line is not needed since DEV_DAX_PMEM already defaults to DEV= _DAX. > > > +CONFIG_FS_DAX=3Dy > > > > If this really the intent or do we want to activate DAX only if > > CONFIG_OCXL_SCM is enabled? > > > > Fred > > We had a bit of a play around with reworking this the other day. > > Putting them in as depends didn't make sense, as they are "soft" > dependancies - the driver works and you can do some things without DAX. > > Adding them as selects was rejected as selecting symbols that can also > be manually select is discouraged. > > We ended up going full circle and adding them back to the defconfig. This dovetails with a suggestion Dave made a while back [1]. Given all the pieces that need to be turned on to have a "feature complete" persistent memory enabled build it would be nice to have general config symbols that go and select all the necessary dependencies for DAX, and let the rest happen by default. [1]: https://lore.kernel.org/lkml/20161129021052.GF28177@dastard/