From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 018A0C433E0 for ; Tue, 23 Jun 2020 21:15:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8DA0620706 for ; Tue, 23 Jun 2020 21:15:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="YChY4/EG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DA0620706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E93E56B0002; Tue, 23 Jun 2020 17:15:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E431A6B0003; Tue, 23 Jun 2020 17:15:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7F886B0008; Tue, 23 Jun 2020 17:15:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id BD83D6B0002 for ; Tue, 23 Jun 2020 17:15:38 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0F6E95A364 for ; Tue, 23 Jun 2020 21:15:38 +0000 (UTC) X-FDA: 76961733156.23.ship54_17009c026e3e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id D640A37604 for ; Tue, 23 Jun 2020 21:15:37 +0000 (UTC) X-HE-Tag: ship54_17009c026e3e X-Filterd-Recvd-Size: 4424 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Tue, 23 Jun 2020 21:15:36 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id z17so5496347edr.9 for ; Tue, 23 Jun 2020 14:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P/a2gbmPrfzKZgrMWGCChbggZ0/wE/cGco+2jd4C/7s=; b=YChY4/EGiQ5VTXFGUFGFmq3+lZnyPUCsCYVoDiosA6DmZ4LDu0KSLqZ8lh/myZbPG1 Gcy2pOZ/uWcYHHp6GhVeMbcosWZWUewRybYgMfBIkB/nWCe4rqWkfISZMYNBwApkMY8K tVjYu7C+mO0AaAHthTof7bCmo+UHSpAoBcJxJIw2q4pFbLWrbOhRtT98Gx7Ou+67LP1q XHFEep7YNSFk92GUEvkuF/2fg1SIoYXSzl8uVTOD9VrJOzsXuGuCyCizZQ7lM4WESxLw eAzwxmpMRmQ9J20UgP9yFGiN6NNZzjv03JVJXdtyGO3eoIqDgavitctvTvVzBCBfjcVA j9jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P/a2gbmPrfzKZgrMWGCChbggZ0/wE/cGco+2jd4C/7s=; b=WwZEaccu3Vj/wLjx9Ri3qhimz/lAaro7jT4g0cozA5gs2fCeL5o5Uky+taoN+Czn2L jMHQFucB8Df6clymx4eq5eHtccv0b1HttuvuHdtYiT1ZAHRac3r1CL82o64b2xyjHmp2 gVgsELcFEqrkhWLVJzTCx62wBRhMKT8BQ592qAIvJ9feyjsqYSNJkicX6GCWe10ddnsC loy1WG1UvZj8FLrGZdJzTEZeam0LOnmf+U9mjtt1Yz9GjjRmgcUqjGsdu5w9XqYgTYIf DSGi3BNCO5T9T9iUA7bJEfW+8v+luG1ehi0+8Ot7OiUUkSNZUMS3VViNnvgEENClzeBV P4eg== X-Gm-Message-State: AOAM531QUzFAEdZTepGbNApN11BRc4LAJAMuzz7XoA1KxmeL4uW6O0wX zIKSHDoa1QF/gGqTYZ2DIGhx4mAbTiD/c7avDP8BPg== X-Google-Smtp-Source: ABdhPJwiRU11aW7hp405eS+bX8JNNrfbrB8kWaMHZ4aLXoHOaSUyXemO4m/lQ99UWFKS/XGsXhj8LJhiJHxYahoYipU= X-Received: by 2002:a50:d9cb:: with SMTP id x11mr9031435edj.93.1592946935407; Tue, 23 Jun 2020 14:15:35 -0700 (PDT) MIME-Version: 1.0 References: <20200619125923.22602-1-david@redhat.com> <20200619125923.22602-3-david@redhat.com> In-Reply-To: From: Dan Williams Date: Tue, 23 Jun 2020 14:15:24 -0700 Message-ID: Subject: Re: [PATCH v2 2/3] mm/memory_hotplug: document why shuffle_zone() is relevant To: David Hildenbrand Cc: Linux Kernel Mailing List , Linux MM , Andrew Morton , Alexander Duyck , Michal Hocko Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D640A37604 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 22, 2020 at 12:28 AM David Hildenbrand wrote: > > On 20.06.20 03:41, Dan Williams wrote: > > On Fri, Jun 19, 2020 at 6:00 AM David Hildenbrand wrote: > >> > >> It's not completely obvious why we have to shuffle the complete zone, as > >> some sort of shuffling is already performed when onlining pages via > >> __free_one_page(), placing MAX_ORDER-1 pages either to the head or the tail > >> of the freelist. Let's document why we have to shuffle the complete zone > >> when exposing larger, contiguous physical memory areas to the buddy. > >> > > > > How about? > > > > Fixes: e900a918b098 ("mm: shuffle initial free memory to improve > > memory-side-cache utilization") > > > > ...just like Patch1 since that original commit was missing the proper > > commentary in the code? > > Hmm, mixed feelings. I (working for a distributor :) ) prefer fixes tags > for actual BUGs, as described in > > Documentation/process/submitting-patches.rst: "If your patch fixes a bug > in a specific commit, e.g. you found an issue using ``git bisect``, > please use the 'Fixes:' tag with the first 12 characters" ... > > So unless there are strong feelings, I'll not add a fixes tag (although > I agree, that it should have been contained in the original commit). It doesn't need to be "Fixes", but how about at least mentioning the original commit as a breadcrumb so that some future "git blame" archaeology effort is streamlined.