From: Dan Williams <dan.j.williams@intel.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
Christoph Hellwig <hch@lst.de>, Linux MM <linux-mm@kvack.org>,
dm-devel@redhat.com, Ross Zwisler <ross.zwisler@linux.intel.com>,
Laura Abbott <labbott@redhat.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
"Luck, Tony" <tony.luck@intel.com>
Subject: Re: [dm-devel] [PATCH] vmalloc: introduce vmap_pfn for persistent memory
Date: Thu, 9 Nov 2017 10:58:43 -0800 [thread overview]
Message-ID: <CAPcyv4j6K13wjn+BQJ-_S1iuuxuU6_XsfhwKRc9ZkxxGH9xc-Q@mail.gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1711091340140.5328@file01.intranet.prod.int.rdu2.redhat.com>
On Thu, Nov 9, 2017 at 10:51 AM, Mikulas Patocka <mpatocka@redhat.com> wrote:
[..]
>> The drivers don't need to react, once the pages are pinned for dma the
>> hot-unplug will not progress until all those page references are
>> dropped.
>
> I am not talking about moving pages here, I'm talking about possible
> hardware errors in persistent memory. In this situation, the storage
> controller receives an error on the bus - and the question is, how will it
> react. Ideally, it should abort just this transfer and return an error
> that the driver will propagate up. But I'm skeptical that someone is
> really testing the controllers and drivers for this possiblity.
This is something that drive controllers already need to deal with
today on DRAM, but I suspect you are right because in general
error-path testing in drivers is rare to non-existent in Linux. We can
endeavor to do better with persistent memory where we have some
explicit error injection facilities defined in ACPI that might enjoy
wider support than the existing EINJ facility.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-11-09 18:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 22:03 [PATCH] vmalloc: introduce vmap_pfn for persistent memory Mikulas Patocka
2017-11-08 9:59 ` Christoph Hellwig
2017-11-08 12:33 ` Mikulas Patocka
2017-11-08 15:04 ` Christoph Hellwig
2017-11-08 15:21 ` Mikulas Patocka
2017-11-08 15:35 ` [dm-devel] " Christoph Hellwig
2017-11-08 15:41 ` Dan Williams
2017-11-08 20:15 ` Mikulas Patocka
2017-11-08 20:25 ` Dan Williams
2017-11-09 16:40 ` Mikulas Patocka
2017-11-09 16:45 ` Dan Williams
2017-11-09 17:30 ` Mikulas Patocka
2017-11-09 17:35 ` Dan Williams
2017-11-08 17:42 ` Mikulas Patocka
2017-11-08 17:47 ` Christoph Hellwig
2017-11-08 20:26 ` Mikulas Patocka
2017-11-08 21:26 ` Dan Williams
2017-11-09 16:37 ` Mikulas Patocka
2017-11-09 16:49 ` Dan Williams
2017-11-09 18:13 ` Mikulas Patocka
2017-11-09 18:38 ` Dan Williams
2017-11-09 18:51 ` Mikulas Patocka
2017-11-09 18:58 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4j6K13wjn+BQJ-_S1iuuxuU6_XsfhwKRc9ZkxxGH9xc-Q@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=kirill.shutemov@linux.intel.com \
--cc=labbott@redhat.com \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mpatocka@redhat.com \
--cc=ross.zwisler@linux.intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).