From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40CDCC3F2C6 for ; Sat, 29 Feb 2020 22:33:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0420924672 for ; Sat, 29 Feb 2020 22:33:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="MJlh0jh6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0420924672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7782F6B0005; Sat, 29 Feb 2020 17:33:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73AF36B0006; Sat, 29 Feb 2020 17:33:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63E496B0007; Sat, 29 Feb 2020 17:33:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id 4B9586B0005 for ; Sat, 29 Feb 2020 17:33:21 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 05F4E180ACF8F for ; Sat, 29 Feb 2020 22:33:21 +0000 (UTC) X-FDA: 76544617002.10.sound32_57681f274af5c X-HE-Tag: sound32_57681f274af5c X-Filterd-Recvd-Size: 5219 Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Sat, 29 Feb 2020 22:33:20 +0000 (UTC) Received: by mail-oi1-f193.google.com with SMTP id a22so6595697oid.13 for ; Sat, 29 Feb 2020 14:33:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0+qFmqhcgb7jhEPbeVLEVdCHOr+If3XHxdqQ1tb+5pc=; b=MJlh0jh6fKGmlMf8QKHfSMGKxkzGHEeUxIKuMK576jnOzp5ajBbWFd723+Nwz5sX5o kd5kFB1Qa4nMK4C2Quz1EtosMFhbFGty2TrTrSeM0926YL1M9TjPuncmtlZef3BqKcKO 0QMDkTU7/GfTsJIR/w5n5LoqIVS0h8Ha+vMH2bvx31vmcGio+VmcVwwkaawh8iuK3FDK B8oJ2LCRKfwY4UJPa+Ufg0yoRxTMpdzcD2JzNOx//OiTA4E21r9KhphDTjUvXXJpa4mN qph+2qengVBm0C0Rc0eQp7M69RV9q8SQixDZKId1V2L1G6rpoNj9Qc0++zW1EeGd/ZTO X0Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0+qFmqhcgb7jhEPbeVLEVdCHOr+If3XHxdqQ1tb+5pc=; b=DQ22puiBnACUADrAWEZNQF6P31fvB1Eocqf+jx9ktVBjCjW8tB2/Ozq4YWVz6Su2Wf FFSjMNxHe6TRUlExTrP10aLd7zYCZ6Ijtz+gHr0IXyVuyNON4gXVR9aTGqB5OmIHq3CZ F/o4sAhTGxTkJ6YcNk1yQow+1fCLaKm03gC796NMVLh4kkJqmdYImq4poKMMKmiciaqt ibQE/VP1+XBQrOpgyPS5sLBI5BXJVwO0AIpIAbY8M1FYYr8qZ/IF1zjv9vXmXbSptnFq Cc0w6vyEpTwudMLxL12ojfa0+nXX60EDmKxaBOxKZPN8Dgp2auCLE1UE8upvJR2agOPV /6TA== X-Gm-Message-State: APjAAAWghWVTo2MZr4CZiVv9T4qVpdeZOjL0OulVNG3XnGquO+HYFsxT 8qFgULKo3ja8USLwx3uwlR60O74dy3pq/JaCTis6Eg== X-Google-Smtp-Source: APXvYqyGoDfozeCQcvGtfIbG5zusEz6FXIH1C19GvJgWOw0G4+LzaZgF0KV8DfFmkR6MhUJ7WBGfGAzVDBqWpHKu+yI= X-Received: by 2002:a54:4791:: with SMTP id o17mr6946593oic.70.1583015599612; Sat, 29 Feb 2020 14:33:19 -0800 (PST) MIME-Version: 1.0 References: <20200221182503.28317-1-logang@deltatee.com> <20200221182503.28317-5-logang@deltatee.com> In-Reply-To: <20200221182503.28317-5-logang@deltatee.com> From: Dan Williams Date: Sat, 29 Feb 2020 14:33:08 -0800 Message-ID: Subject: Re: [PATCH v3 4/7] x86/mm: Introduce _set_memory_prot() To: Logan Gunthorpe Cc: Linux Kernel Mailing List , Linux ARM , linux-ia64@vger.kernel.org, linuxppc-dev , linux-s390 , Linux-sh , platform-driver-x86@vger.kernel.org, Linux MM , Michal Hocko , David Hildenbrand , Andrew Morton , Christoph Hellwig , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Eric Badger , "H. Peter Anvin" , X86 ML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 21, 2020 at 10:25 AM Logan Gunthorpe wrote: > > For use in the 32bit arch_add_memory() to set the pgprot type of the > memory to add. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Signed-off-by: Logan Gunthorpe > --- > arch/x86/include/asm/set_memory.h | 1 + > arch/x86/mm/pat/set_memory.c | 7 +++++++ > 2 files changed, 8 insertions(+) > > diff --git a/arch/x86/include/asm/set_memory.h b/arch/x86/include/asm/set_memory.h > index 64c3dce374e5..0aca959cf9a4 100644 > --- a/arch/x86/include/asm/set_memory.h > +++ b/arch/x86/include/asm/set_memory.h > @@ -34,6 +34,7 @@ > * The caller is required to take care of these. > */ > > +int _set_memory_prot(unsigned long addr, int numpages, pgprot_t prot); I wonder if this should be separated from the naming convention of the other routines because this is only an internal helper for code paths where the prot was established by an upper layer. For example, I expect that the kernel does not want new usages to make the mistake of calling: _set_memory_prot(..., pgprot_writecombine(pgprot)) ...instead of _set_memory_wc() I'm thinking just a double underscore rename (__set_memory_prot) and a kerneldoc comment for that pointing people to use the direct _set_memory_ helpers. With that you can add: Reviewed-by: Dan Williams