From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ADABC433ED for ; Wed, 5 May 2021 23:03:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8511D6112D for ; Wed, 5 May 2021 23:03:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8511D6112D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 07F9C6B006C; Wed, 5 May 2021 19:03:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0300D6B006E; Wed, 5 May 2021 19:03:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEC8C6B0070; Wed, 5 May 2021 19:03:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0006.hostedemail.com [216.40.44.6]) by kanga.kvack.org (Postfix) with ESMTP id BF28E6B006C for ; Wed, 5 May 2021 19:03:37 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2C613906D for ; Wed, 5 May 2021 23:03:37 +0000 (UTC) X-FDA: 78108706074.07.4B67A7A Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf03.hostedemail.com (Postfix) with ESMTP id 98CB1C0007F4 for ; Wed, 5 May 2021 23:03:26 +0000 (UTC) Received: by mail-ej1-f49.google.com with SMTP id u21so5331451ejo.13 for ; Wed, 05 May 2021 16:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/mxPURQrKLZpHCunAXZDURfdLRg8vPCpqP2FXtjQFn8=; b=O1l3ozN47zLge+d2ZQ5g43S6Yuwq7uzi2m7Av4dXOsh2hwke1R/8eU0t0X5gIBEo6o ElqQgRKkM0Y6RGwIDxhgS/Zy0MFdD7cXkFN4gH/z3L8FVYz12PrSLpWBHF+PBPxdHhH1 EmjUg4BrW630yKYiPpbjKpaniAd4GUxcsWiWG7kfkSuPH5zrLvPAZucp1FY3XLTzOOLR 0k9CVi+tsaV19gTNw/Q1oarQGylEDKs26AKxwep1mQmFSodFqqI4PgpabjTAaWnzUcVj hqGOFiRWJwnq2vot2/dIM8jXCz2xNffLwf0IJKXxUxL3pUuWDz6KQtei3ks54ikUHu1p FPkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/mxPURQrKLZpHCunAXZDURfdLRg8vPCpqP2FXtjQFn8=; b=RVVLZpenYAR2tr1C8jAGCZUaaXQkAj7BIiRHoVNT0Vq/wO56ppg5yFJviQjxhCE6S5 UCRsiQ4iMvpqqwAP4w9x+J2UbyRYiZ+HjjsvyG54KAQTuayDPngnek+QAH1lHmJRHwK9 CTpQUKqikK2JvR+mMqB8UiQUoLPYt5x9UI3s9kBSBelB8JzvF/3yEqP3DG1wvttqKFPF BYhI/+MlahSEieWVhcqGj/B7T8ENMOTluZ/1VrpY9Yi0qpnh9aahdQRVNy1xqmamMVFw B4suIiOwIwGsrfgN/L+e2XEu7Yhke6N/miZZ5mQoZlGv5G30Up51nmnY/0/iifAcohz0 3O1A== X-Gm-Message-State: AOAM533huhttYD0/iNVMCZ9hEtgUltB5Ftn0AJy1R7fNSecL31W0HhB9 uysm20NcEq3tpz3PNuLHleN6nncOJKXCw4XrrFeBtg== X-Google-Smtp-Source: ABdhPJzQx3kM1jIzPHmXVA0dwSZfdsyCI0AZMfCah9vWVrgMpmLofyzWSevjdYrQ+QD6XyrBuEr9oCVmVL27S0ao+Q4= X-Received: by 2002:a17:906:9381:: with SMTP id l1mr1091356ejx.45.1620255812213; Wed, 05 May 2021 16:03:32 -0700 (PDT) MIME-Version: 1.0 References: <20210325230938.30752-1-joao.m.martins@oracle.com> <20210325230938.30752-5-joao.m.martins@oracle.com> <56a3e271-4ef8-ba02-639e-fd7fe7de7e36@oracle.com> In-Reply-To: <56a3e271-4ef8-ba02-639e-fd7fe7de7e36@oracle.com> From: Dan Williams Date: Wed, 5 May 2021 16:03:36 -0700 Message-ID: Subject: Re: [PATCH v1 04/11] mm/memremap: add ZONE_DEVICE support for compound pages To: Joao Martins Cc: Linux MM , Ira Weiny , linux-nvdimm , Matthew Wilcox , Jason Gunthorpe , Jane Chu , Muchun Song , Mike Kravetz , Andrew Morton Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel-com.20150623.gappssmtp.com header.s=20150623 header.b=O1l3ozN4; spf=none (imf03.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.218.49) smtp.mailfrom=dan.j.williams@intel.com; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 98CB1C0007F4 X-Stat-Signature: m9ra4p6drbzrb3em86h4fxmj9j6sgoh8 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=mail-ej1-f49.google.com; client-ip=209.85.218.49 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620255806-922947 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 5, 2021 at 3:36 PM Joao Martins wrote: [..] > > Ah yup, my eyes glazed over that. I think this is another place that > > benefits from a more specific name than "align". "pfns_per_compound" > > "compound_pfns"? > > > We are still describing a page, just not a base page. So perhaps @pfns_per_hpage ? > > I am fine with @pfns_per_compound or @compound_pfns as well. My only concern about hpage is that hpage implies PMD, where compound is generic across PMD and PUD.