From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C746C433EF for ; Fri, 8 Apr 2022 06:26:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C25DA6B0071; Fri, 8 Apr 2022 02:26:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD5606B0074; Fri, 8 Apr 2022 02:26:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9DBF8D0001; Fri, 8 Apr 2022 02:26:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 998896B0072 for ; Fri, 8 Apr 2022 02:26:20 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6175C2586D for ; Fri, 8 Apr 2022 06:26:20 +0000 (UTC) X-FDA: 79332727320.03.CE589B3 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf09.hostedemail.com (Postfix) with ESMTP id DE1EE140002 for ; Fri, 8 Apr 2022 06:26:19 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id 32so4842915pgl.4 for ; Thu, 07 Apr 2022 23:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=g35dmgX32k/R7TxnuKRf02cyb1nmI23wQu6jsuLVbVU=; b=wlSIBbbSFHb+JhPPPwZhYXbD7WTAYzJ9ooeCOJ4TJorGTR9S6YbwY6kt+RuyigO524 kMvXQrASEbH6rcmScjaHvcogjfqkb8NJlfaBW2HLpnN56HWsI5uwggQ+dYV/aoIepw/E nURCc8MnNjmA0kvJ5xVOTCAndDTK2kjR54OW2WJBfuINbnBPEn1OXIKcmO1sLyaob2Ed 9WV7jQkkHpFjZGrAf5cVdT00/H55NyENNDR9ohZpO6Hq09QYEVUxnOtII9fZ0Q0VRD+x sv0Gji5mFmzwSVQRwIxHosZoXz1DCVg7lzTFeipG8MZ1kmYnGngZUkUnKri1pi1o27UQ FLEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=g35dmgX32k/R7TxnuKRf02cyb1nmI23wQu6jsuLVbVU=; b=6PLj3HsDqYmEV70RAGm9wIIudAh8e7c+y1jyQbKkXkOHccKcPpx1i0eAkGGEq9RvsZ swONdi8leL9bO3XQegDKrf5p/iNcB3kji1AooQM+n1T/HRO5qF84G6wl+hmHX+MuZQO2 lDtpA6iUfFSo2z/ugdliylAxk4wDBnm2mu7VflQ9618NLfpSz58qTUvEM4ROK08iwCmp +FfnNjDsQ+kfLtkQlZzjhmfwgYlfqRo98coiPYjAuAzMFI3T1S/OfIgq/1szO/iBsfxp IEEP9ZAglMH1z0bOs+rfNtst6vOyfSrVjkhTUG87Zuss1dAkG0whUHLTSkKX872EQKqE JR6w== X-Gm-Message-State: AOAM530eemnusIJT/BnCi+AnI/g8FAfGpgiVEM3NyznQ/0/oaQoDkX5N zZ1qLsxYwl2XNGdD8CsF1Ig4n7CS0VrUgWASC/3w5Q== X-Google-Smtp-Source: ABdhPJwZpPAQGEBsOe2H4Ew1tYOWqLCmIf5LQhtcpsvQh/Ztm9JTK+n38+TDSeB0NMkBLck/NVWRLJvt/A/qt2vd7YI= X-Received: by 2002:a05:6a00:8c5:b0:4fe:134d:30d3 with SMTP id s5-20020a056a0008c500b004fe134d30d3mr18016783pfu.3.1649399178836; Thu, 07 Apr 2022 23:26:18 -0700 (PDT) MIME-Version: 1.0 References: <20220227120747.711169-1-ruansy.fnst@fujitsu.com> <20220227120747.711169-8-ruansy.fnst@fujitsu.com> <8f1931d2-b224-de98-4593-df136f397eb4@fujitsu.com> In-Reply-To: <8f1931d2-b224-de98-4593-df136f397eb4@fujitsu.com> From: Dan Williams Date: Thu, 7 Apr 2022 23:26:08 -0700 Message-ID: Subject: Re: [PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS To: Shiyang Ruan Cc: Christoph Hellwig , Linux Kernel Mailing List , linux-xfs , Linux NVDIMM , Linux MM , linux-fsdevel , "Darrick J. Wong" , david , Jane Chu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: cpo1uc9rx6aqoz5auwdga78hhma654b3 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DE1EE140002 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel-com.20210112.gappssmtp.com header.s=20210112 header.b=wlSIBbbS; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=none (imf09.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.215.169) smtp.mailfrom=dan.j.williams@intel.com X-Rspam-User: X-HE-Tag: 1649399179-366632 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 7, 2022 at 11:05 PM Shiyang Ruan wrot= e: > > > > =E5=9C=A8 2022/3/30 14:00, Christoph Hellwig =E5=86=99=E9=81=93: > >> @@ -1892,6 +1893,8 @@ xfs_free_buftarg( > >> list_lru_destroy(&btp->bt_lru); > >> > >> blkdev_issue_flush(btp->bt_bdev); > >> + if (btp->bt_daxdev) > >> + dax_unregister_holder(btp->bt_daxdev, btp->bt_mount); > >> fs_put_dax(btp->bt_daxdev); > >> > >> kmem_free(btp); > >> @@ -1939,6 +1942,7 @@ xfs_alloc_buftarg( > >> struct block_device *bdev) > >> { > >> xfs_buftarg_t *btp; > >> + int error; > >> > >> btp =3D kmem_zalloc(sizeof(*btp), KM_NOFS); > >> > >> @@ -1946,6 +1950,14 @@ xfs_alloc_buftarg( > >> btp->bt_dev =3D bdev->bd_dev; > >> btp->bt_bdev =3D bdev; > >> btp->bt_daxdev =3D fs_dax_get_by_bdev(bdev, &btp->bt_dax_part_off= ); > >> + if (btp->bt_daxdev) { > >> + error =3D dax_register_holder(btp->bt_daxdev, mp, > >> + &xfs_dax_holder_operations); > >> + if (error) { > >> + xfs_err(mp, "DAX device already in use?!"); > >> + goto error_free; > >> + } > >> + } > > > > It seems to me that just passing the holder and holder ops to > > fs_dax_get_by_bdev and the holder to dax_unregister_holder would > > significantly simply the interface here. > > > > Dan, what do you think? > > Hi Dan, > > Could you give some advise on this API? Is it needed to move > dax_register_holder's job into fs_dax_get_by_bdev()? Yes, works for me to just add them as optional arguments.