From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F9AFC5517A for ; Fri, 23 Oct 2020 21:16:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D431124671 for ; Fri, 23 Oct 2020 21:16:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ylYjv002" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D431124671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A8C436B005D; Fri, 23 Oct 2020 17:16:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A14DD6B0062; Fri, 23 Oct 2020 17:16:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88D566B0068; Fri, 23 Oct 2020 17:16:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 5447F6B005D for ; Fri, 23 Oct 2020 17:16:09 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E638F180AD81D for ; Fri, 23 Oct 2020 21:16:08 +0000 (UTC) X-FDA: 77404448016.03.owner55_4b15e082725c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id BFFE428A4EA for ; Fri, 23 Oct 2020 21:16:08 +0000 (UTC) X-HE-Tag: owner55_4b15e082725c X-Filterd-Recvd-Size: 4815 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Fri, 23 Oct 2020 21:16:08 +0000 (UTC) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9CB192465B for ; Fri, 23 Oct 2020 21:16:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603487767; bh=qQcFmOGTx12wPD63RiThRe7Vh0MNAYSb3WtVSv6KO9I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ylYjv002r5/d4PJz5MfpZMB4thciSwlk1eXkJiCA3bvenmoPxzuiHjvcXDcackAcE w6VNJ7rBH6083fbGYBlG3chnrNZbtJNPqO54/g2gQKHUjVIOrFDXlaNINXtFbJdoKt OK0nV4hNeaJ18/R+8VfmdHAtYYky9/5RkmV0QCgE= Received: by mail-lj1-f172.google.com with SMTP id m20so3021760ljj.5 for ; Fri, 23 Oct 2020 14:16:06 -0700 (PDT) X-Gm-Message-State: AOAM530fxBOWf5MOGFEHEESG1j4XAkDCzZ1RgtEhtXgAmPddeFpsQ6O+ xTX4n5t8npYYY0DIoaeAtH8pYPcgFWV3YpWeJXM= X-Google-Smtp-Source: ABdhPJxMP4Oqfuc0h+oHI0VayAXX1a002RyckvG+CEYT7Qe0w/jJqsSdKxhG124OF9Ag+jl4aWynWIOTPbYK55JDXo0= X-Received: by 2002:a05:651c:cd:: with SMTP id 13mr1498277ljr.392.1603487764782; Fri, 23 Oct 2020 14:16:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Song Liu Date: Fri, 23 Oct 2020 14:15:53 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [LTP] mmstress[1309]: segfault at 7f3d71a36ee8 ip 00007f3d77132bdf sp 00007f3d71a36ee8 error 4 in libc-2.27.so[7f3d77058000+1aa000] To: Linus Torvalds Cc: Naresh Kamboju , =?UTF-8?B?RGFuaWVsIETDrWF6?= , Stephen Rothwell , "Matthew Wilcox (Oracle)" , "Peter Zijlstra (Intel)" , Viresh Kumar , X86 ML , open list , lkft-triage@lists.linaro.org, "Eric W. Biederman" , linux-mm , linux-m68k , Linux-Next Mailing List , Thomas Gleixner , kasan-dev , Dmitry Vyukov , Geert Uytterhoeven , Christian Brauner , Ingo Molnar , LTP List , Al Viro Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 23, 2020 at 10:51 AM Linus Torvalds wrote: > > On Fri, Oct 23, 2020 at 10:00 AM Naresh Kamboju > wrote: > > > > [Old patch from yesterday] > > > > After applying your patch on top on linux next tag 20201015 > > there are two observations, > > 1) i386 build failed. please find build error build > > Yes, this was expected. That patch explicitly only works on x86-64, > because 32-bit needs the double register handling for 64-bit values > (mainly loff_t). > > > 2) x86_64 kasan test PASS and the reported error not found. > > Ok, good. That confirms that the problem you reported is indeed the > register allocation. > > The patch I sent an hour ago (the one based on Rasmus' one from > yesterday) should fix things too, and - unlike yesterday's - work on > 32-bit. > > But I'll wait for confirmation (and hopefully a sign-off from Rasmus > so that I can give him authorship) before actually committing it. > > Linus My test vm failed to boot since commit d55564cfc222326e944893eff0c4118353e349ec x86: Make __put_user() generate an out-of-line call The patch also fixed it. Thanks! Song