From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF021C433DB for ; Wed, 17 Mar 2021 09:37:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4FC9B64F41 for ; Wed, 17 Mar 2021 09:37:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FC9B64F41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A01CA6B006E; Wed, 17 Mar 2021 05:37:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B2316B0070; Wed, 17 Mar 2021 05:37:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 806856B0071; Wed, 17 Mar 2021 05:37:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 62EBE6B006E for ; Wed, 17 Mar 2021 05:37:38 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 087AB6D9F for ; Wed, 17 Mar 2021 09:37:37 +0000 (UTC) X-FDA: 77928863754.26.DC3C3D2 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by imf22.hostedemail.com (Postfix) with ESMTP id 6FCF6C0007C3 for ; Wed, 17 Mar 2021 09:37:36 +0000 (UTC) Received: by mail-vs1-f46.google.com with SMTP id z65so672776vsz.12 for ; Wed, 17 Mar 2021 02:37:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YanYEWxC0nmXDJGG/pEUT8+3+7thSzlQsa+GmZUSq5Q=; b=W9gbDrvytGWPxzU31xmB/tdqOou3Rp3/gq58aieb+VDm6CIyP6fpoiAzzKvpiA5ruY xIjMQnBcH0we0J1n1/Km/r60HaI9X0RnRxU3OhvjM8fRqpQvqkrwGX779G0xF4d3Mo2a gTjCzwLztRe0HuhuA9J3F5C6gU5bkJx/jCR3KWVtbkeXLzx+NIKqXvOvzceMPKtI4GwQ fiEw2I6m61EIbdftDk9y+9Lrb4xWBr86PnYBytVhJ38XxSChKD5I4QDrp4dLxQFnvQXx yn8BoiECoKNdXScX+b/a4bELPznRlSRMsTOCGSCwiTULLOmFxsIaidXdTskIA8xF7bHr Q1Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YanYEWxC0nmXDJGG/pEUT8+3+7thSzlQsa+GmZUSq5Q=; b=GrGa+Hdr571v+Jr4GccSDgKLUHHxIT1acqLF1sGRWcQPk2QsXVjMGPFQw9B1c1Qz5r /B0duLmiegqRs/V2givjgW2pX655vhByywIqEwa4hxpvLvMwBqnwQnLIfm6klfdzUyf+ BUeigryIfAuvDppp3mYZ9b0NvXzcbviDSvCZ4rQNImzSYjrFVqIUlm/PzNRL/BgLuwvu HI0k8wu9CZB0I7RrAKY8qvSWqBQ73GrG5OGucUh67zCSz1EDbzy7MPGyK7ZU06TPQpt/ Cl/zIAFfC2fVrbJ2xOcqehNA13BMHzniiCTdJUCIv/opwqwLD8YbL/5iKrXaZoYU+/jg MB2g== X-Gm-Message-State: AOAM533xGUcKpjWunpL20obVy57HBV1hKdH79UIs4kr8MGrfTBstR/kz aVUGPfCoU4gORRbzl/Dx9kxPvfmJKHnICPKlY+E= X-Google-Smtp-Source: ABdhPJxOeFlbMP7mdsyD346B9rZSXg/NWwvuXqyDihtWzfoAksJ5vYoLDkbOFtYfDvAk5iGy/9CzkJ+JM4R4L++1TS0= X-Received: by 2002:a67:cf8c:: with SMTP id g12mr2299815vsm.10.1615973855761; Wed, 17 Mar 2021 02:37:35 -0700 (PDT) MIME-Version: 1.0 References: <20210316124237.3469-1-jarvis.w.jiang@gmail.com> In-Reply-To: From: =?UTF-8?B?6JKL5aiB?= Date: Wed, 17 Mar 2021 17:37:23 +0800 Message-ID: Subject: Re: [PATCH] Add MHI bus support and driver for T99W175 5G modem To: Mike Rapoport Cc: davem@davemloft.net, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org, cchen50@lenovo.com, mpearson@lenovo.com Content-Type: multipart/alternative; boundary="000000000000a397ad05bdb83b87" X-Stat-Signature: smdiwemdisgsc3ajst4rdp8hoecfyji5 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6FCF6C0007C3 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=mail-vs1-f46.google.com; client-ip=209.85.217.46 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615973856-555427 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000a397ad05bdb83b87 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I will divide the changes into a series of patches according to your suggestion, thank you. Thanks, Jarvis Mike Rapoport =E4=BA=8E2021=E5=B9=B43=E6=9C=8816=E6=97= =A5=E5=91=A8=E4=BA=8C =E4=B8=8B=E5=8D=889:30=E5=86=99=E9=81=93=EF=BC=9A > On Tue, Mar 16, 2021 at 05:42:37AM -0700, Jarvis Jiang wrote: > > T99W175 using MBIM or RmNet over PCIe interface with > > MHI protocol support. > > Ported from IPQ8072 platform, including MHI, MBIM, RmNet > > > > Supporting below PCI devices: > > > > PCI_DEVICE(0x17cb, 0x0300) > > PCI_DEVICE(0x17cb, 0x0301) > > PCI_DEVICE(0x17cb, 0x0302) > > PCI_DEVICE(0x17cb, 0x0303) > > PCI_DEVICE(0x17cb, 0x0304) > > PCI_DEVICE(0x17cb, 0x0305) > > PCI_DEVICE(0x17cb, 0x0306) > > PCI_DEVICE(0x105b, 0xe0ab) > > PCI_DEVICE(0x105b, 0xe0b0) > > PCI_DEVICE(0x105b, 0xe0b1) > > PCI_DEVICE(0x105b, 0xe0b3) > > PCI_DEVICE(0x1269, 0x00b3) > > PCI_DEVICE(0x03f0, 0x0a6c) > > > > Signed-off-by: Jarvis Jiang > > --- > > MAINTAINERS | 16 + > > drivers/bus/Kconfig | 1 + > > drivers/bus/Makefile | 3 + > > drivers/bus/mhi/Kconfig | 27 + > > drivers/bus/mhi/Makefile | 9 + > > drivers/bus/mhi/controllers/Kconfig | 13 + > > drivers/bus/mhi/controllers/Makefile | 2 + > > drivers/bus/mhi/controllers/mhi_arch_qti.c | 275 ++ > > drivers/bus/mhi/controllers/mhi_qti.c | 970 +++++++ > > drivers/bus/mhi/controllers/mhi_qti.h | 44 + > > drivers/bus/mhi/core/Makefile | 2 + > > drivers/bus/mhi/core/mhi_boot.c | 590 +++++ > > drivers/bus/mhi/core/mhi_dtr.c | 223 ++ > > drivers/bus/mhi/core/mhi_init.c | 1901 ++++++++++++++ > > drivers/bus/mhi/core/mhi_internal.h | 826 ++++++ > > drivers/bus/mhi/core/mhi_main.c | 2261 +++++++++++++++++ > > drivers/bus/mhi/core/mhi_pm.c | 1158 +++++++++ > > drivers/bus/mhi/devices/Kconfig | 43 + > > drivers/bus/mhi/devices/Makefile | 3 + > > drivers/bus/mhi/devices/mhi_netdev.c | 1830 +++++++++++++ > > drivers/bus/mhi/devices/mhi_satellite.c | 1155 +++++++++ > > drivers/bus/mhi/devices/mhi_uci.c | 802 ++++++ > > drivers/net/ethernet/qualcomm/rmnet/Makefile | 2 +- > > .../ethernet/qualcomm/rmnet/rmnet_config.c | 131 +- > > .../ethernet/qualcomm/rmnet/rmnet_config.h | 110 +- > > .../qualcomm/rmnet/rmnet_descriptor.c | 1225 +++++++++ > > .../qualcomm/rmnet/rmnet_descriptor.h | 152 ++ > > .../ethernet/qualcomm/rmnet/rmnet_handlers.c | 321 ++- > > .../ethernet/qualcomm/rmnet/rmnet_handlers.h | 27 +- > > .../net/ethernet/qualcomm/rmnet/rmnet_map.h | 238 +- > > .../qualcomm/rmnet/rmnet_map_command.c | 304 ++- > > .../ethernet/qualcomm/rmnet/rmnet_map_data.c | 1029 +++++++- > > .../ethernet/qualcomm/rmnet/rmnet_private.h | 19 +- > > .../net/ethernet/qualcomm/rmnet/rmnet_trace.h | 250 ++ > > .../net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 101 +- > > .../net/ethernet/qualcomm/rmnet/rmnet_vnd.h | 16 +- > > include/linux/ipc_logging.h | 291 +++ > > include/linux/mhi.h | 743 ++++++ > > include/linux/mod_devicetable.h | 22 +- > > include/linux/msm-bus.h | 214 ++ > > include/linux/msm_pcie.h | 173 ++ > > include/linux/netdevice.h | 18 +- > > include/uapi/linux/if_link.h | 4 + > > include/uapi/linux/msm_rmnet.h | 170 ++ > > mm/memblock.c | 2 + > > net/core/dev.c | 192 +- > > 46 files changed, 17700 insertions(+), 208 deletions(-) > > This is way too much for a single patch. Please split your changes into a > series of patches, with one logical change per patch. For instance, you c= an > start with adding skeleton infrastructure for MHI, then add particular > implementations for it, and on top you can add device drivers that rely o= n > MHI core. > > -- > Sincerely yours, > Mike. > --000000000000a397ad05bdb83b87 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I will divide the changes into a series of patches accordi= ng to your suggestion, thank you.

Thanks,
Jarvis

Mike Rapoport= <rppt@linux.ibm.com> =E4= =BA=8E2021=E5=B9=B43=E6=9C=8816=E6=97=A5=E5=91=A8=E4=BA=8C =E4=B8=8B=E5=8D= =889:30=E5=86=99=E9=81=93=EF=BC=9A
On Tue, Mar 16, 2021 at 05:42:37AM -0700, Jarvis Jiang w= rote:
> T99W175 using MBIM or RmNet over PCIe interface with
> MHI protocol support.
> Ported from IPQ8072 platform, including MHI, MBIM, RmNet
>
> Supporting below PCI devices:
>
>=C2=A0 =C2=A0PCI_DEVICE(0x17cb, 0x0300)
>=C2=A0 =C2=A0PCI_DEVICE(0x17cb, 0x0301)
>=C2=A0 =C2=A0PCI_DEVICE(0x17cb, 0x0302)
>=C2=A0 =C2=A0PCI_DEVICE(0x17cb, 0x0303)
>=C2=A0 =C2=A0PCI_DEVICE(0x17cb, 0x0304)
>=C2=A0 =C2=A0PCI_DEVICE(0x17cb, 0x0305)
>=C2=A0 =C2=A0PCI_DEVICE(0x17cb, 0x0306)
>=C2=A0 =C2=A0PCI_DEVICE(0x105b, 0xe0ab)
>=C2=A0 =C2=A0PCI_DEVICE(0x105b, 0xe0b0)
>=C2=A0 =C2=A0PCI_DEVICE(0x105b, 0xe0b1)
>=C2=A0 =C2=A0PCI_DEVICE(0x105b, 0xe0b3)
>=C2=A0 =C2=A0PCI_DEVICE(0x1269, 0x00b3)
>=C2=A0 =C2=A0PCI_DEVICE(0x03f0, 0x0a6c)
>
> Signed-off-by: Jarvis Jiang <jarvis.w.jiang@gmail.com>
> ---
>=C2=A0 MAINTAINERS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|= =C2=A0 =C2=A016 +
>=C2=A0 drivers/bus/Kconfig=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 1 +
>=C2=A0 drivers/bus/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 3 +
>=C2=A0 drivers/bus/mhi/Kconfig=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A027 +
>=C2=A0 drivers/bus/mhi/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 9 +
>=C2=A0 drivers/bus/mhi/controllers/Kconfig=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0|=C2=A0 =C2=A013 +
>=C2=A0 drivers/bus/mhi/controllers/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 |=C2=A0 =C2=A0 2 +
>=C2=A0 drivers/bus/mhi/controllers/mhi_arch_qti.c=C2=A0 =C2=A0 |=C2=A0 = 275 ++
>=C2=A0 drivers/bus/mhi/controllers/mhi_qti.c=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0|=C2=A0 970 +++++++
>=C2=A0 drivers/bus/mhi/controllers/mhi_qti.h=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0|=C2=A0 =C2=A044 +
>=C2=A0 drivers/bus/mhi/core/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 2 +
>=C2=A0 drivers/bus/mhi/core/mhi_boot.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 590 +++++
>=C2=A0 drivers/bus/mhi/core/mhi_dtr.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 |=C2=A0 223 ++
>=C2=A0 drivers/bus/mhi/core/mhi_init.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0| 1901 ++++++++++++++
>=C2=A0 drivers/bus/mhi/core/mhi_internal.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0|=C2=A0 826 ++++++
>=C2=A0 drivers/bus/mhi/core/mhi_main.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0| 2261 +++++++++++++++++
>=C2=A0 drivers/bus/mhi/core/mhi_pm.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0| 1158 +++++++++
>=C2=A0 drivers/bus/mhi/devices/Kconfig=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A043 +
>=C2=A0 drivers/bus/mhi/devices/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 3 +
>=C2=A0 drivers/bus/mhi/devices/mhi_netdev.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 | 1830 +++++++++++++
>=C2=A0 drivers/bus/mhi/devices/mhi_satellite.c=C2=A0 =C2=A0 =C2=A0 =C2= =A0| 1155 +++++++++
>=C2=A0 drivers/bus/mhi/devices/mhi_uci.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0|=C2=A0 802 ++++++
>=C2=A0 drivers/net/ethernet/qualcomm/rmnet/Makefile=C2=A0 |=C2=A0 =C2= =A0 2 +-
>=C2=A0 .../ethernet/qualcomm/rmnet/rmnet_config.c=C2=A0 =C2=A0 |=C2=A0 = 131 +-
>=C2=A0 .../ethernet/qualcomm/rmnet/rmnet_config.h=C2=A0 =C2=A0 |=C2=A0 = 110 +-
>=C2=A0 .../qualcomm/rmnet/rmnet_descriptor.c=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0| 1225 +++++++++
>=C2=A0 .../qualcomm/rmnet/rmnet_descriptor.h=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0|=C2=A0 152 ++
>=C2=A0 .../ethernet/qualcomm/rmnet/rmnet_handlers.c=C2=A0 |=C2=A0 321 += +-
>=C2=A0 .../ethernet/qualcomm/rmnet/rmnet_handlers.h=C2=A0 |=C2=A0 =C2= =A027 +-
>=C2=A0 .../net/ethernet/qualcomm/rmnet/rmnet_map.h=C2=A0 =C2=A0|=C2=A0 = 238 +-
>=C2=A0 .../qualcomm/rmnet/rmnet_map_command.c=C2=A0 =C2=A0 =C2=A0 =C2= =A0 |=C2=A0 304 ++-
>=C2=A0 .../ethernet/qualcomm/rmnet/rmnet_map_data.c=C2=A0 | 1029 ++++++= +-
>=C2=A0 .../ethernet/qualcomm/rmnet/rmnet_private.h=C2=A0 =C2=A0|=C2=A0 = =C2=A019 +-
>=C2=A0 .../net/ethernet/qualcomm/rmnet/rmnet_trace.h |=C2=A0 250 ++
>=C2=A0 .../net/ethernet/qualcomm/rmnet/rmnet_vnd.c=C2=A0 =C2=A0|=C2=A0 = 101 +-
>=C2=A0 .../net/ethernet/qualcomm/rmnet/rmnet_vnd.h=C2=A0 =C2=A0|=C2=A0 = =C2=A016 +-
>=C2=A0 include/linux/ipc_logging.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 291 +++
>=C2=A0 include/linux/mhi.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 743 ++++++
>=C2=A0 include/linux/mod_devicetable.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A022 +-
>=C2=A0 include/linux/msm-bus.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 214 ++
>=C2=A0 include/linux/msm_pcie.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 173 ++
>=C2=A0 include/linux/netdevice.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A018 +-
>=C2=A0 include/uapi/linux/if_link.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 4 +
>=C2=A0 include/uapi/linux/msm_rmnet.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 |=C2=A0 170 ++
>=C2=A0 mm/memblock.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 =C2=A0 2 +
>=C2=A0 net/core/dev.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 192 = +-
>=C2=A0 46 files changed, 17700 insertions(+), 208 deletions(-)

This is way too much for a single patch. Please split your changes into a series of patches, with one logical change per patch. For instance, you can=
start with adding skeleton infrastructure for MHI, then add particular
implementations for it, and on top you can add device drivers that rely on<= br> MHI core.

--
Sincerely yours,
Mike.
--000000000000a397ad05bdb83b87--