linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Qian Cai <cai@lca.pw>
To: Michal Hocko <mhocko@kernel.org>
Cc: David Hildenbrand <david@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH v1] mm/memory_hotplug: don't check the nid in find_(smallest|biggest)_section_pfn
Date: Thu, 28 Nov 2019 12:22:57 -0500	[thread overview]
Message-ID: <D7EFF3C1-E603-4729-8ABE-EBB6994795BF@lca.pw> (raw)
In-Reply-To: <20191128154637.GO26807@dhcp22.suse.cz>



> On Nov 28, 2019, at 10:46 AM, Michal Hocko <mhocko@kernel.org> wrote:
> 
> I tend to push back on cleanups without a clear added value. In this
> particular case it is not about aesthetic or a personal feeling about
> the code though. Please read my comment with the ack.

I can only encourage you to push back more in general especially for those micro-size cleanups. On the other hand, it could be arbitrary because once you are gone for vacations or some other reasons, it will be inconsistent of reviewing. You are mostly of my first defense those days.

  reply	other threads:[~2019-11-28 17:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27 17:41 [PATCH v1] mm/memory_hotplug: don't check the nid in find_(smallest|biggest)_section_pfn David Hildenbrand
2019-11-27 19:03 ` Qian Cai
2019-11-27 19:05   ` David Hildenbrand
2019-11-27 19:37     ` Qian Cai
2019-11-27 19:52       ` David Hildenbrand
2019-11-27 20:49         ` David Hildenbrand
2019-11-27 22:56           ` Qian Cai
2019-11-28  8:46             ` David Hildenbrand
2019-11-28 13:56               ` Qian Cai
2019-11-28 14:03                 ` David Hildenbrand
2019-11-28 14:30                   ` Qian Cai
2019-11-28 14:42                     ` Michal Hocko
2019-11-28 14:52                       ` David Hildenbrand
2019-11-28 15:29                         ` Qian Cai
2019-11-28 15:31                           ` David Hildenbrand
2019-11-28 17:31                             ` Qian Cai
2019-11-28 15:46                           ` Michal Hocko
2019-11-28 17:22                             ` Qian Cai [this message]
2019-11-28 10:15 ` Michal Hocko
2019-11-28 13:52 ` Oscar Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D7EFF3C1-E603-4729-8ABE-EBB6994795BF@lca.pw \
    --to=cai@lca.pw \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=osalvador@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).