From: Peng Fan <peng.fan@nxp.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "labbott@redhat.com" <labbott@redhat.com>,
"mhocko@suse.com" <mhocko@suse.com>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
"rppt@linux.vnet.ibm.com" <rppt@linux.vnet.ibm.com>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"andreyknvl@google.com" <andreyknvl@google.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"van.freenix@gmail.com" <van.freenix@gmail.com>,
Mike Rapoport <rppt@linux.ibm.com>
Subject: RE: [PATCH] mm/cma: cma_declare_contiguous: correct err handling
Date: Fri, 15 Feb 2019 01:30:40 +0000 [thread overview]
Message-ID: <DB7PR04MB449005901376F086215EC79A88600@DB7PR04MB4490.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190214123824.fe95cc2e603f75382490bfb4@linux-foundation.org>
Hi Andrew
> -----Original Message-----
> From: Andrew Morton [mailto:akpm@linux-foundation.org]
> Sent: 2019年2月15日 4:38
> To: Peng Fan <peng.fan@nxp.com>
> Cc: labbott@redhat.com; mhocko@suse.com; vbabka@suse.cz;
> iamjoonsoo.kim@lge.com; rppt@linux.vnet.ibm.com;
> m.szyprowski@samsung.com; rdunlap@infradead.org;
> andreyknvl@google.com; linux-mm@kvack.org; linux-kernel@vger.kernel.org;
> van.freenix@gmail.com; Mike Rapoport <rppt@linux.ibm.com>
> Subject: Re: [PATCH] mm/cma: cma_declare_contiguous: correct err handling
>
> On Thu, 14 Feb 2019 12:45:51 +0000 Peng Fan <peng.fan@nxp.com> wrote:
>
> > In case cma_init_reserved_mem failed, need to free the memblock
> > allocated by memblock_reserve or memblock_alloc_range.
> >
> > ...
> >
> > --- a/mm/cma.c
> > +++ b/mm/cma.c
> > @@ -353,12 +353,14 @@ int __init cma_declare_contiguous(phys_addr_t
> > base,
> >
> > ret = cma_init_reserved_mem(base, size, order_per_bit, name,
> res_cma);
> > if (ret)
> > - goto err;
> > + goto free_mem;
> >
> > pr_info("Reserved %ld MiB at %pa\n", (unsigned long)size / SZ_1M,
> > &base);
> > return 0;
> >
> > +free_mem:
> > + memblock_free(base, size);
> > err:
> > pr_err("Failed to reserve %ld MiB\n", (unsigned long)size / SZ_1M);
> > return ret;
>
> This doesn't look right to me. In the `fixed==true' case we didn't actually
> allocate anything and in the `fixed==false' case, the allocated memory is at
> `addr', not at `base'.
My code base is 5.0.0-rc6, in mm/cma.c
313 /* Reserve memory */
314 if (fixed) {
315 if (memblock_is_region_reserved(base, size) ||
316 memblock_reserve(base, size) < 0) {
317 ret = -EBUSY;
318 goto err;
319 }
320 } else {
When fixed is true, memblock_is_region_reserved will check whether the [base, base + size)
is reserved, if reserved, return -EBUSY, if not reserved, it will call memblock_reserve,
if memblock_reserve fail, it will return -EBUSY.
When fixed is false, after memblock_alloc_range, there is one line code `base = addr;`.
Thanks,
Peng.
next prev parent reply other threads:[~2019-02-15 1:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 12:45 [PATCH] mm/cma: cma_declare_contiguous: correct err handling Peng Fan
2019-02-14 20:38 ` Andrew Morton
2019-02-15 1:30 ` Peng Fan [this message]
2019-02-19 16:55 ` Vlastimil Babka
2019-02-19 17:46 ` Mike Rapoport
2019-02-22 12:55 ` Peng Fan
2019-02-26 11:11 ` Mike Rapoport
2019-02-26 14:52 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR04MB449005901376F086215EC79A88600@DB7PR04MB4490.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mhocko@suse.com \
--cc=rdunlap@infradead.org \
--cc=rppt@linux.ibm.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=van.freenix@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).