From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A284C2D0E5 for ; Sun, 29 Mar 2020 20:17:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DCE2320748 for ; Sun, 29 Mar 2020 20:17:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WgBrDqjC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCE2320748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3A2816B0010; Sun, 29 Mar 2020 16:17:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32D956B0032; Sun, 29 Mar 2020 16:17:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CC576B0036; Sun, 29 Mar 2020 16:17:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id F19186B0010 for ; Sun, 29 Mar 2020 16:17:56 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id ADFDB181AD0A4 for ; Sun, 29 Mar 2020 20:17:56 +0000 (UTC) X-FDA: 76649510952.16.pain23_b1c508309c55 X-HE-Tag: pain23_b1c508309c55 X-Filterd-Recvd-Size: 5692 Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Sun, 29 Mar 2020 20:17:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585513075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Z/GKnoApwDISehfLDnr2cxO3scdl3tgBNt7AVM46sU=; b=WgBrDqjCyuyMoj6JFLsgWGp4RFvyAuHTKRutX7Ml73eO1/ZPAlEnygz1nRSnZ3RdO8JDIu ilS4w53qamolCKgJu6840YX2i+XImiEaOfK5hfR10eyzP1a3Q7ZRWmeh8tT/yY9ovTcglF ex9t7GwNe/gqdN7crXhVuVAcuJse0uM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-44-svNzPMoDNSeG-u7lhoI14w-1; Sun, 29 Mar 2020 16:17:50 -0400 X-MC-Unique: svNzPMoDNSeG-u7lhoI14w-1 Received: by mail-wr1-f70.google.com with SMTP id t25so6855200wrb.16 for ; Sun, 29 Mar 2020 13:17:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=5YQVKx16TS+5clxSLtkXpe8YoP0huXDFkfGYX4zkxME=; b=lvSTPeYvVdjo8PZq+8o8b9wlq3K4ej8aItF+xOnsxYt6Vy+AASxNdLIrDKqVfOn6so k23MkiC9CzXelhPeuC5Zdgnlzka0+xJ1Vr7rqFdKEsFFqqnQpsr06kgUy59stsBZBUxQ b1PTw4yvgOSVrQqilqlSXPn0C7+l2RAZK5eGRmPovJaW8AbxYZuWFlI6mO4sGIrJUSIt 20vobm/RGdbm2JqlutvwixFF4np9qu2Dz6HUQrmAzbc++k/qonKKtBBIGY36222Hnoyy EDq9KIZbQIHHATNKJnPZZjUMphBCRcE1YGnq94lPgYRaX/RVYD5iqn02pqz3WlW4bvbT yzKg== X-Gm-Message-State: ANhLgQ20hKKzJZ3G8vgkPIuS70iYWExIcdZ/OxOHVXXDPc8SRFV/W7qJ CQiFt2Hw1upNLu7HAdsOYePnPEDRXwb/M55Ny3IjCOSlqps1sjFTv5tF/9Xfo3ErI/Dx0xvA5wI 7tzWQqgQjDlc= X-Received: by 2002:a5d:4cc4:: with SMTP id c4mr11020552wrt.346.1585513068827; Sun, 29 Mar 2020 13:17:48 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvGOR9hvsxil64/+f2JpUGFAdf8Qlt+ucWEguEIT6KS905fdsOrxkr5UEtxCIOY0arEv/XlQQ== X-Received: by 2002:a5d:4cc4:: with SMTP id c4mr11020522wrt.346.1585513068448; Sun, 29 Mar 2020 13:17:48 -0700 (PDT) Received: from [192.168.3.122] (p4FF23127.dip0.t-ipconnect.de. [79.242.49.39]) by smtp.gmail.com with ESMTPSA id j11sm18440236wrt.14.2020.03.29.13.17.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Mar 2020 13:17:46 -0700 (PDT) From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v2 1/2] mm/memory_hotplug: simplify calculation of number of pages in __remove_pages() Date: Sun, 29 Mar 2020 22:17:46 +0200 Message-Id: References: Cc: David Hildenbrand , Linux Kernel Mailing List , Linux-MM , Segher Boessenkool , Andrew Morton , Oscar Salvador , Michal Hocko , Baoquan He , Dan Williams , Wei Yang In-Reply-To: To: Linus Torvalds X-Mailer: iPhone Mail (17D50) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 29.03.2020 um 22:10 schrieb Linus Torvalds : >=20 > =EF=BB=BFOn Sun, Mar 29, 2020 at 12:19 PM David Hildenbrand wrote: >>=20 >> This patch seems to have another of these weird MIME crap in it. (my >> other patches in -next seem to be fine) >>=20 >> See >>=20 >> https://lore.kernel.org/linux-mm/20200228095819.10750-2-david@redhat.com= /raw >=20 > That email actually looks fine. >=20 > Yes, it has that >=20 > fro=3D > m >=20 > pattern, but it also has >=20 > Content-Transfer-Encoding: quoted-printable >=20 > so the recipient should be doing the right thing with that pattern. >=20 > The patch itself also has MIME encoding in it: >=20 > - cur_nr_pages =3D3D min(end_pfn - pfn, -(pfn | PAGE_SECTION_MASK)); > + cur_nr_pages =3D3D min(end_pfn - pfn, >=20 > so the patch wouldn't even apply unless the recipient did the proper > MIME decode of the message. >=20 > That's also why the non-raw message looks fine: >=20 > https://lore.kernel.org/linux-mm/20200228095819.10750-2-david@redhat.com= / >=20 > because the raw message data has the proper encoding information. >=20 > In contrast, look at the email that Andrew sent me and that I complained = about: >=20 > https://lore.kernel.org/linux-mm/20200329021719.MBKzW0xSl%25akpm@linux-= foundation.org/ >=20 > and notice how that *non-raw* email has that >=20 > Withou=3D > t >=20 > pattern in it. And when you look at the raw one: >=20 > https://lore.kernel.org/linux-mm/20200329021719.MBKzW0xSl%25akpm@linux-f= oundation.org/raw >=20 > it has no content transfer encoding line in the headers. Interesting, at least the patch in -next is messed up. I remember Andrew ad= apted some scripts, maybe this is a leftover. Cheers! >=20 > Linus >=20