linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Muchun Song <muchun.song@linux.dev>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: linux-kernel@vger.kernel.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Muchun Song <songmuchun@bytedance.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Matthew Wilcox <willy@infradead.org>,
	John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH mm-unstable] mm: move folio_set_compound_order() to mm/internal.h
Date: Thu, 15 Dec 2022 13:31:24 +0800	[thread overview]
Message-ID: <E39CAB80-2745-498C-8CDF-A469430F0276@linux.dev> (raw)
In-Reply-To: <cda1b5ca-a03e-e545-d206-30d74ed33a3d@oracle.com>



> On Dec 15, 2022, at 13:09, Sidhartha Kumar <sidhartha.kumar@oracle.com> wrote:
> 
> On 12/14/22 7:44 PM, Muchun Song wrote:
>>> On Dec 14, 2022, at 05:20, Sidhartha Kumar <sidhartha.kumar@oracle.com> wrote:
>>> 
>>> folio_set_compound_order() is moved to an mm-internal location so external
>>> folio users cannot misuse this function. Change the name of the function
>>> to folio_set_order() and use WARN_ON_ONCE() rather than BUG_ON. Also,
>>> handle the case if a non-large folio is passed and add clarifying comments
>>> to the function.
>>> 
>>> Link: https://lore.kernel.org/lkml/20221207223731.32784-1-sidhartha.kumar@oracle.com/T/
>>> Fixes: 9fd330582b2f ("mm: add folio dtor and order setter functions")
>>> 
>>> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
>>> Suggested-by: Mike Kravetz <mike.kravetz@oracle.com>
>>> Suggested-by: Muchun Song <songmuchun@bytedance.com>
>>> Suggested-by: Matthew Wilcox <willy@infradead.org>
>>> Suggested-by: John Hubbard <jhubbard@nvidia.com>
>> Reviewed-by: Muchun Song <songmuchun@bytedance.com>
> Hi Muchun,
> 
> Does this review include the change from

Yes.

Thanks.

> 
> + if (!folio_test_large(folio)) {
> + 	WARN_ON_ONCE(order);
> + 	return;
> + }
> 
> to
> 
> if (WARN_ON_ONCE(!folio_test_large(folio)))
> 	return;
> 
> discussed in in this thread?
> 
> Thanks,
> Sidhartha Kumar
>> Thanks.




  reply	other threads:[~2022-12-15  5:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 21:20 [PATCH mm-unstable] mm: move folio_set_compound_order() to mm/internal.h Sidhartha Kumar
2022-12-14  8:43 ` John Hubbard
2022-12-14 20:35   ` Sidhartha Kumar
2022-12-14 22:53     ` John Hubbard
2022-12-15  3:44 ` Muchun Song
2022-12-15  5:09   ` Sidhartha Kumar
2022-12-15  5:31     ` Muchun Song [this message]
2022-12-16 22:27 ` Andrew Morton
2022-12-16 22:56   ` John Hubbard
2022-12-16 23:09     ` Andrew Morton
2022-12-16 23:10     ` Sidhartha Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E39CAB80-2745-498C-8CDF-A469430F0276@linux.dev \
    --to=muchun.song@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=sidhartha.kumar@oracle.com \
    --cc=songmuchun@bytedance.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).