From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D47BC5DF60 for ; Thu, 7 Nov 2019 18:46:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DFF2D222C9 for ; Thu, 7 Nov 2019 18:46:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="Z0PkFnsy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFF2D222C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 90AAB6B0003; Thu, 7 Nov 2019 13:46:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BBAB6B0005; Thu, 7 Nov 2019 13:46:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AA176B0007; Thu, 7 Nov 2019 13:46:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0115.hostedemail.com [216.40.44.115]) by kanga.kvack.org (Postfix) with ESMTP id 61C3F6B0003 for ; Thu, 7 Nov 2019 13:46:17 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 09C8D52B0 for ; Thu, 7 Nov 2019 18:46:17 +0000 (UTC) X-FDA: 76130361594.05.sleet24_36cf92eb4af0e X-HE-Tag: sleet24_36cf92eb4af0e X-Filterd-Recvd-Size: 3997 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Nov 2019 18:46:16 +0000 (UTC) Received: by mail-qk1-f179.google.com with SMTP id z16so2930347qkg.7 for ; Thu, 07 Nov 2019 10:46:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=+chcOyGPBv2K4W0vOWjlkXipPyfb94O/MxzVmuLrPt4=; b=Z0PkFnsyvVhEMYr8T3z0+uGGQ7Er4KWNeYBoPBOr0s2LcmV14lKr9WHo/npj/3DZiJ JzWqe6ZIueo8kebXWuaZ5LO4R4Oo8xHuWCmV10rgqdMtzrGOn+SqAf2tv+fQloOmMy46 jg9hjx98szVT6b1TlUTaJM3IOdLOt57qFx1gxeHNvA/H0v+5U0YgecbbS+wWN7uqqo1a pXikh/UfO1AUN0htA7Kb8ElR4qePj9zBQox3iTt0rdiLtcPJ94+Gf6wrInpoOtWwNwLp VE/++XVRd8ZgpJg8Ll7GvuragWA3Vgm6HMzfqQjOYte82YUClLlkulJ0IyQ0nl+aiEq+ SgDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=+chcOyGPBv2K4W0vOWjlkXipPyfb94O/MxzVmuLrPt4=; b=mYAA6XD1lqWfPwtfwTOC/rpWqvf0cbfTFY1hMf2C3w+MYumD7QhhbU/udk/9I+kE8x m7d8ohz0swwr05GPPNc8JTLSvED/nBv6qp4N98QSSZs81ZHZ0KpAeQWw55S581Gc9jNx sRy/HhiM/mIViXnwe4WuSJz98sL1qF6AaAiUWm3d/8C8VgGbM339OTVCg/ZgHJvYsabY IckYSmo5wBzXvZ40ScGHFH6l8VueagNM/6ni6UvvXLgaAtIzojwWh/jvDVjBhoexs7AL 4xTZERiSOnBKgz2a5T60b1Drk0O8FHPO7HTfoiVBmdGlY41Vxgu9zlA15aBIJPjnsnm+ DFzg== X-Gm-Message-State: APjAAAWO5UkY7859197QwHyH7cW8L90TFqqPD5eZhLCBcU3M609HS0ia ixJmCO19mDTamiyMXeUiqJ1cGA== X-Google-Smtp-Source: APXvYqxCjeoDEr0OJle5a71dPWm5r+1/9u1+qXLj5gzPSAdaK6YoVQqbe+btXdS6D54YMENMoiqeqg== X-Received: by 2002:a37:c44b:: with SMTP id h11mr4469054qkm.234.1573152375995; Thu, 07 Nov 2019 10:46:15 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id x194sm1311764qkb.66.2019.11.07.10.46.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Nov 2019 10:46:15 -0800 (PST) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: + mm-introduce-reported-pages.patch added to -mm tree Date: Thu, 7 Nov 2019 13:46:14 -0500 Message-Id: References: Cc: David Hildenbrand , Alexander Duyck , Michal Hocko , akpm@linux-foundation.org, aarcange@redhat.com, dan.j.williams@intel.com, konrad.wilk@oracle.com, lcapitulino@redhat.com, mgorman@techsingularity.net, mm-commits@vger.kernel.org, mst@redhat.com, osalvador@suse.de, pagupta@redhat.com, pbonzini@redhat.com, riel@surriel.com, vbabka@suse.cz, wei.w.wang@intel.com, willy@infradead.org, yang.zhang.wz@gmail.com, linux-mm@kvack.org In-Reply-To: To: Dave Hansen X-Mailer: iPhone Mail (17A878) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Nov 7, 2019, at 12:12 PM, Dave Hansen wrote: >=20 > Am I missing something? What's the harm in merging the implementation > that's ready today? If a better one comes along, we'll rip out the ~15 > lines of code in page_alloc.c and merge the better one. No, it is increasingly hard to rip out any code in MM nowadays once merged (= looks at those early debugging SLUB code existing for probably 10 years unus= ed, but yet the bar is high to justify removing), so it is important to take= time to get it right the first time by all means.=