From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E77C433E0 for ; Thu, 28 May 2020 15:22:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9A9F420888 for ; Thu, 28 May 2020 15:22:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A9F420888 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 207E98001A; Thu, 28 May 2020 11:22:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B92D80010; Thu, 28 May 2020 11:22:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A7D68001A; Thu, 28 May 2020 11:22:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id E366780010 for ; Thu, 28 May 2020 11:22:34 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 919D01839AD86 for ; Thu, 28 May 2020 15:22:34 +0000 (UTC) X-FDA: 76866494628.22.way49_2bc4128093239 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 9444518267136 for ; Thu, 28 May 2020 15:21:41 +0000 (UTC) X-HE-Tag: way49_2bc4128093239 X-Filterd-Recvd-Size: 3442 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 May 2020 15:21:39 +0000 (UTC) IronPort-SDR: sDHgwdHRNzzwqgGY+HDfCcCMa7bPnxIdTy13YpHzBhoQ5IGUr/d0bgrd8gL0548LhVLPX02ayr NBHXaL7qYUlg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2020 08:21:37 -0700 IronPort-SDR: 2StUYC0pcSlnqJlBdbSoTJnv84fYnfmJ21iYzmKquRBq+uXwQMWWmIDeuVWswkskwoSgfpyK06 Hqq7wjvK7ElQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,445,1583222400"; d="scan'208";a="256192753" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga007.jf.intel.com with ESMTP; 28 May 2020 08:21:37 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 28 May 2020 08:21:36 -0700 Received: from orsmsx110.amr.corp.intel.com ([169.254.10.119]) by ORSMSX155.amr.corp.intel.com ([169.254.7.235]) with mapi id 14.03.0439.000; Thu, 28 May 2020 08:21:36 -0700 From: "Kleen, Andi" To: "Tang, Feng" , Qian Cai CC: Andrew Morton , Michal Hocko , Johannes Weiner , Stephen Rothwell , Matthew Wilcox , Mel Gorman , Kees Cook , Luis Chamberlain , Iurii Zaikin , "Chen, Tim C" , "Hansen, Dave" , "Huang, Ying" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 0/3] make vm_committed_as_batch aware of vm overcommit policy Thread-Topic: [PATCH 0/3] make vm_committed_as_batch aware of vm overcommit policy Thread-Index: AQHWNQIlUjqwkSwmEkaddhwmrHfhIqi9nR5A Date: Thu, 28 May 2020 15:21:36 +0000 Message-ID: References: <1588922717-63697-1-git-send-email-feng.tang@intel.com> <20200521212726.GC6367@ovpn-112-192.phx2.redhat.com> <20200526181459.GD991@lca.pw> <20200527014647.GB93879@shbuild999.sh.intel.com> <20200527022539.GK991@lca.pw> <20200527104606.GE93879@shbuild999.sh.intel.com> <20200528141802.GB1810@lca.pw> <20200528151020.GF93879@shbuild999.sh.intel.com> In-Reply-To: <20200528151020.GF93879@shbuild999.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Rspamd-Queue-Id: 9444518267136 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >If it's true, then there could be 2 solutions, one is to skip the WARN_ONC= E as it has no practical value, as the real >check is the following code, t= he other is to rectify the percpu counter when the policy is changing to >O= VERCOMMIT_NEVER. I think it's better to fix it up when the policy changes. That's the right = place. The WARN_ON might be useful to catch other bugs. -Andi =20