From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E1EC433E0 for ; Tue, 2 Feb 2021 07:21:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6D85C64DAE for ; Tue, 2 Feb 2021 07:21:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D85C64DAE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vmware.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BC9796B0099; Tue, 2 Feb 2021 02:21:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B7B8F6B009A; Tue, 2 Feb 2021 02:21:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A428C6B009B; Tue, 2 Feb 2021 02:21:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id 8CD6D6B0099 for ; Tue, 2 Feb 2021 02:21:00 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 52083180AD81F for ; Tue, 2 Feb 2021 07:21:00 +0000 (UTC) X-FDA: 77772481080.01.side79_1311cc0275c9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 3614A10049EFB for ; Tue, 2 Feb 2021 07:21:00 +0000 (UTC) X-HE-Tag: side79_1311cc0275c9 X-Filterd-Recvd-Size: 8966 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2072.outbound.protection.outlook.com [40.107.93.72]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Feb 2021 07:20:59 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RhbQNYtbPGAngUKtpbTfaao1+MQ5coSSi86aHKWeXLzncX1qGhI3y+ZQcsUmjBJuoA9A4wt50sOcOBy5oMrrFeTnJOnhOoMFxDYo6deOnHbKGqBx4hjgpu4rDb+EOCF6jViPoLqW+SaU53T2pDlXy+6/55zxJMa6qFzcvR6x+dHCmGdn8yUAVfsptTdZY1eKH3G2EPmGFoU1YI/aoM0PPP759BoUNnFP6eLVo9Qla5XLJ6O9oY6xnyYpmLcponEXaZRrbFTXJpW6F8l/oKGwj7FRQL9PYgwemFXxIjzRWEb7V1wpNqPq4Otguxx6iTB9cWm272N+4q1gicOmaXPKog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ECO9x/qK3uc0zyJRSS+rrNDNKoX8+fHrNra1uqEALsc=; b=fgaeXPUYXV6huSln3uUfanguSPrD+czu38GUlAzOdwbEJfjbqIpJtHp4EV5/6mNd8TCDrQ5wxdWRr2Diq+4pK/H2y8vXjovoOn7p2V9uAYoiJOTMwgy2t29l/a0b/2Cmjw7iUfjV8q8Zf2XV/x4Np9rQAESF5iQ2rpHmRBnOgnCLpWpYR/m/MGjtg5YrxhC+WNf+cQ4+uUc1ZQElWCkX2NthjwDifO9KzsLhhWAitOCprFkker25h6PNZYpyQKS0MH6F704wS+8G5AMri+P0bFNT0nP2gARZsEcY3nC+wCC/SXmn0gQQ32fjUvP+lWZme0qhfnYLfhkMdC4UK9i4Ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ECO9x/qK3uc0zyJRSS+rrNDNKoX8+fHrNra1uqEALsc=; b=qPfK4zqxu4FQ7ndS5OZxty/Wklp0OcMMx/BQFGNfVSyAXXwoJQLfAXZ6lvCHQZAbLVqbtlkv7ew4KmcP7uTALWS50YL8n6Ho4TpFyRNDyaWPhQDe2Yj9GDMwp1obAmejC84uOcrDQrmui5Y76g6+j3JejNLzqI0nqZP1ui3KhY8= Received: from (2603:10b6:a03:4a::18) by BYAPR05MB5528.namprd05.prod.outlook.com (2603:10b6:a03:75::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.8; Tue, 2 Feb 2021 07:20:55 +0000 Received: from BYAPR05MB4776.namprd05.prod.outlook.com ([fe80::ddba:e1e9:fde7:3b31]) by BYAPR05MB4776.namprd05.prod.outlook.com ([fe80::ddba:e1e9:fde7:3b31%3]) with mapi id 15.20.3825.013; Tue, 2 Feb 2021 07:20:55 +0000 From: Nadav Amit To: Nicholas Piggin CC: Peter Zijlstra , Andrea Arcangeli , Andrew Morton , Dave Hansen , "linux-csky@vger.kernel.org" , LKML , Linux-MM , linuxppc-dev , linux-s390 , Andy Lutomirski , Thomas Gleixner , Will Deacon , X86 ML , Yu Zhao Subject: Re: [RFC 11/20] mm/tlb: remove arch-specific tlb_start/end_vma() Thread-Topic: [RFC 11/20] mm/tlb: remove arch-specific tlb_start/end_vma() Thread-Index: AQHW+JMuIjRLErxJlUWOv0AHOQSsJqpEa7AAgAALDAA= Date: Tue, 2 Feb 2021 07:20:55 +0000 Message-ID: References: <20210131001132.3368247-1-namit@vmware.com> <20210131001132.3368247-12-namit@vmware.com> <1612247956.0a1r1yjmm3.astroid@bobo.none> In-Reply-To: <1612247956.0a1r1yjmm3.astroid@bobo.none> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=vmware.com; x-originating-ip: [24.6.216.183] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a9f6a5cf-fe57-489e-23f7-08d8c74b1477 x-ms-traffictypediagnostic: BYAPR05MB5528: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BZfDT7DcahSHxx3VOBloQg3kv1zvejH2pt+Q8obe9B6QkrglRHNVXQL5IynE/svJbp/K3fKBEQ2O4K/6GDWfPtCUcV9rlGAz0ke9ALSCFHZ7oR7VjGj8vOAychmpiLv7oUme+zFmWuVdsHQmng0Zrw4q7ttVNqEuAJPiS2/75glgL7R6mJzi+JbKI+qtwVoQcLksJ4poNYQ/31tBlQ3Nhv4FdXj9/9ACFrjJX7QW34ULoUZFxDBQaj6suVnEQgvQ6wZokpSy/IeytnVViz0JzabuVBRCtTR6UWTIP40b7PdATMIYC7bvQQUJqFiEyCrFHV6s8ERpSE0ETqpzKKA9ew6nmLVa+GVfh6SYpAOUQAvZ8ZUO3y648BO3d+myiZDtfVp3NnEG2FkJSSpmdH1Zh5sTeL0sqaQ4i0Rm7TXOSW3KWO41p/LEmkxxNC5Tqlfi519JMRY8BsyjqvNKw/SvbRhzX8MhybCl1dveCPD5PMs93LQMSW58PVrhcp+sU8eoNpiivjop2zQwdWX3vbt9id+cjBLnzRPJ9KDfXZc39y5w5fySb9H/1Oc8LhJ2CN2wZgUXWTwW3ydlth75WerXrQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR05MB4776.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(366004)(376002)(346002)(39860400002)(66556008)(6512007)(64756008)(33656002)(86362001)(8936002)(316002)(66476007)(36756003)(7416002)(4326008)(5660300002)(66946007)(54906003)(83380400001)(8676002)(6486002)(66446008)(76116006)(71200400001)(6916009)(2616005)(26005)(53546011)(478600001)(4744005)(6506007)(2906002)(186003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?+/YPFtQOtQqzARpaTimB5K4lX/TY3dFSH3u/ggkSx30362QxfiJREoZx8h3e?= =?us-ascii?Q?Kl1cFRdTPblEiWQtmBuV+iGI6piq88xArl+Jl55PIuqDdnxIgqe++n7GNxz8?= =?us-ascii?Q?/f/3Mnng3U9MTeTh7TawXObgAI2uG8W8Pt/OfjnR3UVZqhScE/iSJSgAnu4T?= =?us-ascii?Q?8gS9JB4fgppjAX53gx1xhkqnw7qga38p2y5KNw7PZHGPUvM8+SCPBycJZ9O7?= =?us-ascii?Q?zkghqZNh7et/zrAU387CDQrE8+iiBm9Mu1B3QBFXf5nTb1CJ12CCbH7Y2GZz?= =?us-ascii?Q?Ep0WnIob33C4HSXW5f3c8roUKSfHrJHSbzCEkfJuDf45Hkd8EPpxtAVwQUG+?= =?us-ascii?Q?WJBSjOHdL0shBXLThNtbkvtALSBHp7NGICM0/i/oiiy+ae8PIzLTQRAGpSwQ?= =?us-ascii?Q?C0cyhezMlRaLCg6rp1f+7h5af4quRJit4VnW34v7Zx1p6psKvzaPkU3FFnZz?= =?us-ascii?Q?hIvYCs5q69F15zEqyGvTQpoR6iUtyUyqCPyP5qJRJRwOZvZAljsiNR75c8Py?= =?us-ascii?Q?mKkGNBFQ8XXIpcGQQW0B6saNFIA0jzlaRBLpZ+sYh6w5srOdNquiAgTv7oZB?= =?us-ascii?Q?8tub7OAodUHfFOCZF6qwMB6ozj4EL6cbCs/YUDwU+kgca6XDAQe/BM4lW61+?= =?us-ascii?Q?dO9nX5ymy0MNhgxy0VYnkcAQsXPHczh0WvSBdtXfgWXqER6xzmmI2ZDwmI9A?= =?us-ascii?Q?9qJaxAXBmRM+Rv9Dlp6aWAKH64A7odzfxPN3ERL5fHPTebjpiRYXhANbFIW7?= =?us-ascii?Q?H/V0HIy/M82BZKSAJMgO/GS/qODUgszaHzvPxSaNtsLa33DgPo5V8rb7xcUi?= =?us-ascii?Q?TpmsPgCJtdXWPUQuWj5WmU1RP+WJseybG7/UsJMVjIU6xKDHTNU6q/ekK7ux?= =?us-ascii?Q?bsYKlvB7PCsMX6ZpxT1CDD2Z/Vq0yyf0yAD0VAub9Hd+gTLjEm0SF8EHyVPz?= =?us-ascii?Q?703bKXq5MjVnA/bVDXKorMvVOtLGqSi2St5kdEAc7DsYb4zMPmWDXXLHtoPD?= =?us-ascii?Q?Hbv4jCn+9l79sRMMbPoBkM82i6qmdo97kqy3xfFa56il88OIzZvDM6Ebx/Pg?= =?us-ascii?Q?bXezC47B2YUvNdFQqUB1pZn9hw/G68rMwpmbNxS31ubnM/skQE6QhzU3gT0+?= =?us-ascii?Q?FIxQ/vZdYZbGIF5/HAzq3XFnpQaZ9yy9p2kTFIyd6OZTorVjkY2unXblOoA4?= =?us-ascii?Q?C3/RopJkIOF8KeYkIgczjDFRGgWM6QE0q2ZVtYR5XDt7weVIr2S8hA10/V28?= =?us-ascii?Q?HVFeTYOVw5M5EBoOyQEigVgao6SRDqMP2/k+DIljxvNUN2qo/a+P05APsysQ?= =?us-ascii?Q?8ORHEPx7KShY/MWN0+Ucv3SO?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <36FF6560AB7F494FB9A440197E9AD6F6@namprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB4776.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9f6a5cf-fe57-489e-23f7-08d8c74b1477 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2021 07:20:55.1482 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JGkUZaUFOl8GpBd74ArrXovY8ZpbELcQRD7kNIyObdCBv+JYoyCazDd5MJAOOYzpqd+hMc3RWW16CTgQLg8muQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB5528 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Feb 1, 2021, at 10:41 PM, Nicholas Piggin wrote: >=20 > Excerpts from Peter Zijlstra's message of February 1, 2021 10:09 pm: >> I also don't think AGRESSIVE_FLUSH_BATCHING quite captures what it does. >> How about: >>=20 >> CONFIG_MMU_GATHER_NO_PER_VMA_FLUSH >=20 > Yes please, have to have descriptive names. Point taken. I will fix it. >=20 > I didn't quite see why this was much of an improvement though. Maybe=20 > follow up patches take advantage of it? I didn't see how they all fit=20 > together. They do, but I realized as I said in other emails that I have a serious bug in the deferred invalidation scheme. Having said that, I think there is an advantage of having an explicit confi= g option instead of relying on whether tlb_end_vma is defined. For instance, Arm does not define tlb_end_vma, and consequently it flushes the TLB after each VMA. I suspect it is not intentional.