From: Chintan Pandya <chintan.pandya@oneplus.com>
To: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
Prathu Baronia <prathu.baronia@oneplus.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
Greg KH <gregkh@linuxfoundation.org>,
"gthelen@google.com" <gthelen@google.com>,
"jack@suse.cz" <jack@suse.cz>, Michal Hocko <mhocko@suse.com>,
Ken Lin <ken.lin@oneplus.com>, Gasine Xu <Gasine.Xu@Oneplus.com>
Subject: RE: [RFC] mm/memory.c: Optimizing THP zeroing routine for !HIGHMEM cases
Date: Tue, 14 Apr 2020 17:33:43 +0000 [thread overview]
Message-ID: <SG2PR04MB292101339505AD10F948954591DA0@SG2PR04MB2921.apcprd04.prod.outlook.com> (raw)
In-Reply-To: <20200414155525.6s5wlsdiktocs3c3@ca-dmjordan1.us.oracle.com>
> > > One interesting data point would be to see what the cost is for
> > > breaking this up into a loop where you only process some fixed
> > > number of pages and running it with cond_resched() so you can avoid
> introducing latency spikes.
> >
> > As per the patch above, it's not using kmap_atomic() and hence
> > preemption & page_fault are not disabled. Do we still need to explicitly call
> cond_resched() in this case?
> > #justAsking
>
> Didn't see this answered on the list, but the answer is yes because the kernel
> may not have CONFIG_PREEMPTION enabled.
Ok. This is addressable. Prathu has already spin off v2. If at all there is any scope
for spinning v3, this would be taken care. Thanks for the clarification.
prev parent reply other threads:[~2020-04-14 17:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 8:18 [RFC] mm/memory.c: Optimizing THP zeroing routine for !HIGHMEM cases Prathu Baronia
2020-04-03 8:52 ` Michal Hocko
2020-04-09 15:29 ` Prathu Baronia
2020-04-09 15:45 ` Michal Hocko
[not found] ` <SG2PR04MB2921D2AAA8726318EF53D83691DE0@SG2PR04MB2921.apcprd04.prod.outlook.com>
2020-04-10 9:05 ` Huang, Ying
2020-04-11 15:40 ` Chintan Pandya
2020-04-11 20:47 ` Alexander Duyck
2020-04-13 15:33 ` Prathu Baronia
2020-04-13 16:24 ` Alexander Duyck
2020-04-14 1:10 ` Huang, Ying
2020-04-10 18:54 ` Alexander Duyck
2020-04-11 8:45 ` Chintan Pandya
2020-04-14 15:55 ` Daniel Jordan
2020-04-14 17:33 ` Chintan Pandya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SG2PR04MB292101339505AD10F948954591DA0@SG2PR04MB2921.apcprd04.prod.outlook.com \
--to=chintan.pandya@oneplus.com \
--cc=Gasine.Xu@Oneplus.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=daniel.m.jordan@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=gthelen@google.com \
--cc=jack@suse.cz \
--cc=ken.lin@oneplus.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=prathu.baronia@oneplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).