From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00, CHARSET_FARAWAY_HEADER,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, FORGED_HOTMAIL_RCVD2,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12BA7C433F5 for ; Wed, 22 Sep 2021 14:34:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B282360FE6 for ; Wed, 22 Sep 2021 14:34:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B282360FE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=hotmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3A2CC6B006C; Wed, 22 Sep 2021 10:34:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3522D6B0072; Wed, 22 Sep 2021 10:34:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F3B5900002; Wed, 22 Sep 2021 10:34:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 114F76B006C for ; Wed, 22 Sep 2021 10:34:30 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C1AA72DD62 for ; Wed, 22 Sep 2021 14:34:29 +0000 (UTC) X-FDA: 78615455058.33.9C8F194 Received: from JPN01-TY1-obe.outbound.protection.outlook.com (mail-ty1jpn01olkn0151.outbound.protection.outlook.com [104.47.93.151]) by imf21.hostedemail.com (Postfix) with ESMTP id 5628ED2D4A41 for ; Wed, 22 Sep 2021 14:34:29 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UE24h2GbbYXUqyU3Dm48UsWu1vQy0tCH03lQZXBVspU1+ZJBtuZjFu57EKQQDtZvOFXkVW3k0Rkzd0t5ACfr3Grn1jiaOti4GySL0OuccpWDAHjunZ4oNFZPR7XM6561Y2XBQzCA5FjfrfGLAIuQhg8qqDlv6Xw1qmi2E2r9bgoNEVb4u/qDSGz4x/ckfMpCJK5Ytn2FWcGpuVsf/4zQTa1vlWlTllZSynaxola7XmniGwZnD3zJdy9xxcXJBPX+WgmIhF5rY6aE5qDQScvQvlccC2FTf7lOB+P7NlIL8vDk/cVHMDAlKgi1ktWhbQnuJWqsj8eqI4NNDw/AUmErKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9g76X2T2Uxq4/3I9sAmv7HPV8tCOrgiwhiHr+nDfZYQ=; b=c5MU8lI84wkM4WvWCfd7FGjwxmnYYbj6+aa0vpD1+Op/RtixoxKJCBgt1e61KZmgZKv4f52KANhAzAVdBFr6yCD+/EUdeXsc1KW3fTPnEnAmTnu3G+cBwjK3hn1IOngAeDZG4SNKTZU1b0Y3pbO56x5MChv9E7HBcEeKbqzihBAKwSdQwi4Y+SHupT79k73CiJhSG9d2zWou/HFqXW7PJzqlmf69WY6Rdfx7M6lF7SeU3xcXLxpkCcBhDH/KkcEC3w2vhqsgw8kgwuim9GEuWnX2DpwU9rjKfPRkdLouUVeGqsMSl7pS0UH/X6ixdjy13ikP6vo06futAfnRXtfRPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9g76X2T2Uxq4/3I9sAmv7HPV8tCOrgiwhiHr+nDfZYQ=; b=GgiERaLB91qeNB3cYRe2nrt+ky7kxsiLDvWX8QDs9hKzxxHFlFtRVQZFe236iXolbenS8LCe99HH1hvYjxUQ/RU4u2ppprzwomOTnzWW7xxEDtpoNPfiuD7snLw7o6l+oQVJbSFnd9meTAyLyiOThSS1uhCUIytBm8sk4NJ5ndj1mooMYazUV8aqp1gGd3IKWTFX8i1tn/tecK6F5vCJUFQtoN9kEB7ET2zXUcWKFxJD0/ABBaUsMZ9ck3X4cZCE7llPqiTEOyDVBURWX+Uw/YyJ8f+1wnzjVE6FMGk7yuuxMh9rHlMytobsEaPsNrYvgOctMcvLVAkek8nrh+9NxA== Received: from TYYP286MB1115.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:ce::9) by TYAP286MB0444.JPNP286.PROD.OUTLOOK.COM (2603:1096:404:803e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.18; Wed, 22 Sep 2021 14:34:26 +0000 Received: from TYYP286MB1115.JPNP286.PROD.OUTLOOK.COM ([fe80::ec61:211d:67d:95fe]) by TYYP286MB1115.JPNP286.PROD.OUTLOOK.COM ([fe80::ec61:211d:67d:95fe%8]) with mapi id 15.20.4544.015; Wed, 22 Sep 2021 14:34:26 +0000 From: =?gb2312?B?veIg073Dtw==?= To: Johannes Weiner CC: "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: =?gb2312?B?u9i4tDogW1BBVENIXSBtbTp2bXNjYW4gcmVtb3ZlIHVubmVjZXNzYXJ5IGxy?= =?gb2312?Q?u_lock_unlock/lock_pair?= Thread-Topic: [PATCH] mm:vmscan remove unnecessary lru lock unlock/lock pair Thread-Index: AQHXrWp2cPdPB17KIUyav1nFGHkWmKuuj5WAgAGR0SY= Date: Wed, 22 Sep 2021 14:34:26 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: 0c312184-5a72-d410-8a0c-1a2f063e72fb x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [pbwFViXznI45TrACmBBZPWWAkFiLW7oe] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 44751ce3-6cfb-48b2-d6e8-08d97dd61406 x-ms-traffictypediagnostic: TYAP286MB0444: x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VyFKl1/wYeHGhY2q/6QyEeAAc9Y7k9WX7K4sh7pZBq9w1Is0i+FmH9yoqonJNmG9e0XJcG/vQ/pXQVRrP2oXHN/SCrirZou3w0COfvicRmzQ/Bxf62P7Fw3nj6oKyLTnH1hUzXjjzmGFaiKut7obkg0WcqX8cyjw/bkf8ws0We5idVR/foTMe374qAkYwaKfNr/89yhFRUSDOojphRz0R5F5/nltOBhPG0P+EWE8gdsKSNwuetkBIeLL4//6tMIy8IqH6G3cY/j16COYJfZB49fEZbgVD1r0Y0vnzoG0mdljx/6Oa9zghxu3Bn2a1GEw5WLsoTVNN6K2/0ep9rYSv8sUlrtwkVm7kQgGAnk2s4dWtBJA6k/xsUNKjY5LXAuIjU2GpxvNLeYyaIKEX2gv+NvGjuBVnilItjl+9hWBaXbjDBPlKvEVl6lX511EANv2 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: FTh1dpQRZEF34yvULeZQFNW1UHMyyyZ5jbH+ZhmPQplZPEmAKB9wvtaZ7hjeN3uYr8TOc4/UM6ZtkhN8mmZL//HmgLtvLV8P9uuA0w4VgbHvxEzEefiCE147kwGquCROuR+s3PpkRdNwO+59IQqPPA== x-ms-exchange-transport-forked: True Content-Type: multipart/alternative; boundary="_000_TYYP286MB1115E88D3805F58E5DA77300C5A29TYYP286MB1115JPNP_" MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-18f16.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYYP286MB1115.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 44751ce3-6cfb-48b2-d6e8-08d97dd61406 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2021 14:34:26.1006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAP286MB0444 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=hotmail.com header.s=selector1 header.b=GgiERaLB; spf=pass (imf21.hostedemail.com: domain of yongmeixie@hotmail.com designates 104.47.93.151 as permitted sender) smtp.mailfrom=yongmeixie@hotmail.com; dmarc=pass (policy=none) header.from=hotmail.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5628ED2D4A41 X-Stat-Signature: j7ezjp181dx3xhajwjb3qeci7mmb8x39 X-HE-Tag: 1632321269-205092 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001678, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --_000_TYYP286MB1115E88D3805F58E5DA77300C5A29TYYP286MB1115JPNP_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 SSBnb3QgeW91ciBwb2ludC4NCllvdSdyZSByaWdodC4gVGhhbmtzLCBpdCdzIHZlcnkgaGVscGZ1 bCB0byBtZSB0byB1bmRlcnN0YW5kIHRoZSB0cmFkZW9mZi4NCg0KQmVzdCBSZWdhcmRzLA0KWW9u Z21laQ0KDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0Kt6K8/sjLOiBKb2hhbm5l cyBXZWluZXIgPGhhbm5lc0BjbXB4Y2hnLm9yZz4NCreiy83KsbzkOiAyMDIxxOo51MIyMcjVIDIy OjMwDQrK1bz+yMs6IFlvbmdtZWkgWGllIDx5b25nbWVpeGllQGhvdG1haWwuY29tPg0Ks63LzTog YWtwbUBsaW51eC1mb3VuZGF0aW9uLm9yZyA8YWtwbUBsaW51eC1mb3VuZGF0aW9uLm9yZz47IGxp bnV4LW1tQGt2YWNrLm9yZyA8bGludXgtbW1Aa3ZhY2sub3JnPjsgbGludXgta2VybmVsQHZnZXIu a2VybmVsLm9yZyA8bGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZz4NCtb3zOI6IFJlOiBbUEFU Q0hdIG1tOnZtc2NhbiByZW1vdmUgdW5uZWNlc3NhcnkgbHJ1IGxvY2sgdW5sb2NrL2xvY2sgcGFp cg0KDQpIZWxsbyBZb25nbWVpLA0KDQpPbiBTdW4sIFNlcCAxOSwgMjAyMSBhdCAxMToyNDozMFBN ICswODAwLCBZb25nbWVpIFhpZSB3cm90ZToNCj4gVGhlcmUncyBjb2RlIHJlZHVuZGFudCBpbiBt b3ZlX3BhZ2VzX3RvX2xydS4gV2hlbiB0aGVyZSdyZSBtdWx0aXBsZSBvZiBtbG9ja2VkIHBhZ2Vz DQo+IG9yIGNvbXBvdW5kIHBhZ2VzLCB0aGUgb3JpZ2luYWwgaW1wbGVtZW50YXRpb24gdHJpZXMg dG8gdW5sb2NrIGFuZCB0aGVuIGxvY2sgdG8gaGFuZGxlDQo+IHNvbWUgZXhjZXB0aW9uYWwgY2Fz ZS4NCj4NCj4gU2lnbmVkLW9mZi1ieTogWW9uZ21laSBYaWUgPHlvbmdtZWl4aWVAaG90bWFpbC5j b20+DQo+IC0tLQ0KPiAgbW0vdm1zY2FuLmMgfCAzMiArKysrKysrKysrKysrKysrKysrKysrKyst LS0tLS0tLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25z KC0pDQoNCklzIHRoZSBsb2NrIGN5Y2xpbmcgY3JlYXRpbmcgYWN0dWFsIHByb2JsZW1zIGZvciB5 b3U/DQoNClRoZSBsb2NrcyBhcmVuJ3QgYmF0Y2hlZCBiZWNhdXNlIHdlIGV4cGVjdCB0aG9zZSBz aXR1YXRpb25zIHRvIGJlDQpyYXJlOiBtbG9jayBvciB0cnVuY2F0ZS9tdW5tYXAgcmFjaW5nIHdp dGggcmVjbGFpbSBpc29sYXRpb24uIEFuZCBpbg0KZmFjdCwgeW91J3JlIGFkZGluZyBhbiB1bmNv bmRpdGlvbmFsIGxvY2sgY3ljbGUgYW5kIG1vcmUgYnJhbmNoZXMgdG8NCnRoZSBob3QgcGF0aCB0 byBkZWFsIHdpdGggaXQuIEl0J3MgbW9yZSBjb2RlIG92ZXJhbGwuDQoNCldpdGhvdXQgZGF0YSwg dGhlIHBhdGNoIGlzbid0IHZlcnkgY29tcGVsbGluZy4gSWYgeW91IGRvIGhhdmUgZGF0YSwgaXQN CndvdWxkIGJlIGdvb2QgdG8gaW5jbHVkZSBpdCBpbiB0aGUgY2hhbmdlbG9nLg0KDQpUaGFua3Mh DQo= --_000_TYYP286MB1115E88D3805F58E5DA77300C5A29TYYP286MB1115JPNP_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable
I got your point.
You're right. Thanks, it's very helpful to me to understand the tradeoff.

Best Regards,
Yongmei

=B7=A2=BC=FE=C8=CB: Johanne= s Weiner <hannes@cmpxchg.org>
=B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA9=D4=C221=C8=D5 22:30
=CA=D5=BC=FE=C8=CB: Yongmei Xie <yongmeixie@hotmail.com>
=B3=AD=CB=CD: akpm@linux-foundation.org <akpm@linux-foundation.or= g>; linux-mm@kvack.org <linux-mm@kvack.org>; linux-kernel@vger.ker= nel.org <linux-kernel@vger.kernel.org>
=D6=F7=CC=E2: Re: [PATCH] mm:vmscan remove unnecessary lru lock unlo= ck/lock pair
 
Hello Yongmei,

On Sun, Sep 19, 2021 at 11:24:30PM +0800, Yongmei Xie wrote:
> There's code redundant in move_pages_to_lru. When there're multiple of= mlocked pages
> or compound pages, the original implementation tries to unlock and the= n lock to handle
> some exceptional case.
>
> Signed-off-by: Yongmei Xie <yongmeixie@hotmail.com>
> ---
>  mm/vmscan.c | 32 ++++++++++++++++++++++++--------
>  1 file changed, 24 insertions(+), 8 deletions(-)

Is the lock cycling creating actual problems for you?

The locks aren't batched because we expect those situations to be
rare: mlock or truncate/munmap racing with reclaim isolation. And in
fact, you're adding an unconditional lock cycle and more branches to
the hot path to deal with it. It's more code overall.

Without data, the patch isn't very compelling. If you do have data, it
would be good to include it in the changelog.

Thanks!
--_000_TYYP286MB1115E88D3805F58E5DA77300C5A29TYYP286MB1115JPNP_--