From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B2B0C433DB for ; Thu, 14 Jan 2021 03:33:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D39842368A for ; Thu, 14 Jan 2021 03:33:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D39842368A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1BB548D00B7; Wed, 13 Jan 2021 22:33:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 16B458D008E; Wed, 13 Jan 2021 22:33:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05A6B8D00B7; Wed, 13 Jan 2021 22:33:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id E14C28D008E for ; Wed, 13 Jan 2021 22:33:29 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AFE7D180AD815 for ; Thu, 14 Jan 2021 03:33:29 +0000 (UTC) X-FDA: 77702960538.24.touch71_4901b7027523 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 9707E1A4A5 for ; Thu, 14 Jan 2021 03:33:29 +0000 (UTC) X-HE-Tag: touch71_4901b7027523 X-Filterd-Recvd-Size: 4427 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Jan 2021 03:33:29 +0000 (UTC) Received: by mail-pg1-f176.google.com with SMTP id n10so2831531pgl.10 for ; Wed, 13 Jan 2021 19:33:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=M5N5hogdb1VE5N+GuBnvP2hTDvEwQA42F7hxBNyZMt4=; b=FEqCHqMKatXUgxZo1m9x9XWMmJmnZLrMOpBLIkbng24V512Il3r0ZQNAi5YHI/s2R1 jau3yFgUJELL5UKibd7Q+RdwJfmPO6VUTfxHGI1Fvo3b+OXTuqIXNOKJ9EuXHdWcpsfP Z56E1Z56qn5TiRUlQPzBOzUmZlpSLF9suPKq54/u2GWIMt6H5b/3wla+uMVvIU6MUs2N RhYeiH4AADdHT+10avtmDmWydRpeILPcsagg4Dh7RPBLV5kR0KnjmzyBt1eyMABFzrq6 4Q0IpMrPCVk9hdMawRcOc1y7AaS3gQtK4BSbUAZzVimkJYuwmS2xjK5oW7wu4y5RUAkN QmqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=M5N5hogdb1VE5N+GuBnvP2hTDvEwQA42F7hxBNyZMt4=; b=OcCg/H9XDC9GvtZrFhvokK9ENyeln0Q97U9RxntbRD4+UjOUrJhLuPsLcUnJ5RJy/X utkxainQ0+H0U7mkhYVqiC8B6eyQk5sNIEvt4hIbqYLRJEW3aHkzOK+CLIw/xAVoYOtb B7BjSangLR3MH2SGSP0X5Ap/JljVP/rhezTr4GpPgwkvbejljoGyY8ou09wtEVD2TB7v bxse5aPb1nHqR0iys79J6ChNMGVR7cSxN7ajFc5IZ/TITyqGYspy3VAl/3fPYXFMPTDB ysl+radIKaE+baQYKYQN4seKo62a+G/uH1yRvL0+B07HsP0jEU3hupH0UbDZzXOBHAcP +xQw== X-Gm-Message-State: AOAM532LogI6i1+C1/CEbSAxVfSYjtso2lL3KkRsOqvkBTiSyHFJS0kv vQVhhb+FoQqC9nyQNXJXYcg= X-Google-Smtp-Source: ABdhPJwiK1AxhqNUts0GEcLWi4jomLrxuNv7CTGtOmpeAc78Pv+9YmYaaJopyRQaoE1OdGlIACQ6og== X-Received: by 2002:a63:f512:: with SMTP id w18mr5354005pgh.154.1610595208352; Wed, 13 Jan 2021 19:33:28 -0800 (PST) Received: from localhost ([100.87.84.221]) by smtp.gmail.com with ESMTPSA id o129sm3611513pfg.66.2021.01.13.19.33.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 19:33:27 -0800 (PST) Date: Thu, 14 Jan 2021 12:33:10 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Hugh Dickins , "Kirill A. Shutemov" , Suleiman Souhlal , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: madvise(MADV_REMOVE) deadlocks on shmem THP Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, We are running into lockups during the memory pressure tests on our boards, which essentially NMI panic them. In short the test case is - THP shmem echo advise > /sys/kernel/mm/transparent_hugepage/shmem_enabled - And a user-space process doing madvise(MADV_HUGEPAGE) on new mappings, and madvise(MADV_REMOVE) when it wants to remove the page range The problem boils down to the reverse locking chain: kswapd does lock_page(page) -> down_read(page->mapping->i_mmap_rwsem) madvise() process does down_write(page->mapping->i_mmap_rwsem) -> lock_page(page) CPU0 CPU1 kswapd vfs_fallocate() shrink_node() shmem_fallocate() shrink_active_list() unmap_mapping_range() page_referenced() << lock page:PG_locked >> unmap_mapping_pages() << down_write(mapping->i_mmap_rwsem) >> rmap_walk_file() zap_page_range_single() down_read(mapping->i_mmap_rwsem) << W-locked on CPU1>> unmap_page_range() rwsem_down_read_failed() __split_huge_pmd() __rwsem_down_read_failed_common() __lock_page() << PG_locked on CPU0 >> schedule() wait_on_page_bit_common() io_schedule() -ss