From: Greg KH <gregkh@linuxfoundation.org>
To: Muchun Song <songmuchun@bytedance.com>
Cc: rafael@kernel.org, adobriyan@gmail.com,
akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org,
vdavydov.dev@gmail.com, hughd@google.com, will@kernel.org,
guro@fb.com, rppt@kernel.org, tglx@linutronix.de,
esyr@redhat.com, peterx@redhat.com, krisman@collabora.com,
surenb@google.com, avagin@openvz.org, elver@google.com,
rdunlap@infradead.org, iamjoonsoo.kim@lge.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, cgroups@vger.kernel.org
Subject: Re: [PATCH 3/9] mm: memcontrol: convert kernel stack account to byte-sized
Date: Sat, 5 Dec 2020 15:10:07 +0100 [thread overview]
Message-ID: <X8uUv2TJ7CQ/mijD@kroah.com> (raw)
In-Reply-To: <20201205130224.81607-4-songmuchun@bytedance.com>
On Sat, Dec 05, 2020 at 09:02:18PM +0800, Muchun Song wrote:
> The kernel stack account is the only one that counts in KiB.
> This patch convert it from KiB to byte.
>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
> drivers/base/node.c | 2 +-
> fs/proc/meminfo.c | 2 +-
> include/linux/mmzone.h | 2 +-
> kernel/fork.c | 8 ++++----
> mm/memcontrol.c | 2 +-
> mm/page_alloc.c | 2 +-
> mm/vmstat.c | 4 ++--
> 7 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index 6ffa470e2984..855886a6ba0e 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -446,7 +446,7 @@ static ssize_t node_read_meminfo(struct device *dev,
> nid, K(node_page_state(pgdat, NR_FILE_MAPPED)),
> nid, K(node_page_state(pgdat, NR_ANON_MAPPED)),
> nid, K(i.sharedram),
> - nid, node_page_state(pgdat, NR_KERNEL_STACK_KB),
> + nid, node_page_state(pgdat, NR_KERNEL_STACK_B) / 1024,
Did you just change the units of a userspace-visable file without
updating the documentation?
If not, how is this working?
thanks,
greg k-h
next prev parent reply other threads:[~2020-12-05 14:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 13:02 [PATCH 0/9] Convert all THP vmstat counters to pages Muchun Song
2020-12-05 13:02 ` [PATCH 1/9] mm: vmstat: fix stat_threshold for NR_KERNEL_STACK_KB Muchun Song
2020-12-05 13:02 ` [PATCH 2/9] mm: memcontrol: fix NR_ANON_THPS account Muchun Song
2020-12-05 13:02 ` [PATCH 3/9] mm: memcontrol: convert kernel stack account to byte-sized Muchun Song
2020-12-05 14:10 ` Greg KH [this message]
2020-12-05 13:02 ` [PATCH 4/9] mm: memcontrol: convert NR_ANON_THPS account to pages Muchun Song
2020-12-05 13:02 ` [PATCH 5/9] mm: memcontrol: convert NR_FILE_THPS " Muchun Song
2020-12-05 14:10 ` Greg KH
2020-12-05 15:29 ` [External] " Muchun Song
2020-12-05 15:32 ` Greg KH
2020-12-05 15:39 ` Muchun Song
2020-12-05 16:33 ` Greg KH
2020-12-05 16:52 ` Muchun Song
2020-12-05 17:06 ` Greg KH
2020-12-05 13:02 ` [PATCH 6/9] mm: memcontrol: convert NR_SHMEM_THPS " Muchun Song
2020-12-05 13:02 ` [PATCH 7/9] mm: memcontrol: convert NR_SHMEM_PMDMAPPED " Muchun Song
2020-12-05 13:02 ` [PATCH 8/9] mm: memcontrol: convert NR_FILE_PMDMAPPED " Muchun Song
2020-12-05 13:02 ` [PATCH 9/9] mm: memcontrol: make the slab calculation consistent Muchun Song
2020-12-06 8:22 [PATCH v2 00/12] Convert all vmstat counters to pages or bytes Muchun Song
2020-12-06 8:23 ` [PATCH 3/9] mm: memcontrol: convert kernel stack account to byte-sized Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8uUv2TJ7CQ/mijD@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=cgroups@vger.kernel.org \
--cc=elver@google.com \
--cc=esyr@redhat.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=krisman@collabora.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=peterx@redhat.com \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=vdavydov.dev@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).