From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB59EC4361B for ; Sat, 19 Dec 2020 01:21:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6887323BA9 for ; Sat, 19 Dec 2020 01:21:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6887323BA9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A4E2F6B005C; Fri, 18 Dec 2020 20:21:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FFAC6B005D; Fri, 18 Dec 2020 20:21:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 914FE6B0068; Fri, 18 Dec 2020 20:21:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id 7B4106B005C for ; Fri, 18 Dec 2020 20:21:10 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 45AF58249980 for ; Sat, 19 Dec 2020 01:21:10 +0000 (UTC) X-FDA: 77608278300.02.fly99_010d16c27442 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 2D70010097AA0 for ; Sat, 19 Dec 2020 01:21:10 +0000 (UTC) X-HE-Tag: fly99_010d16c27442 X-Filterd-Recvd-Size: 3462 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Sat, 19 Dec 2020 01:21:09 +0000 (UTC) Received: by mail-wr1-f51.google.com with SMTP id y17so4634734wrr.10 for ; Fri, 18 Dec 2020 17:21:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QUtnZhHSTUhn7PA1a2z6Lv/RpUDz4hHMbvf4C1DMOfc=; b=YaVJY5BPLRUSLWuB/cxB1XSe7pxQ1AXuAlzSwdah3s4vyu8h4CO86lmqEr6swWRSe1 Vpm3YZqPQUcDuIS3a6fLgT4hsXqlZPzc6gVj07by6lEuzoqu+94s2uWuaPOPQgotDEmY NVaXL9dwI1gwCmLZekV8lPfWAU8GnRQhlFM6I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QUtnZhHSTUhn7PA1a2z6Lv/RpUDz4hHMbvf4C1DMOfc=; b=IwGwQIKQU8ab7MlpDBnMS2lqOL0JLN/DgnY3BEIBEqSyEe8TOewitGCVBHg5IyTckp DSy84kEoqbuz4SKSP2V7jZ/krpdvvhApGvZLgq577rnEli5ENdMxZqcfheTwJk6a8SYf 5qmk9CeI938KW9Pm0iPJtFhcQ03zwB3/sRxG/lQLfV1cjdjD3kCNtnYESKmnDoL8G+++ Y7QrgK1NY/kvwyvkx9dKRkSPnpuWWMrTR6xJQy2O+jfGFxP9kNxGr1NOl6vPoSOt+ifS aKOBJbwd13jk2fV5nXgjkHllDBRqZpYpe9keNaFVbcq7HVWMp5jAchq4wwIecXYzMD10 EnOw== X-Gm-Message-State: AOAM530kRwzkczogmacf8YYUAGfUtdZeFF/GIDkRIBZQwaSbS8AdiF8T f4Yx/Es9PsAUNroA4vbQNNmTyg== X-Google-Smtp-Source: ABdhPJynQVDYY3wR0uqszBcpsiw1KNTrdA8q7tIzm8L4dfhCfXyQ8SjCK8ODDXIQuDs6/mq9XojkfQ== X-Received: by 2002:a5d:55c6:: with SMTP id i6mr7005610wrw.137.1608340868526; Fri, 18 Dec 2020 17:21:08 -0800 (PST) Received: from localhost ([85.255.236.29]) by smtp.gmail.com with ESMTPSA id f7sm19268615wmc.1.2020.12.18.17.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Dec 2020 17:21:08 -0800 (PST) Date: Sat, 19 Dec 2020 01:21:07 +0000 From: Chris Down To: Jacob Wen Cc: Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] mm/vmscan: DRY cleanup for do_try_to_free_pages() Message-ID: References: <20201218102217.186836-1-jian.w.wen@oracle.com> <20201218105153.GX32193@dhcp22.suse.cz> <20201218142717.GA32193@dhcp22.suse.cz> <63e8a821-a3f6-47a6-f438-b27c32f4a05f@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <63e8a821-a3f6-47a6-f438-b27c32f4a05f@oracle.com> User-Agent: Mutt/2.0.3 (a51f058f) (2020-12-04) X-Bogosity: Ham, tests=bogofilter, spamicity=0.002423, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jacob Wen writes: >set_task_reclaim_state() is a function with 3 lines of code of which 2 >lines contain WARN_ON_ONCE. > >I am not comfortable with the current repetition. Ok, but could you please go into _why_ others should feel that way too? There are equally also reasons to err on the side of leaving code as-is -- since we know it already works, and this code generally has pretty high inertia -- and avoid mutation of code without concrete description of the benefits.