From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 416C2C4361B for ; Wed, 16 Dec 2020 00:54:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C816B22DA9 for ; Wed, 16 Dec 2020 00:54:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C816B22DA9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DED796B0036; Tue, 15 Dec 2020 19:54:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D773C6B005D; Tue, 15 Dec 2020 19:54:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3ED66B0068; Tue, 15 Dec 2020 19:54:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0161.hostedemail.com [216.40.44.161]) by kanga.kvack.org (Postfix) with ESMTP id A6D586B0036 for ; Tue, 15 Dec 2020 19:54:57 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6B16E180AD811 for ; Wed, 16 Dec 2020 00:54:57 +0000 (UTC) X-FDA: 77597325834.03.burst04_180a49627428 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 488E328A4E8 for ; Wed, 16 Dec 2020 00:54:57 +0000 (UTC) X-HE-Tag: burst04_180a49627428 X-Filterd-Recvd-Size: 3656 Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Dec 2020 00:54:56 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id y5so22355868iow.5 for ; Tue, 15 Dec 2020 16:54:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6ZtJqbgGcAblNJKpwbS3K6/u1SXDXbpWZAiwdGSMCSg=; b=Xy2Mg3RLj4cox03P2zL9aaeEiQo4rPz366y9A1Uw1sVBWPdsCfaE9XzzcbV2qqiWHl DgL3h7ocEauz5GltUn1Gxnz+EFdB2Bi6vdBhnE5bJqUwZOYA9wgAXM0zP9RoLXN9t3T1 udYKALRDu3PAkUK/6RMUtSUF4IyjKN7pCADFvKfofTHnONSFrDvzkyW62Lpd3g1cQDSB dqCAiMfsK134v0EnTGYCmirzbW1gb+vNGV7jU/Y+N8u0M0pYZXQIK7mttoWUTPGVGdsy s40vgWLX+byl2IVeXCYfTjjHmIHU3RTiCtWTb2cmn90SUt2E4LRwsTk4nMFEOgDZVfa+ xRlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6ZtJqbgGcAblNJKpwbS3K6/u1SXDXbpWZAiwdGSMCSg=; b=O7u48SldPJvTHmbUbqbeIHPYoujhHhEp4H21ovKwbUaX2IsslD51LlCmTAl/r6DhUw 05CqtupEOJ8is13ydPLUkK1IKHTz5XEf2lI+P9cErycEa5mFrgRwtqUYAematfNad3rm w/4RQT0dRYoy7QNgkHzCJ5Z5E421NEsOclmz2a7f2ybW+AETT/fQvNVpAgSxXTWPuD59 +8MgmDSzrMMa8KyM5/GIC0YOmRXbjgPwnkU5/U1oN2nAZ6LBRvpiqiOy+9fLRgeif99C an0ZSnKhNell5p5QEcLBNT6KWCZKikQ6TpIpGkgr6VsmZgDiUyiJuCcCQRKnkQaNRi2s o2ww== X-Gm-Message-State: AOAM531ZaTDMyKSkr68J+0aAr6q7lNyuW+0h5XeFxcrkbGaEjlCLIfjJ eBUew06qcQQmzZ5PqnivC4HvGA== X-Google-Smtp-Source: ABdhPJyP8I7tgzzXbJLVToXhgBExxn8NrvHnma47sZvIFSUx0ZUEqxZQBxv8iGUm9mCUG4Is4z4gvg== X-Received: by 2002:a02:3907:: with SMTP id l7mr42148584jaa.0.1608080096185; Tue, 15 Dec 2020 16:54:56 -0800 (PST) Received: from google.com ([2620:15c:183:200:7220:84ff:fe09:2d90]) by smtp.gmail.com with ESMTPSA id 12sm119037ily.42.2020.12.15.16.54.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Dec 2020 16:54:55 -0800 (PST) Date: Tue, 15 Dec 2020 17:54:51 -0700 From: Yu Zhao To: Matthew Wilcox Cc: Andrew Morton , Hugh Dickins , Alex Shi , Michal Hocko , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/11] mm: VM_BUG_ON lru page flags Message-ID: References: <20201207220949.830352-1-yuzhao@google.com> <20201207220949.830352-8-yuzhao@google.com> <20201207222429.GC7338@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201207222429.GC7338@casper.infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000049, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 07, 2020 at 10:24:29PM +0000, Matthew Wilcox wrote: > On Mon, Dec 07, 2020 at 03:09:45PM -0700, Yu Zhao wrote: > > Move scattered VM_BUG_ONs to two essential places that cover all > > lru list additions and deletions. > > I'd like to see these converted into VM_BUG_ON_PGFLAGS so you have > to take that extra CONFIG step to enable checking them. Right. I'll make sure it won't slip my mind again in v2.