From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 349EDC64ED6 for ; Wed, 1 Mar 2023 18:06:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7839B6B0072; Wed, 1 Mar 2023 13:06:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 70D3D6B0075; Wed, 1 Mar 2023 13:06:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AEAF6B007B; Wed, 1 Mar 2023 13:06:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 47E886B0072 for ; Wed, 1 Mar 2023 13:06:29 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 10C6F14074A for ; Wed, 1 Mar 2023 18:06:29 +0000 (UTC) X-FDA: 80521109298.02.12C4A8E Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf28.hostedemail.com (Postfix) with ESMTP id CCC73C0028 for ; Wed, 1 Mar 2023 18:06:22 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=fxGUe6x4; spf=temperror (imf28.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677693987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qr3M2ykwdizDOp0OOH8+sXnlOm6IAYEHuNArnLVf8t8=; b=q+eulgkLpZ3y9mKr8wQYj9nQcqRGS+idzZCuy0skXt9jt2dwsxho1nQaVooAxknKirIc9S ZT/U0Y9jJ0moAAwXNBNc3aN4BQBi4FKuSKMPm4aXYd1FNVBTlFXxrCzCIO3wFaqRvFZawB 9JcAHLcG3NUHa08XbAz6ilpb87fNRHc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=fxGUe6x4; spf=temperror (imf28.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677693987; a=rsa-sha256; cv=none; b=D5XhA6MjuVJCMz2phyhXHu+MYZ2o4TC8JsJzXjjZV68cxCmeCBUBsb00XaKN3CZW5qojtb BicaYxBuEMyy1410zJ8KRUTT6J4C0XhliGaQQYnp9+XdU6RBlAJaKRNsdXMw6wqSz4a2P+ QGQ3YA+yn+efQRxY8ZTVYENDHF7hmDQ= Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BB4671EC0646; Wed, 1 Mar 2023 19:06:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1677693974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Qr3M2ykwdizDOp0OOH8+sXnlOm6IAYEHuNArnLVf8t8=; b=fxGUe6x4K96TDUeg9BjZQkEKKWQLRDd4rbSk86ZfMPKSpeRy8SjFm8TCU3JNg/NV9M4wSF PDjfPWESbSddXdZo76RncViZ4Nko8sxZsBCWToo/FhuhjZB519Qfp2G1i3TTPJSx6MQmRg Sf4AMQb5/nDf5namJ/WyhvM6H+qkPsE= Date: Wed, 1 Mar 2023 19:06:09 +0100 From: Borislav Petkov To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, david@redhat.com, debug@rivosinc.com, Yu-cheng Yu , Michael Kerrisk Subject: Re: [PATCH v7 08/41] x86/shstk: Add user control-protection fault handler Message-ID: References: <20230227222957.24501-1-rick.p.edgecombe@intel.com> <20230227222957.24501-9-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230227222957.24501-9-rick.p.edgecombe@intel.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CCC73C0028 X-Stat-Signature: su6jxmeewnsajat8eu9d94r8zmuxospy X-HE-Tag: 1677693982-7142 X-HE-Meta: U2FsdGVkX19Mw43xYPVgwc2wIMqw1w12u6Uo1K7pFc/ozGnhdH5sTfSuHPR+CzOJhS7bpjSK159kf8dzAHkoBwj3Fe6F/oYizRN0fGoEKBeyDwyGKFCnj30sFrg5iBi2l2nSokXzlCaZiB3BWz7caXXS0RDaoyVfNx+VdXmbckZP8ef6vPwz0rxxId6Exle1O8EyC0IKGANmKyXNyurq/r/5Ly58z+wx+RYnn4jMpy4f6o4vOZFF0Jnp1Y0YBu0BWpDoTkpSA4Lff2fltZHLyVVF/G6qd2RVSsE2Y1IlW1GBT61JDgjz8GR138Qix0p7/XaXPa0E8pBeGjw6qFJnBOjSucgK3Y76rWsaNX08O/Nhl3vnXlTq22p1gd+KA/h5LzWYiIvQxX6OSZBvV4mh1A0CGi7ZFnSdkz8R85+qAEb8hq26Up0Dd6Lk6YtqcRmscbAuJUGK2VJyK5lDCQw/MIryJqkV6Ac+WDiXMkp052Igkp1GlK9TdImrhKW/SCLbL2mmsK/N0u1MMrzRSTKVoe078opeUhJB0B8j18cDgYUo5rTPvmn0Fbb3WSJufQzKgcIWMPQVnsGm+hyKCP4yTIQteglplW28G84rhQppQjs06k9jxlj12SWdFX6uINV5xx6PIhjffkidNcamf0Tz3nOpoBgyjR4834Jsz5ojqGlx3Qoh8pibS71cELl4nv1qndr8ItQaLDnjFTKXE3LTYwX2ALiDMMv0fffPU5SFA2lmKFt8H85FLoLukjfbdLVWEMWZUtbE4bvpIdCzN6Bb6/qUwkRucgSklLMhQ96OPr95M/oBhXq39oSM12l177tQYF0WquONsAdBcM9nfXIfuWyvImrLgw6/ZIMRnR3CzSGIekQYHEbCXInUDdLEpEsJ1YUnFfvFhzG9RzjelOvwiLk+8xPlRMVUxUn6F32QquDsJd9nmb/WPfQuOuHfkyivhuAmFeIjvALDfZ7x3FN GActgfSq GBIYrzN4Q43+jqSLzNugQINUEhRWUi7fg48Ov9H3aZZZGhvQOHjebSq8j5xoSNJLCH+J2vNwFpyWoZcFo3yQ/SN4QvkFFcQavSTqc0NLW8KeMorY2qyN8bhDMoEBX3XeAFi35Tl4cLXBUD1wgE4mNsMVu4/pYSAtDC+GQLHXcsf9FNWMnN2Ha3jisnPQ0N2rtq/LUnPEz9fTpiyUHkBkx9GYjHrP9sV9CjDD1qQZfCp4QHGyLn6ZYg/wFALr/FSfnza5M7DeH+uFd2w4bD2w12UCZH9hczoYllZKM/yKA2qG4Vb8Jc1NP9AakOqvIZE83+zNZJD7vRfH6jPzoTyV6tm2fJOPa4K+WO6a27UB4s3AnAyVX654+aVdg3VL7Fzqg4N2UJHzW8j2O6Yq16hi7NpkT5EyNM5phvJXVkPIDMVmyQd+5j8NVdOtBAUN5P/RRxc1vbliagH7Jvzd6NjuOgM8PkhjyRhQJ/TgffBnQKW+1kYk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 27, 2023 at 02:29:24PM -0800, Rick Edgecombe wrote: > diff --git a/arch/x86/kernel/cet.c b/arch/x86/kernel/cet.c > index 7ad22b705b64..cc10d8be9d74 100644 > --- a/arch/x86/kernel/cet.c > +++ b/arch/x86/kernel/cet.c > @@ -4,10 +4,6 @@ > #include > #include > > -static __ro_after_init bool ibt_fatal = true; > - > -extern void ibt_selftest_ip(void); /* code label defined in asm below */ > - > enum cp_error_code { > CP_EC = (1 << 15) - 1, >From a previous review: "That looks like a mask, so CP_EC_MASK I guess." -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette