From: Peter Zijlstra <peterz@infradead.org>
To: Alexander Potapenko <glider@google.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org
Subject: Re: [PATCH 5/5] x86/traps: avoid KMSAN bugs originating from handle_bug()
Date: Thu, 3 Nov 2022 12:18:14 +0100 [thread overview]
Message-ID: <Y2OjdsGCEfTQuqJP@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20221102110611.1085175-5-glider@google.com>
On Wed, Nov 02, 2022 at 12:06:11PM +0100, Alexander Potapenko wrote:
> diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
> index 178015a820f08..d3fdec706f1d2 100644
> --- a/arch/x86/kernel/traps.c
> +++ b/arch/x86/kernel/traps.c
> @@ -15,6 +15,7 @@
> #include <linux/context_tracking.h>
> #include <linux/interrupt.h>
> #include <linux/kallsyms.h>
> +#include <linux/kmsan.h>
> #include <linux/spinlock.h>
> #include <linux/kprobes.h>
> #include <linux/uaccess.h>
> @@ -301,6 +302,12 @@ static noinstr bool handle_bug(struct pt_regs *regs)
> {
> bool handled = false;
>
> + /*
> + * Normally @regs are unpoisoned by irqentry_enter(), but handle_bug()
> + * is a rare case that uses @regs without passing them to
> + * irqentry_enter().
> + */
> + kmsan_unpoison_entry_regs(regs);
> if (!is_valid_bugaddr(regs->ip))
> return handled;
>
Should we place this kmsan_unpoison_entry_regs() after the
instrumentation_begin() ?
next prev parent reply other threads:[~2022-11-03 11:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 11:06 [PATCH 1/5] kmsan: core: kmsan_in_runtime() should return true in NMI context Alexander Potapenko
2022-11-02 11:06 ` [PATCH 2/5] x86/uaccess: instrument copy_from_user_nmi() Alexander Potapenko
2022-11-02 12:52 ` Peter Zijlstra
2022-11-02 11:06 ` [PATCH 3/5] Kconfig.debug: ensure early check for KMSAN in CONFIG_KMSAN_WARN Alexander Potapenko
2022-11-02 11:06 ` [PATCH 4/5] kmsan: make sure PREEMPT_RT is off Alexander Potapenko
2022-11-02 12:53 ` Peter Zijlstra
2022-11-02 11:06 ` [PATCH 5/5] x86/traps: avoid KMSAN bugs originating from handle_bug() Alexander Potapenko
2022-11-02 12:50 ` Peter Zijlstra
2022-11-02 13:37 ` Alexander Potapenko
2022-11-03 11:18 ` Peter Zijlstra
2022-11-03 11:18 ` Peter Zijlstra [this message]
2022-11-03 13:37 ` Alexander Potapenko
2022-11-02 12:52 ` [PATCH 1/5] kmsan: core: kmsan_in_runtime() should return true in NMI context Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2OjdsGCEfTQuqJP@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).