From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2758C4332F for ; Mon, 7 Nov 2022 23:39:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E95AD6B0072; Mon, 7 Nov 2022 18:39:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E45F78E0001; Mon, 7 Nov 2022 18:39:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D33E06B0074; Mon, 7 Nov 2022 18:39:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C63B26B0072 for ; Mon, 7 Nov 2022 18:39:27 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4F88840843 for ; Mon, 7 Nov 2022 23:39:27 +0000 (UTC) X-FDA: 80108265174.01.19205EB Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 7893CC0002 for ; Mon, 7 Nov 2022 23:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZhGQGK629QHloWEgRMKC1tpDaWWHwkr9b2asHkWWxVw=; b=d+uCyRTCpDpGrCosQPHehTiGZE vd+mIota8rBrAnV0HfGfLjO1nCyDGBJq3KIbmhtjM1J7H7J6ssMxSzuLKGNtFg6N0Xf5a1FJ9mWK1 t2SEjqxJvaO7LJXZK2kdyyJOazsDDFw3c9DH7KVyRadcfyWFf5zs1CGWtVUlAAWLgWvIlOAHECCXt Xw9cc7PTt3hCJr7rS8jsx222bwFiOyzUn6EEVpjYQBdk26pMSNt5zaLUwgzbL0rZexjTrVrX9bv8P VYCXRmEIdbb6C+yEYbY80UVM1UmmESK8GKrcZf8VSxCWvQXL05V841oQ6qKmkQwAmyIcLXs8jxKP3 9IAbe4UQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1osBhz-001Dts-QQ; Mon, 07 Nov 2022 23:39:15 +0000 Date: Mon, 7 Nov 2022 15:39:15 -0800 From: Luis Chamberlain To: Song Liu Cc: bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, peterz@infradead.org, hch@lst.de, rick.p.edgecombe@intel.com, aaron.lu@intel.com, rppt@kernel.org, dave@stgolabs.net, torvalds@linux-foundation.org Subject: Re: [PATCH bpf-next v2 0/5] execmem_alloc for BPF programs Message-ID: References: <20221107223921.3451913-1-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=d+uCyRTC; spf=none (imf22.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667864366; a=rsa-sha256; cv=none; b=xLO1xOh/nWqlCymejXPz/Uxc/6HSVGdlKuZ3OzmJudArN7eMsMRTy71QdfqG+Iq9tz19U2 PFfXJ6XH282UGu/u+tQVqSRHJfo2h+HK9vR1MoUEqHY5vRDJNEqcP1KwBOvwU7uNfVdFc0 8tz4OMW7o7a9nzMzCoPay6i66NqoUrI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667864366; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZhGQGK629QHloWEgRMKC1tpDaWWHwkr9b2asHkWWxVw=; b=yvwIpO4mpnW0rKqsY8dhB08LSfvgXFf2siveex2u23tq3fYOtkFeCl+Yctp3R2MA3u6F4V VUFMxAaaH/dg89Act/q51oUwiG+3AQkFJvM1PZGLfliFkv9E8iqeLKmM4W2g4BqEIHOYax i9YA/qXyURvR0TOf0+Cx/Ce/LvfKnwc= X-Stat-Signature: 7ursikkomx1r8fqjop1jncorqezmwtou X-Rspamd-Queue-Id: 7893CC0002 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=d+uCyRTC; spf=none (imf22.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1667864362-675309 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 07, 2022 at 03:13:59PM -0800, Song Liu wrote: > The benchmark used here is identical on our web service, which runs on > many many servers, so it represents the workload that we care a lot. > Unfortunately, it is not possible to run it out of our data centers. I am not asking for that, I am asking for you to pick any similar benchark which can run in paralellel which may yield similar results. > We can build some artificial workloads and probably get much higher > performance improvements. But these workload may not represent real > world use cases. You can very likely use some existing benchmark. The direct map fragmentation stuff doesn't require much effort, as was demonstrated by Aaron, you can easily do that or more by running all selftests or just the test_bpf. This I buy. I'm not buying the iTLB gains as I can't even reproduce them myself for eBPF JIT, but I tested against iTLB when using eBPF JIT, perhaps you mean iTLB gains for other memory intensive applications running in tandem? And none of your patches mentions the gains of this effort helping with the long term advantage of centralizing the semantics for permissions on memory. Luis