From: Michal Hocko <mhocko@suse.com>
To: chengkaitao <pilgrimtao@gmail.com>
Cc: tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org,
corbet@lwn.net, roman.gushchin@linux.dev, shakeelb@google.com,
akpm@linux-foundation.org, songmuchun@bytedance.com,
chengkaitao@didiglobal.com, viro@zeniv.linux.org.uk,
zhengqi.arch@bytedance.com, ebiederm@xmission.com,
Liam.Howlett@oracle.com, chengzhihao1@huawei.com,
haolee.swjtu@gmail.com, yuzhao@google.com, willy@infradead.org,
vasily.averin@linux.dev, vbabka@suse.cz, surenb@google.com,
sfr@canb.auug.org.au, mcgrof@kernel.org, sujiaxun@uniontech.com,
feng.tang@intel.com, cgroups@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm: memcontrol: protect the memory in cgroup from being oom killed
Date: Thu, 8 Dec 2022 08:33:07 +0100 [thread overview]
Message-ID: <Y5GTM5HLhGrx9zFO@dhcp22.suse.cz> (raw)
In-Reply-To: <20221208034644.3077-1-chengkaitao@didiglobal.com>
On Thu 08-12-22 11:46:44, chengkaitao wrote:
> From: chengkaitao <pilgrimtao@gmail.com>
>
> We created a new interface <memory.oom.protect> for memory, If there is
> the OOM killer under parent memory cgroup, and the memory usage of a
> child cgroup is within its effective oom.protect boundary, the cgroup's
> tasks won't be OOM killed unless there is no unprotected tasks in other
> children cgroups. It draws on the logic of <memory.min/low> in the
> inheritance relationship.
>
> It has the following advantages,
> 1. We have the ability to protect more important processes, when there
> is a memcg's OOM killer. The oom.protect only takes effect local memcg,
> and does not affect the OOM killer of the host.
> 2. Historically, we can often use oom_score_adj to control a group of
> processes, It requires that all processes in the cgroup must have a
> common parent processes, we have to set the common parent process's
> oom_score_adj, before it forks all children processes. So that it is
> very difficult to apply it in other situations. Now oom.protect has no
> such restrictions, we can protect a cgroup of processes more easily. The
> cgroup can keep some memory, even if the OOM killer has to be called.
>
> Signed-off-by: chengkaitao <pilgrimtao@gmail.com>
> ---
> v2: Modify the formula of the process request memcg protection quota.
The new formula doesn't really address concerns expressed previously.
Please read my feedback carefully again and follow up with questions if
something is not clear.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2022-12-08 7:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 3:46 [PATCH v2] mm: memcontrol: protect the memory in cgroup from being oom killed chengkaitao
2022-12-08 7:33 ` Michal Hocko [this message]
2022-12-08 7:59 ` 程垲涛 Chengkaitao Cheng
2022-12-08 8:14 ` Michal Hocko
2022-12-08 14:07 ` 程垲涛 Chengkaitao Cheng
2022-12-08 14:23 ` Michal Hocko
2022-12-09 5:07 ` 程垲涛 Chengkaitao Cheng
2022-12-09 8:25 ` Michal Hocko
2022-12-09 12:27 ` Michal Hocko
2022-12-10 9:18 ` 程垲涛 Chengkaitao Cheng
2022-12-19 3:16 ` 程垲涛 Chengkaitao Cheng
2022-12-19 12:06 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5GTM5HLhGrx9zFO@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chengkaitao@didiglobal.com \
--cc=chengzhihao1@huawei.com \
--cc=corbet@lwn.net \
--cc=ebiederm@xmission.com \
--cc=feng.tang@intel.com \
--cc=hannes@cmpxchg.org \
--cc=haolee.swjtu@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=mcgrof@kernel.org \
--cc=pilgrimtao@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=sfr@canb.auug.org.au \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=sujiaxun@uniontech.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=vasily.averin@linux.dev \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).