From: Michal Hocko <mhocko@suse.com>
To: Wei Xu <weixugc@google.com>
Cc: Mina Almasry <almasrymina@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <songmuchun@bytedance.com>,
Huang Ying <ying.huang@intel.com>,
Yang Shi <yang.shi@linux.alibaba.com>,
Yosry Ahmed <yosryahmed@google.com>,
fvdl@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] [mm-unstable] mm: Fix memcg reclaim on memory tiered systems
Date: Fri, 9 Dec 2022 09:08:48 +0100 [thread overview]
Message-ID: <Y5LtEMYOXtUxsuqs@dhcp22.suse.cz> (raw)
In-Reply-To: <CAAPL-u_bEhCCCnepmCuNe7q7qJY3G3wckGvG-QsF2SYpAVXhEA@mail.gmail.com>
On Thu 08-12-22 16:59:36, Wei Xu wrote:
[...]
> > What I really mean is to add demotion nodes to the nodemask along with
> > the set of nodes you want to reclaim from. To me that sounds like a
> > more natural interface allowing for all sorts of usecases:
> > - free up demotion targets (only specify demotion nodes in the mask)
> > - control where to demote (e.g. select specific demotion target(s))
> > - do not demote at all (skip demotion nodes from the node mask)
>
> For clarification, do you mean to add another argument (e.g.
> demotion_nodes) in addition to the "nodes" argument?
No, nodes=mask argument should control the domain where the memory
reclaim should happen. That includes both aging and the reclaim. If the
mask doesn't contain any lower tier node then no demotion will happen.
If only a subset of lower tiers are specified then only those could be
used for the demotion process. Or put it otherwise, the nodemask is not
only used to filter out zonelists during reclaim it also restricts
migration targets.
Is this more clear now?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2022-12-09 8:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 2:34 [PATCH v3] [mm-unstable] mm: Fix memcg reclaim on memory tiered systems Mina Almasry
2022-12-06 3:13 ` Huang, Ying
2022-12-06 4:15 ` Mina Almasry
2022-12-06 5:22 ` Huang, Ying
2022-12-06 12:20 ` Michal Hocko
2022-12-06 16:06 ` Mina Almasry
2022-12-06 19:55 ` Michal Hocko
2022-12-07 1:22 ` Huang, Ying
2022-12-07 1:55 ` Mina Almasry
2022-12-07 11:12 ` Michal Hocko
2022-12-07 21:43 ` Mina Almasry
2022-12-08 8:09 ` Michal Hocko
2022-12-08 9:00 ` Mina Almasry
2022-12-08 11:54 ` Michal Hocko
2022-12-09 0:59 ` Wei Xu
2022-12-09 8:08 ` Michal Hocko [this message]
2022-12-09 16:41 ` Wei Xu
2022-12-09 21:16 ` Michal Hocko
2022-12-09 21:39 ` Mina Almasry
2022-12-12 8:33 ` Michal Hocko
2022-12-10 8:01 ` Wei Xu
2022-12-12 8:36 ` Michal Hocko
2022-12-06 15:15 ` kernel test robot
2022-12-06 18:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5LtEMYOXtUxsuqs@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=fvdl@google.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=weixugc@google.com \
--cc=yang.shi@linux.alibaba.com \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).