From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD316C3DA78 for ; Tue, 17 Jan 2023 08:54:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34C846B0071; Tue, 17 Jan 2023 03:54:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D52F6B0073; Tue, 17 Jan 2023 03:54:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14FB76B0074; Tue, 17 Jan 2023 03:54:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 00AB46B0071 for ; Tue, 17 Jan 2023 03:54:14 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 02EF8C06EF for ; Tue, 17 Jan 2023 08:54:13 +0000 (UTC) X-FDA: 80363679228.29.7FF48AE Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf08.hostedemail.com (Postfix) with ESMTP id E667F16000E for ; Tue, 17 Jan 2023 08:54:11 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=ncsUyaVT; spf=none (imf08.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673945652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=82O7MPpmKDKH/y6naoktZs3WQBLC/PHyEl3Wjqd7/dM=; b=XgwfzMY0QaSbX7JfktEc+ln4DXdLRk/nSnq/K7mv1Vz74K15Z3uoJOXwj+dpqH/RCVDHzI 9DLQoaGYfr1jdUiqmLX+J81C15TTSyiDwH0pLfc/hTFpcTDaAXX9/mGoZw+Xkq8mHBjI8s O3LE2/ELvmTKEsTMBl1+xGCNtHfLcFE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=ncsUyaVT; spf=none (imf08.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673945652; a=rsa-sha256; cv=none; b=wReCnqwYucYBWx3FxXBGGi0psCSwvR86c+Ls4v7eEJcdBsabRQegQ/6gmYvWtcerg7pKqn Weyqg0VQibxBKjVjsjJXDDeRQXH1dbxdd3DDcQSlW/fhMyoCpdvolJrATJSeiRrutLfw9H IRg5TfWYws2PAyljZpckeJhaa8RNuBo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=82O7MPpmKDKH/y6naoktZs3WQBLC/PHyEl3Wjqd7/dM=; b=ncsUyaVTQh9fhCexlcLhcCRL9S NS41uihsn8PZ17VRTMIIzlrwWNAiQRiZ+A4KgC02XPY3VKPipXvA16q7pUrG6TIkjLDcbi+W3slKi h85JYKde28tJS9HLnAiNQ+McUjM7BTsRbUDLFJN9zQZYCnlMQqI+CXescHjmHAOgmblkdCG63TjI5 hsx9HymmLMz+M4j+0M4z1OxRHRUY9AkKLozOO195MLFu+M+9o7/ZBcr0hniqbdURCPdODH0YEGjlO dFmo4sxsYm5aXL3MhIme6f3DivnrrXzkntnOlOoyjw7VtAnFKHFuSFkW50SdsVFAEpGeHYVZ8ifC/ LYIAtIQA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pHhj2-005saH-0S; Tue, 17 Jan 2023 08:53:48 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 7E36D3002BF; Tue, 17 Jan 2023 09:53:52 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 46751201ABB3C; Tue, 17 Jan 2023 09:53:52 +0100 (CET) Date: Tue, 17 Jan 2023 09:53:52 +0100 From: Peter Zijlstra To: Masami Hiramatsu Cc: richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, nsekhar@ti.com, brgl@bgdev.pl, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@hansenpartnership.com, deller@gmx.de, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, atishp@atishpatra.org, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, dennis@kernel.org, tj@kernel.org, cl@linux.com, rostedt@goodmis.org, frederic@kernel.org, paulmck@kernel.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, Andrew Morton , jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com Subject: Re: [PATCH v3 35/51] trace,hardirq: No moar _rcuidle() tracing Message-ID: References: <20230112194314.845371875@infradead.org> <20230112195541.477416709@infradead.org> <20230117132446.02ec12e4c10718de27790900@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230117132446.02ec12e4c10718de27790900@kernel.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E667F16000E X-Stat-Signature: oungkurisfcd3szw846hji94c6xht936 X-Rspam-User: X-HE-Tag: 1673945651-517279 X-HE-Meta: U2FsdGVkX1865GRBWHdcfnn/Tqla0E2TUJE/SqGG6rIpTt5Wompujs/bGOKeUeil/l/E/GxL2l0UTMexuvYtVSRH2mwUl1ag+0fKgmiD1YoR5j67igmINTMQShbS9rT510GxZGWRep948LCf9ONE4SeTjj3MDdbkGwSDjPNQDAqygmKq4BXg1iPdVP9gCAA9jIUIRVnPuj1qz/6SrydXGQ4UujAjNlpSFisItdZnLcKHyrxclx3vSKyISX04byQXTllBJwSFiAxqe6CtU6CdVFPBWW7vqcX63uGsZAxSxukdDTKT7gMw4I+WtcMHulmbwGWJHEGOFPDvUA9A8o7SK48wpfEIyT7zW9IV0Xa8m3TI6aha4tjPiVhALkBnUv2M8jGwLRG45X6/H0ql7dBzwzBnSNB5YV4NqCAuTPGNrflUE2VACFin+2PPw9rY5sLg5DzR2dGiU3pGBksi4e3hVzPjP5dhhhVX6mqfEvnTSa8iZawC3fc2niRMyVFKnm2nZmhYWzLZPWC+N0SovZDuPGMvcwQBhdeMomGStmLd7MsccLwtPu9aE2HTAx9HslgLhh+SUweTh5SsWRuz5Hjk41tFa1xAjb9z22/qTs0NpQjG1N8VcRd9b+mdcmJO4oswEIZSGpG6o+AOpZMXWLp5wetmJ62j55tm3zR+vO1w/kCN2jJN4Iw1OQpWqNKmYhb0zlvF7oPAw/Xzlc2dF3/BfF51CcOqyaeEJz+9TaoL2bKu4WOTOSE60NrCr3hP1KbOgFdDNp0We6jsdrLNOr2yaiwjXAAyo0q8V8uU4Y0LnPK/oJ+PaP/pYhP961QLABGD7HmJWlf0+ZtwZBm2m0Cghjv0COnCR/QFCK79PYEkhMHkGPHqt8+hJ5z6CflQxnikubs8Djw0/rYpdsRA30s49QrqZHzA2vDOsgm85hMUn62pu6s1X17dA/a9+Qgi0bj0UDq5dFEJRD+AcCiks2J 8C7lyY2t HsalG+5l/eonxvoF0AbP1wcboJmjymB86yS9mdjUKU1jumTF6ytn4/rrDa/WGrcYVu9pzwghLoFFXIFegZv+o8KuzDxVUEr+jBV2XAEdJJMXAdoCHIfznWmsLtCSFgn2g0pgmcUdNF0qJugbsmxOKHCiejkq5obbmkCsF3hgc5Z0BnvrAfEZva4pvptkzloC4LwAzQHxip8dB54XfAwA45utJb6lM3COKJ7fJTY1Gr5I/5jDLw35z0ukKK662DC7mcnEi5U8Fpig+3e8+QdA9pCy2dmrP26DmRjo/B8ApgWf4NzITgoxYX8FgWImSXyjt1/Qvl4ox7TyePo2PTUyAjkqFFknncy0sRBDm371wxI749rqPVbrnGSVXEUTfS9iBXnqgshSnaiayv4GFzvHK30QzRHMDnW4k+V7EJrzKCANaLATGVxeztWXMyeEOFmEeFJZ6ShnZ5QxkcoXXuLOpUPhTNcuFcBEJYeNznbZdXgdjupMMYxw+yqaTv+2zdnLNpdzm17eHq46IlLOiu/86Qd1ZT6D9TWb2FIdve3KCLT0F8OnQbsS69nMzlWkzl9CVYr/Ff3kY8lpQNLASJQZ/9lr1HHr6GvpoN6Udw7QH+zIMdPuTLPPtYfMEFBE4mpt+SoDjqjU3YqXpzaHNOhJtwd23CiOR7keHZoxXLWNlkxY4WlLINYdgGKwRGZPud0jvRnpW4ioLfiBUIMOflrIMBuxcRE3gBfi4+wBDCkFQYGM+ynRHEqORxyFU1+x1uxhTAU2Z5AUuWUZofJEb21Ei5uf0DykJErIvg1wuVo9p/tayoXeL/VLKxetR9o0Kqp68NHletkMXaCITupzCuKqikIHteO/bQOs3w8HsF3Zj3trZSSpW+bY/dDPJ3Afy32F9GL1Yr1tu0BZnBTsP/9ZpC6a7UUhXqrqKu3IgFK5hhV8XtgtvdDyGxLvgappz9pWrzVI5/ytu0qlEO/oysEL6/6Gul8Hz jk9CXuYJ 8edsYuZT2dzlrnIim7HVqfn4fcMj5JgA8Yu2AQiKYdG9hT4jPTfkTibVjpkEx2pUmGfsyO+JzT5mxplWeDv+5rOi5HrwlsRU1WeAWGUXRHllah1Nx41SL2u7hbMiwh+cLcgz0TGgWQJ93QU8HDju/u5Ln8BxSOAZg5Xpb383XK+u+GYxhNHnvMD18x84iXIWtwjsl27axrpqtY3pXeLGGW00kN21xoKilFQ2gAq2S+Dod/iddy8EsSLYkrL7bpfK4bT3mvzmi6qX4sBR+YRq22oyfFwPrTFM/Pf5utW2jSLivo7kIVqGVoFCLpT2cTjkDVl4ZVkkdI7d4+gVB+FA8D2h7VlwTTfTeUXYfAPJwJqur0ZEAHlG7MVwJnmLNfzv1Bg92H/5nHgMa3iLMoKjN1IhGj6mI9bv/B+sry/iJHWvnBYabbADnAqUSiGnww4LSKa1OOLsqiqoOn6XTCGbEaXFcTBB4re9SNMEdzz8QyHPJBW1DWbQuWEmepoQR4Os+CgvJQAmzRbRdZGoRXv2btiI4dwyenUofU4V0nNgYJXQGs9LZ7pCI7GiAoDJhDxXO7lLEUk7BLs3PaExx1Rus1iAWxjWhTGGEw8MIN8xAraa+3GrXV3fYwCDDzwi/yWe/W0nMbEWz7NZznetxmSyAqCGsbx+E2ubNFfQLkmZqIHICDd6n8NQILv0UXP6xhtqprXyoiaipTx/OmY00lj5gYMTDET3rVnTR0rnlfGKVbrwgLA6mPPefOLIQJV8sD+ULEj+5XY1yfUWMrqqwnCZdUgccAcdER3Fp198qlos5I7fca8ufPC75Un6b/++acjaNjq4EZcOR5VszGEiyMPqjYrDiR3dWKq1dA1eg22ynYs3rSGNmOPA9Dpbt2s3QqKxaEJtzdTEje9FslBKv++ExIfegqIGZuDQzNNKagd8pbZr0P+iT+2xLPl8l2kboM9SHIUNTY3fnQlJL5dyHuRTkpzliumyb juQ8r1nE kR+mnGARW+L94dmwf3x1WPG39zuBmLrPCUlZzTR3E0skQYJqOWJh0XtQxcLX9hHDw3WJZDk/1QcWM4b57BtTHcdq9jWqv99XlOoCWl88/QBxt2E8yJFqzTejpWYey7Q2hOrwh/tM0taOGKwLj/iJCFvHIdv3IZl0AIA0wIUR8bRjc3HBkcZoUJyTrBhd7451JkU43g3S/7kcEcaZHDC2T/2jepLw7ogQnP/45zFv1aZrk6rbHamaWWeiMoUH1k8/fe2Yd0c+RzglIIysvqXkH1zqO1hfz0trAO9UbqXsJtv+dY0KMP3o9o/83Ixy8Bsl2bPTHA7eMNjRk6aU9zTQKU8QPyyfMtE9ROviFE+Gud1Zel4PSYd2FPUWW/5FJYwJ5VDLyZjx4nEvWl8fMS9jirUelxOSMj0uVH3mQjDhGTtrRVtPUzX+2C2u6ewE74sTeJU9FzxtDA6iPZhTQOzRQR5eOBwWW6Er/O2QXfSfIl6XMXOcBBSgIMVBHu6lNdzPMXW9bTwC49BuZg98RuLfPEc8y3gQDhbZc44Fyb0bUoHr6q82gCHVhO3a8dKXjpfUXG4AAzf0Pzvl/XfEKfFMoeXsrGRNvpvDEhgVnjnsnIMiCBK0KwZhzMH6J9GKLwOG6DWQ6uvxUr59XOr+ffcdqfgf0T8FzrB6whPAObmHYCkXITS0Ho7xRIrNJxCoX50kbm6VpK6n3MWiQdSU4jd3dNJE+//uHwuQk1naljI42zF4Othqym3HEyXlnHxVTAFm3mx79E4ETNySMeQ76GbSJDANVEPxxnCEnT0X/NyK1IylQwGaiEWCT/K0oyryllMGn1w/PLhUn15xPvoZ4d2bcsWk+nIH7YBXMpEK9Q3Q2Pe9kAgAq0UIuiVYHbieuCqYSkmL/9tXOSCNMod7Dr/c1vkt7EN3vXukemB3NMORuV4te1X6mDeES+ACBWNcT7FdlTF0AmKVN9FgsABjng/jsA9F/Q8f1 ZHRv+8rV Kmwr74MjeYBIcFjgQwCBK2pxcOr1Rkkt6yR6lgAbtr9NviFo7ONGMVCzsdaSB7vz50MGd8xfs0Kc/AhrmiUvKQaxFt7+VmozMITejOTuj80EbqiSBVnrni X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 17, 2023 at 01:24:46PM +0900, Masami Hiramatsu wrote: > Hi Peter, > > On Thu, 12 Jan 2023 20:43:49 +0100 > Peter Zijlstra wrote: > > > Robot reported that trace_hardirqs_{on,off}() tickle the forbidden > > _rcuidle() tracepoint through local_irq_{en,dis}able(). > > > > For 'sane' configs, these calls will only happen with RCU enabled and > > as such can use the regular tracepoint. This also means it's possible > > to trace them from NMI context again. > > > > Signed-off-by: Peter Zijlstra (Intel) > > The code looks good to me. I just have a question about comment. > > > --- > > kernel/trace/trace_preemptirq.c | 21 +++++++++++++-------- > > 1 file changed, 13 insertions(+), 8 deletions(-) > > > > --- a/kernel/trace/trace_preemptirq.c > > +++ b/kernel/trace/trace_preemptirq.c > > @@ -20,6 +20,15 @@ > > static DEFINE_PER_CPU(int, tracing_irq_cpu); > > > > /* > > + * ... > > Is this intended? Wouldn't you leave any comment here? I indeed forgot to write the comment before posting, my bad :/ Ingo fixed it up when he applied.