From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAFCEC433E0 for ; Fri, 5 Feb 2021 16:16:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4D59F64FC4 for ; Fri, 5 Feb 2021 16:16:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D59F64FC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AF97E6B0006; Fri, 5 Feb 2021 11:16:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A81C36B0070; Fri, 5 Feb 2021 11:16:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94A846B0072; Fri, 5 Feb 2021 11:16:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id 7E0106B0006 for ; Fri, 5 Feb 2021 11:16:49 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 436D48249980 for ; Fri, 5 Feb 2021 16:16:49 +0000 (UTC) X-FDA: 77784717738.17.alarm62_1d17b6d275e6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 29870180D0180 for ; Fri, 5 Feb 2021 16:16:49 +0000 (UTC) X-HE-Tag: alarm62_1d17b6d275e6 X-Filterd-Recvd-Size: 3975 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Fri, 5 Feb 2021 16:16:48 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id d2so4060101pjs.4 for ; Fri, 05 Feb 2021 08:16:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3BGzFlUAQdb1rouZCpkNsxXA0DwY6aSbrdFUF09uTgk=; b=UEUHugPHt7HM5ez2N8d9x9dAAFqBvDucpyjjQbVkjb7bR4rK6VDphQ2J9y+pbC9vdH sUQnI63HiuYHVsEbOG/Q0rFsogRHrWArLz4pJr3DbjVOuHOvCRCa7Dm4+3HSwLNvEaKi offUyYMV9mxbkG341DTJi6e2dfpVf6wzht4TulMGyblGBFquBlU20QdH2rnClBVW7Vge 6Z9hc5Ms2RAKFLWudPodlYviI+cTgxeqiroEbPMgF+G1SMc/xE/D0+wNIyOXcDXcQ7aG F0Kvyg56omgdbM5ijD1Gugq56gm0hlM7P7nIelV0JFId47hkfGe+fAjD0tlA73epV1dC V2pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=3BGzFlUAQdb1rouZCpkNsxXA0DwY6aSbrdFUF09uTgk=; b=jkdwg35IU+Jme9HpNVx2UKj5c2xuS2mxGIYIM2TavO6GxpgTMaxMdXAvC7K0PSJVIf PXYDozbY3E0JKEnHJ6IfB5uBxKTM7ucJ2eGbu008iNY+eMhOkfo+yEWcD0G/3bELhwQr q+thl2cCavbMcxZbNr5Ol8f1k9zCswaL5L2Zxv95SUNZtDj3Ir+ASmIVzGhNRXi1WIrH 8N8snjuDZZrqQukHwQKYVe8DvUDPQgRMJEtoFppDgWcJSgzp7GVw6yN/qOCYImuGsH2W qBcjCQcjNomsF44ZAQBjBqWlmT94xCgrc+xEVVC9gfWYtYDf/x60APTuTsFtqMhLBCsa oiEA== X-Gm-Message-State: AOAM530Q/U1P+dHKTEiHpfiwZyVMi+FSfjonLklHx0srVGkajfS3aR71 ETKQjX/UC3DoRAgGeJzSRcI= X-Google-Smtp-Source: ABdhPJyDkSNH4sKUDDak8FNJ06tWlmYRWP6ZBa73o7N8S/t0LdosidciNj0HF3pD738fnTtIYeNgDg== X-Received: by 2002:a17:902:bd97:b029:de:abc4:fec7 with SMTP id q23-20020a170902bd97b02900deabc4fec7mr4619076pls.7.1612541807800; Fri, 05 Feb 2021 08:16:47 -0800 (PST) Received: from google.com ([2620:15c:211:201:708b:34cf:3e70:176d]) by smtp.gmail.com with ESMTPSA id q15sm703709pja.22.2021.02.05.08.16.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 08:16:46 -0800 (PST) Date: Fri, 5 Feb 2021 08:16:44 -0800 From: Minchan Kim To: Matthew Wilcox Cc: Andrew Morton , gregkh@linuxfoundation.org, surenb@google.com, joaodias@google.com, LKML , linux-mm Subject: Re: [PATCH] mm: cma: support sysfs Message-ID: References: <20210203155001.4121868-1-minchan@kernel.org> <20210205025526.GG308988@casper.infradead.org> <20210205121217.GH308988@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210205121217.GH308988@casper.infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 05, 2021 at 12:12:17PM +0000, Matthew Wilcox wrote: > On Thu, Feb 04, 2021 at 09:22:18PM -0800, Minchan Kim wrote: > > > > + for (i = 0; i < cma_area_count; i++) { > > > > + cma = &cma_areas[i]; > > > > + stat = kzalloc(sizeof(*stat), GFP_KERNEL); > > > > + if (!stat) > > > > + goto out; > > > > > > How many cma areas are there going to be? do we really want to allocate > > > their stat individually? > > > > I am not sure what could be in the end but at least, I have > > 5+ candidates (but could be shrink or extend) and yes, > > want to keep track them individually. > > I meant, wouldn't it be better to: > > cma_stats = kzalloc(array_size(sizeof(*stat), cma_area_count), > GFP_KERNEL); > Definitely. Thanks, Matthew.