From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE78C433DB for ; Fri, 5 Feb 2021 16:34:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 70E2E64EAC for ; Fri, 5 Feb 2021 16:34:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70E2E64EAC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CEE066B0071; Fri, 5 Feb 2021 11:34:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA0C66B0074; Fri, 5 Feb 2021 11:34:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB4026B0075; Fri, 5 Feb 2021 11:34:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id A63756B0071 for ; Fri, 5 Feb 2021 11:34:23 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7369E2491 for ; Fri, 5 Feb 2021 16:34:23 +0000 (UTC) X-FDA: 77784762006.02.0DCA815 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf05.hostedemail.com (Postfix) with ESMTP id 955DBE0001AB for ; Fri, 5 Feb 2021 16:34:21 +0000 (UTC) Received: by mail-qt1-f171.google.com with SMTP id v3so5399757qtw.4 for ; Fri, 05 Feb 2021 08:34:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RW0ONyxKXYjlsRuX7eO/UdLt7OqwnBfWk+dSDdSDYyw=; b=fDCx8PML3wpb7Gv9Qhxf/Lmgt8t9paY9PlqQPeev9GAzZIOy9HRlwnhk8Gj2bTe2yf 0uSHjMJJYfZDMDMboGVMVL98lxLZYKECaPT1YM59+/uoVp+j2yeayauMqi3OZM4d1tEn YN/ecY3LDoZFlB6rqTT5ynUD98p8d4ARLnea2R77u3ZWZqfLt+1HcCkt9MhNrCijWhUz f4DiXHO0gL1TK9dgWhCoDy3l5Q2bJk2OkxHSBoWy+wJ4rScOFcDJlLvSG/M9tYuP2TdN mWVZjPe8sqxDRGKXq+ydF2Mdvz57XMe1jNoelLFF+OdOSt6KcspYQ/F2PQw35OvoRNYe +pCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RW0ONyxKXYjlsRuX7eO/UdLt7OqwnBfWk+dSDdSDYyw=; b=SPmEFBEBmg/YtZ1UJUyRQ+7Va19kl7ettSq0JhIlLPDWR8pF7Q03yTZfFwkpcclCHu lDjUj1f5zoMwPUvsS9Ao02lDhX5yYDq8U6bMKgBuPSHYBnmpghKqEIHNdOu5THYGsPlR NX2+1OSkqpsJah/5Z3i7G2oS+QqfQM0dxN+QOrSjDllkaHV6RTRmF+p+s9hf0jKySoMT U5wzG2k3MPo6ENyXVdaa7gyvylWbDknBp+AoMrjGOzjLfqnTNWE545bPd/vY0mRXSGdA hASfNweMJJCKJNy1q+W64mqX04eGViOOcqHMk85caHqWLB2x6ONakSfklhL1jr8Fn0Jy 6zfA== X-Gm-Message-State: AOAM533Xo7K4k1zQVcqLm/14Tio0cs97s6Si3zVk4855/J49RumqFn/E KJ9uJt4ScIF5FhV7Fk2O8Zu76A== X-Google-Smtp-Source: ABdhPJwnNJM/q0Eo2MlbfQjZiTMmgkK3+RzNgscQCLRFoS1nQRPHzBz9vh5zkKqKWZB2ML9LPR2nMQ== X-Received: by 2002:aed:20a8:: with SMTP id 37mr5172292qtb.362.1612542861989; Fri, 05 Feb 2021 08:34:21 -0800 (PST) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id z5sm9626394qkc.61.2021.02.05.08.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 08:34:20 -0800 (PST) Date: Fri, 5 Feb 2021 11:34:19 -0500 From: Johannes Weiner To: Michal Hocko Cc: Andrew Morton , Tejun Heo , Roman Gushchin , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 6/7] mm: memcontrol: switch to rstat Message-ID: References: <20210202184746.119084-1-hannes@cmpxchg.org> <20210202184746.119084-7-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: f8a8ozcqoa4sssznk6h3sphh94gmmz9y X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 955DBE0001AB Received-SPF: none (cmpxchg.org>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=mail-qt1-f171.google.com; client-ip=209.85.160.171 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1612542861-501607 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 05, 2021 at 04:05:20PM +0100, Michal Hocko wrote: > On Tue 02-02-21 13:47:45, Johannes Weiner wrote: > > Replace the memory controller's custom hierarchical stats code with > > the generic rstat infrastructure provided by the cgroup core. > > > > The current implementation does batched upward propagation from the > > write side (i.e. as stats change). The per-cpu batches introduce an > > error, which is multiplied by the number of subgroups in a tree. In > > systems with many CPUs and sizable cgroup trees, the error can be > > large enough to confuse users (e.g. 32 batch pages * 32 CPUs * 32 > > subgroups results in an error of up to 128M per stat item). This can > > entirely swallow allocation bursts inside a workload that the user is > > expecting to see reflected in the statistics. > > > > In the past, we've done read-side aggregation, where a memory.stat > > read would have to walk the entire subtree and add up per-cpu > > counts. This became problematic with lazily-freed cgroups: we could > > have large subtrees where most cgroups were entirely idle. Hence the > > switch to change-driven upward propagation. Unfortunately, it needed > > to trade accuracy for speed due to the write side being so hot. > > > > Rstat combines the best of both worlds: from the write side, it > > cheaply maintains a queue of cgroups that have pending changes, so > > that the read side can do selective tree aggregation. This way the > > reported stats will always be precise and recent as can be, while the > > aggregation can skip over potentially large numbers of idle cgroups. > > > > This adds a second vmstats to struct mem_cgroup (MEMCG_NR_STAT + > > NR_VM_EVENT_ITEMS) to track pending subtree deltas during upward > > aggregation. It removes 3 words from the per-cpu data. It eliminates > > memcg_exact_page_state(), since memcg_page_state() is now exact. > > The above confused me a bit. I can see the pcp data size increased by > adding _prev. The resulting memory footprint should be increased by > sizeof(long) * (MEMCG_NR_STAT + NR_VM_EVENT_ITEMS) * (CPUS + 1) > which is roughly 1kB per CPU per memcg unless I have made any > mistake. This is a quite a lot and it should be mentioned in the > changelog. Not quite, you missed a hunk further below in the patch. Yes, the _prev arrays are added to the percpu struct. HOWEVER, we used to have TWO percpu structs in a memcg: one for local data, one for hierarchical data. In the rstat format, one is enough to capture both: - /* Legacy local VM stats and events */ - struct memcg_vmstats_percpu __percpu *vmstats_local; - - /* Subtree VM stats and events (batched updates) */ struct memcg_vmstats_percpu __percpu *vmstats_percpu; This eliminates dead duplicates of the nr_page_events and targets[MEM_CGROUP_NTARGETS(2)] we used to carry, which means we have a net reduction of 3 longs in the percpu data with this series. > > Signed-off-by: Johannes Weiner > > Although the memory overhead is quite large and it scales both with > memcg count and CPUs so it can grow quite a bit I do not think this is > prohibitive. Although it would be really nice if this could be optimized > in the future. > > All that being said, the code looks more manageable now. > Acked-by: Michal Hocko Thanks