From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F60DC433E0 for ; Fri, 5 Feb 2021 17:50:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D9B2C64DEC for ; Fri, 5 Feb 2021 17:50:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9B2C64DEC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 438596B0074; Fri, 5 Feb 2021 12:50:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E9806B0075; Fri, 5 Feb 2021 12:50:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 288756B0078; Fri, 5 Feb 2021 12:50:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id 0FC066B0074 for ; Fri, 5 Feb 2021 12:50:17 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D16BA181AC544 for ; Fri, 5 Feb 2021 17:50:16 +0000 (UTC) X-FDA: 77784953232.28.title44_2a0a007275e6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 9A4766C16 for ; Fri, 5 Feb 2021 17:50:16 +0000 (UTC) X-HE-Tag: title44_2a0a007275e6 X-Filterd-Recvd-Size: 4414 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Fri, 5 Feb 2021 17:50:15 +0000 (UTC) Received: by mail-qv1-f53.google.com with SMTP id r13so3825392qvm.11 for ; Fri, 05 Feb 2021 09:50:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YE/YQGTHwZ7gbs66msaBXwH+40vFYJVzTcKrkbmzw0I=; b=IVvwgK3FTWbjgP5nm2j9BXlUlBzZ1hTRtXk/4fib3jzaTm1sVv7WdBvZvfPD2jKDUa khdknLUh6qENaXt8+w9ONS1Gu3Mm3HlFqtPsNS11qBVaQI/GtdJnxSCYwe3+1nHILCej 0BRSBSa3l5/AgXY1OxiHgJsINK+yfsx4V6yMLTh8CQndgAhldR0OKcFwtH1X2Z2MkHh3 6y9mkW3fa6UldKMrsp0IbaRUP+9vFdq/WRDG1KDLDncCT+2z6GzAZmCVzFxBdhcW5aRp Llr5FFaJEbG/2Z/I2K0Dxv6rB5qT3Fx8r6CY+SuqmO0W8Ta9j3DakS+/MsLgCRSzuBvZ Kp1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YE/YQGTHwZ7gbs66msaBXwH+40vFYJVzTcKrkbmzw0I=; b=Etgcuk7cUlAqZ38uivCSx5KRqAChnzivOkJvOmdup5FOxS5k0kKM/31ZYRl8MDjgdB 3sA042pI028AU+vHLocX6Mx6l/yMkLIJe2nCm6ANj6kD8GqLOW8l9OjN5M+kajEy26Wq m3o/DxW6EywN5QBoa91c2nsZxESY+akWszAXTjHQKbjaektgHJq1OPYzYfMLgm9L1gl4 kUmAl6sPyaUqEB7SYsUidFXz9hHb2ohiU5YDzhnxH71P//eHSEFh1mvFQlCPGzXK4xIf PVTokn2a/7dhR1rPEYkOfR9MItKYm+7CGw1YSRbya19YN3dWC2B0uRNHbPgwQyEBNZV+ En0Q== X-Gm-Message-State: AOAM531ix8h6B8jfecGdB2afvf3bk6nCmEuPRjbuQHbingYs83EuOfhW g2pOz1fJOUw/nU1Ahcc34DBuLw== X-Google-Smtp-Source: ABdhPJwpLT2XDEM2BHa1u0r4wr8mb4qNEO20aAMdaZgJk+O5jPLsJ6mVjFrgKTOBGo1myjVSET2obg== X-Received: by 2002:a0c:b912:: with SMTP id u18mr5365334qvf.2.1612547415282; Fri, 05 Feb 2021 09:50:15 -0800 (PST) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id 2sm9864869qkf.97.2021.02.05.09.50.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 09:50:14 -0800 (PST) Date: Fri, 5 Feb 2021 12:50:13 -0500 From: Johannes Weiner To: Roman Gushchin Cc: Andrew Morton , Tejun Heo , Michal Hocko , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 1/7] mm: memcontrol: fix cpuhotplug statistics flushing Message-ID: References: <20210202184746.119084-1-hannes@cmpxchg.org> <20210202184746.119084-2-hannes@cmpxchg.org> <20210202230747.GA1812008@carbon.dhcp.thefacebook.com> <20210203022853.GG1812008@carbon.dhcp.thefacebook.com> <20210204193446.GA2053875@carbon.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210204193446.GA2053875@carbon.dhcp.thefacebook.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 04, 2021 at 11:34:46AM -0800, Roman Gushchin wrote: > On Thu, Feb 04, 2021 at 02:29:57PM -0500, Johannes Weiner wrote: > > It even passes with a reduced margin in the patched kernel, since the > > percpu drift - which this test already tried to account for - is now > > only on the page_counter side (whereas memory.stat is always precise). > > > > I'm going to include that data in the v2 changelog, as well as a patch > > to update test_kmem.c to the more stringent error tolerances. > > Hm, I'm not sure it's a good idea to unconditionally lower the error tolerance: > it's convenient to be able to run the same test on older kernels. Well, an older version of the kernel will have an older version of the test that is tailored towards that kernel's specific behavior. That's sort of the point of tracking code and tests in the same git tree: to have meaningful, effective and precise tests of an ever-changing implementation. Trying to be backward compatible will lower the test signal and miss regressions, when a backward compatible version is at most one git checkout away.