From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87C01C433E0 for ; Mon, 1 Feb 2021 13:19:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 00F4F64E95 for ; Mon, 1 Feb 2021 13:19:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00F4F64E95 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 48DEB6B006E; Mon, 1 Feb 2021 08:19:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 43DEB6B0072; Mon, 1 Feb 2021 08:19:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37A466B0075; Mon, 1 Feb 2021 08:19:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id 2238E6B006E for ; Mon, 1 Feb 2021 08:19:32 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E0240180AD80F for ; Mon, 1 Feb 2021 13:19:31 +0000 (UTC) X-FDA: 77769755742.02.kiss67_0d0e8a6275c2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id C7EA010097AA1 for ; Mon, 1 Feb 2021 13:19:31 +0000 (UTC) X-HE-Tag: kiss67_0d0e8a6275c2 X-Filterd-Recvd-Size: 3598 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Mon, 1 Feb 2021 13:19:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=w/fczicmbmO1py4GakJT2Tztq29zaHw4eemdxVZO/3c=; b=g4PopCaGcnb3zTBXhvzk+j7oAd zJ8AelvYw1MTMkpBmIjeDx+zuCvzrFeCnDJVpGwz9j1T5xb4smeoznN/3KRhRXjEKKadRofk5wwHm AaMT0Nuh4xjcWhF1jyZY1o0/In5o2hyNVyfh2Y4H1UYkkpNup08QvriYvD5ELoO7xPjx4y6zmVJ/+ wZtTZeVnh7igk0s+2e5dCN6JRBVCRospMcA4qpKId9xhk7jynXS2PKCdN4D0ou7hEsaszWZgCkQXp jWBFVX0nNN/sx2tBndNrEcCHyrici0W1wRAMTZlMpasjQP455V7QfPYQI5gz6DlbQ/Prao3jQ77mU pR9FmZgw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1l6Z6r-00DoBB-59; Mon, 01 Feb 2021 13:19:23 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 6A0ED3011FE; Mon, 1 Feb 2021 14:19:16 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 4DEBC20C8E333; Mon, 1 Feb 2021 14:19:16 +0100 (CET) Date: Mon, 1 Feb 2021 14:19:16 +0100 From: Peter Zijlstra To: Nadav Amit Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Nadav Amit , Andrea Arcangeli , Andrew Morton , Andy Lutomirski , Dave Hansen , Thomas Gleixner , Will Deacon , Yu Zhao , Nick Piggin , x86@kernel.org Subject: Re: [RFC 13/20] mm/tlb: introduce tlb_start_ptes() and tlb_end_ptes() Message-ID: References: <20210131001132.3368247-1-namit@vmware.com> <20210131001132.3368247-14-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210131001132.3368247-14-namit@vmware.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 30, 2021 at 04:11:25PM -0800, Nadav Amit wrote: > +#define tlb_start_ptes(tlb) \ > + do { \ > + struct mmu_gather *_tlb = (tlb); \ > + \ > + flush_tlb_batched_pending(_tlb->mm); \ > + } while (0) > + > +static inline void tlb_end_ptes(struct mmu_gather *tlb) { } > tlb_change_page_size(tlb, PAGE_SIZE); > orig_pte = pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl); > - flush_tlb_batched_pending(mm); > + tlb_start_ptes(tlb); > arch_enter_lazy_mmu_mode(); > for (; addr < end; pte++, addr += PAGE_SIZE) { > ptent = *pte; > @@ -468,6 +468,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, > } > > arch_leave_lazy_mmu_mode(); > + tlb_end_ptes(tlb); > pte_unmap_unlock(orig_pte, ptl); > if (pageout) > reclaim_pages(&page_list); I don't like how you're dubbling up on arch_*_lazy_mmu_mode(). It seems to me those should be folded into tlb_{start,end}_ptes(). Alternatively, the even more work approach would be to, add an optional @tlb argument to pte_offset_map_lock()/pte_unmap_unlock() and friends.