From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABD08C433E0 for ; Mon, 1 Feb 2021 16:05:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4690C64E9C for ; Mon, 1 Feb 2021 16:05:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4690C64E9C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C79406B0075; Mon, 1 Feb 2021 11:05:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C29776B0078; Mon, 1 Feb 2021 11:05:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3F1F6B007E; Mon, 1 Feb 2021 11:05:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id 9CFB26B0075 for ; Mon, 1 Feb 2021 11:05:05 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 548398249980 for ; Mon, 1 Feb 2021 16:05:05 +0000 (UTC) X-FDA: 77770172970.26.wave70_0b1406c275c3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id F20A7180238D1 for ; Mon, 1 Feb 2021 16:03:50 +0000 (UTC) X-HE-Tag: wave70_0b1406c275c3 X-Filterd-Recvd-Size: 3335 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Mon, 1 Feb 2021 16:03:48 +0000 (UTC) IronPort-SDR: fhcR0jAJW1tdWjhbKXJ8E9UwT8N4odRkQsaeHKvAVbmlPjlNLZiT6B6krG3KPZ/OpGrp+v69Lc xLquPU+rAR9w== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="180850588" X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="180850588" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 08:03:42 -0800 IronPort-SDR: ljDc5msUhmj/4lS3B56cYEn1l3RyBTJnAI3TFKuXb7/PJsJ7erdIUNrxtWc+L3hB5cmpPOojTk mSRyU9R1zN+A== X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="506891303" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 08:03:36 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1l6bfo-001AXR-RA; Mon, 01 Feb 2021 18:03:32 +0200 Date: Mon, 1 Feb 2021 18:03:32 +0200 From: Andy Shevchenko To: Yafang Shao Cc: David Hildenbrand , Vlastimil Babka , Miaohe Lin , Christoph Lameter , penberg@kernel.org, David Rientjes , iamjoonsoo.kim@lge.com, Andrew Morton , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , Linux MM , LKML , Joe Perches Subject: Re: [PATCH v2 3/3] vsprintf: dump full information of page flags in pGp Message-ID: References: <20210201115610.87808-1-laoar.shao@gmail.com> <20210201115610.87808-4-laoar.shao@gmail.com> <66784ea1-29c7-6bed-ca7f-cd3e7ea9155b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 01, 2021 at 09:52:53PM +0800, Yafang Shao wrote: > On Mon, Feb 1, 2021 at 9:34 PM Andy Shevchenko > wrote: > > On Mon, Feb 01, 2021 at 02:23:33PM +0100, David Hildenbrand wrote: > > > On 01.02.21 12:56, Yafang Shao wrote: ... > > > Printing that in addition to the raw value could be helpful. Just some > > > thoughts. > > > > printf() buffer is not a black hole, esp. when you get it messed with critical > > messages (Oops). I suggest to reduce a burden as much as possible. If you wish > > to get this, make it caller-configurable, i.e. adding another letter to the > > specifier. > > > > I think David's suggestion will help us to identify issues. > > You mean that we should use another one like "%pGpd" - means pGp debug > - to implement it ? Yes. -- With Best Regards, Andy Shevchenko