From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26A48C433E0 for ; Tue, 2 Feb 2021 10:47:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9362764D9C for ; Tue, 2 Feb 2021 10:47:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9362764D9C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1217B6B0072; Tue, 2 Feb 2021 05:47:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A9EA6B0073; Tue, 2 Feb 2021 05:47:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDB386B0074; Tue, 2 Feb 2021 05:47:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id D311C6B0072 for ; Tue, 2 Feb 2021 05:47:29 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9D7531EE6 for ; Tue, 2 Feb 2021 10:47:29 +0000 (UTC) X-FDA: 77773001418.01.blade37_070fc59275ca Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 8BDD61004A097 for ; Tue, 2 Feb 2021 10:47:29 +0000 (UTC) X-HE-Tag: blade37_070fc59275ca X-Filterd-Recvd-Size: 2748 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Feb 2021 10:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NADaTCO1CjR1KZmInxVOia+51JId9JWZI/jutXFKWOc=; b=p1lybmAIUWUqq7pxKWtAMsxKbp IFaPhA+3oSffoBaxzOD4kaMNLGpXMR+AvS8smi4Hmw804tuxMQQmXYUE+ytp0S2+s8aCVXQora/1X BuXNB1R1kxl6J7jr4K9WQGfDfyLkrcykH31znsBW4jEsEc98sHcbSivGie3Wo2sX3G6SuJmaAhaCd Wc5U4qcKHBjbwsOo4vcBfm+ZiiEIzAc6cgyQllovMJ4TR+/4ezyX20w5eAPpJSA4TOJ3CECah04/v R+E3Sgm4ORlphScAkIV7Sxt09sNKYDmvcN6z54dDrHYLYeI3TagaGSrNAHmFKJ9vpNKAEBFTUd/2h fIGT2RQg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1l6tDJ-00F4dx-Cn; Tue, 02 Feb 2021 10:47:19 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 502F2301A66; Tue, 2 Feb 2021 11:47:16 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 12801299C9F60; Tue, 2 Feb 2021 11:47:16 +0100 (CET) Date: Tue, 2 Feb 2021 11:47:16 +0100 From: Peter Zijlstra To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, kaleshsingh@google.com, joel@joelfernandes.org Subject: Re: [RFC PATCH 3/6] mm/mremap: Use pmd/pud_poplulate to update page table entries Message-ID: References: <20210202091116.196134-1-aneesh.kumar@linux.ibm.com> <20210202091116.196134-3-aneesh.kumar@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210202091116.196134-3-aneesh.kumar@linux.ibm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 02, 2021 at 02:41:13PM +0530, Aneesh Kumar K.V wrote: > pmd/pud_populate is the right interface to be used to set the respective > page table entries. Some architectures do assume that set_pmd/pud_at > can only be used to set a hugepage PTE. Since we are not setting up a hugepage > PTE here, use the pmd/pud_populate interface. Since you did the audit, it might be nice to record which architectures that are. Also, how much work to fix them?