From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59276C433E9 for ; Thu, 4 Feb 2021 16:26:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C49E864E35 for ; Thu, 4 Feb 2021 16:26:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C49E864E35 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 333B16B0005; Thu, 4 Feb 2021 11:26:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E4366B0006; Thu, 4 Feb 2021 11:26:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FA016B006E; Thu, 4 Feb 2021 11:26:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0155.hostedemail.com [216.40.44.155]) by kanga.kvack.org (Postfix) with ESMTP id 08DEF6B0005 for ; Thu, 4 Feb 2021 11:26:35 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C28E0181AEF1F for ; Thu, 4 Feb 2021 16:26:34 +0000 (UTC) X-FDA: 77781113508.13.cart72_2c05db4275dd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id B126118140B67 for ; Thu, 4 Feb 2021 16:26:34 +0000 (UTC) X-HE-Tag: cart72_2c05db4275dd X-Filterd-Recvd-Size: 3876 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Feb 2021 16:26:34 +0000 (UTC) Received: by mail-qk1-f174.google.com with SMTP id n15so3841297qkh.8 for ; Thu, 04 Feb 2021 08:26:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ACIgalIASwLRIdWMuW6Oj7uCmIS5PMrqjcUMfzNwZKE=; b=MhxcF478bHTzeOjaqn3t+dgrOQ2TemimDwkXVDLohFRJNl95pHbGa9lLMm7eUh47yK hqGCwPMieGsvldBevk/GTzZFLDZryCRd8tlWXVG8uYNf9AohQdvgTb+LxFJwSEjutywo 3E18OctPqEd11DhJx4NgXE4Yj0fHAQ0WIyhu+wgSKgvMnTRsuVjDtnLBrLvkb4TXY9Om LcJVZVFkYyCc7nEmtuJiow7He54ZkAWBEXGmmJe/6WxLOur+I/zZe0/QnliUXFYnnBc3 +cNlrBxAgNgbdTKF95BPokovA+P0SqJ0wm/w/bqBYg83pfhDJKy0DV+MBi+sqDRpT+Bx ZldA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ACIgalIASwLRIdWMuW6Oj7uCmIS5PMrqjcUMfzNwZKE=; b=qj/Pb0btJw5u98OvPJQdZ1lZtIfYeg52Ml/XXjMdZE6pwai84/AKVC42X9F5teNo7c gvvmGzpyNzRnusdzAau3M2KW/Qm2UIzdukK2vzV1kzhcCqs81psKqIgbECpiYIbmeUPd CSJy84ZKkBRK2RWVXAk93QBvYoaKsZfVlOe9frAuE6UHlUcHnpPSMhpzAjXMUHY60cu3 HICEcfCmjSSyRLZNmMIuhEsBXDmKPAS6RK1rMDqcX2LK0qZ0qkhZBgHPq9W6ngEIaAiF TRKxCTNHXGmNZUDT7AoPB/X/udpLmbbhAiWL1j3unsWAOt7SHonxORzGkmUxKhioaWT1 grzg== X-Gm-Message-State: AOAM5324v1rBipzT5J7zeqy7wo89xkO2ZZyxgT5HP3NFg1S+kaRIO2RL BmEJ5sD2p47wpDs8y1/970YZlw== X-Google-Smtp-Source: ABdhPJxIV4CD4lGok1rJ7D4sC9j6L8cQiM/cMuIlBrELVi3sX2eGXEMa9a2jlGvNzQjeqYhitY/mZA== X-Received: by 2002:a05:620a:5ae:: with SMTP id q14mr8254731qkq.156.1612455993552; Thu, 04 Feb 2021 08:26:33 -0800 (PST) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id k25sm5549112qkk.66.2021.02.04.08.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 08:26:32 -0800 (PST) Date: Thu, 4 Feb 2021 11:26:32 -0500 From: Johannes Weiner To: Roman Gushchin Cc: Andrew Morton , Tejun Heo , Michal Hocko , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 6/7] mm: memcontrol: switch to rstat Message-ID: References: <20210202184746.119084-1-hannes@cmpxchg.org> <20210202184746.119084-7-hannes@cmpxchg.org> <20210203014726.GE1812008@carbon.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210203014726.GE1812008@carbon.dhcp.thefacebook.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 02, 2021 at 05:47:26PM -0800, Roman Gushchin wrote: > On Tue, Feb 02, 2021 at 01:47:45PM -0500, Johannes Weiner wrote: > > for_each_node(node) { > > struct mem_cgroup_per_node *pn = memcg->nodeinfo[node]; > > + unsigned long stat[NR_VM_NODE_STAT_ITEMS] = {0, }; > ^^ > I'd drop the comma here. It seems that "{0}" version is way more popular > over the mm code and in the kernel in general. Is there a downside to the comma? I'm finding more { 0, } than { 0 } in mm code, and at least kernel-wide it seems both are acceptable (although { 0 } is more popular overall). I don't care much either way. I can change it in v2 if there is one.