From: Michal Hocko <mhocko@suse.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
David Hildenbrand <david@redhat.com>,
Muchun Song <songmuchun@bytedance.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: Make alloc_contig_range handle in-use hugetlb pages
Date: Wed, 17 Feb 2021 14:54:24 +0100 [thread overview]
Message-ID: <YC0gEBEeeDT1lZhD@dhcp22.suse.cz> (raw)
In-Reply-To: <20210217134649.GB32488@linux>
On Wed 17-02-21 14:46:49, Oscar Salvador wrote:
> On Wed, Feb 17, 2021 at 02:36:31PM +0100, Michal Hocko wrote:
> > On Wed 17-02-21 11:08:16, Oscar Salvador wrote:
> > > In-use hugetlb pages can be migrated as any other page (LRU
> > > and Movable), so let alloc_contig_range handle them.
> > >
> > > All we need is to succesfully isolate such page.
> >
> > Again, this is missing a problem statement and a justification why we
> > want/need this.
>
> Heh, I was poor in words.
>
> "alloc_contig_range() will fail miserably if it finds a HugeTLB page within
> the range without a chance to handle them. Since HugeTLB pages can be migrated
> as any other page (LRU and Movable), it does not make sense to bail out.
> Enable the interface to recognize in-use HugeTLB pages and have a chance
> to migrate them"
>
> What about something along those lines?
Is this a real life problem? I know we _can_ but I do not see any
reasoning _why_ should we care all that much.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-02-17 13:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 10:08 [PATCH 0/2] Make alloc_contig_range handle Hugetlb pages Oscar Salvador
2021-02-17 10:08 ` [PATCH 1/2] mm: Make alloc_contig_range handle free hugetlb pages Oscar Salvador
2021-02-17 13:30 ` Michal Hocko
2021-02-17 13:36 ` David Hildenbrand
2021-02-17 13:50 ` Michal Hocko
2021-02-17 13:53 ` David Hildenbrand
2021-02-17 13:59 ` Michal Hocko
2021-02-17 14:08 ` David Hildenbrand
2021-02-17 14:14 ` Michal Hocko
2021-02-17 14:23 ` Oscar Salvador
2021-02-17 13:42 ` Oscar Salvador
2021-02-17 15:00 ` Michal Hocko
2021-02-18 10:09 ` Oscar Salvador
2021-02-18 12:52 ` Michal Hocko
2021-02-18 13:32 ` Oscar Salvador
2021-02-18 13:59 ` Michal Hocko
2021-02-18 16:53 ` Oscar Salvador
2021-02-19 9:05 ` Oscar Salvador
2021-02-19 9:56 ` Michal Hocko
2021-02-19 10:14 ` Oscar Salvador
2021-02-19 20:00 ` Mike Kravetz
2021-02-19 10:40 ` Oscar Salvador
2021-02-19 10:55 ` Michal Hocko
2021-02-19 11:17 ` Oscar Salvador
2021-02-19 11:24 ` Michal Hocko
2021-02-17 10:08 ` [PATCH 2/2] mm: Make alloc_contig_range handle in-use " Oscar Salvador
2021-02-17 13:36 ` Michal Hocko
2021-02-17 13:46 ` Oscar Salvador
2021-02-17 13:54 ` Michal Hocko [this message]
2021-02-17 15:06 ` Michal Hocko
2021-02-17 15:27 ` Oscar Salvador
2021-02-17 15:33 ` Michal Hocko
2021-02-18 6:01 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC0gEBEeeDT1lZhD@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=osalvador@suse.de \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).