From: Chris Down <chris@chrisdown.name>
To: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
Cc: Michal Hocko <mhocko@suse.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"yzaikin@google.com" <yzaikin@google.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Felipe Franciosi <felipe@nutanix.com>,
"shakeelb@google.com" <shakeelb@google.com>
Subject: Re: [RFC PATCH] mm, oom: introduce vm.sacrifice_hugepage_on_oom
Date: Thu, 18 Feb 2021 12:39:09 +0000 [thread overview]
Message-ID: <YC5f7SalbXhemwV7@chrisdown.name> (raw)
In-Reply-To: <99FF105C-1AAB-40F3-9C13-7BDA23AD89D9@nutanix.com>
Eiichi Tsukata writes:
>>> But that comes with a challenge: despite listening on cgroup for
>>> pressure notifications (which happen from those runtime events we do
>>> not control),
>>
>> We do also have global pressure (PSI) counters. Have you tried to look
>> into those and try to back off even when the situation becomes critical?
>
>Yes. PSI counters help us to some extent. But we've found that in some cases
>OOM can happen before we observe memory pressure if memory bloat occurred
>rapidly. The proposed failsafe mechanism can cover even such a situation.
>Also, as I mentioned in commit message, oom notifiers doesn't work if OOM
>is triggered by memory allocation for kernel.
Hmm, do you have free swap? Without it, we can trivially go from fine to OOM in
a totally binary fashion. As long as there's some swap space available, there
should be a clear period where pressure is rising prior to OOM.
next prev parent reply other threads:[~2021-02-18 12:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 3:07 [RFC PATCH] mm, oom: introduce vm.sacrifice_hugepage_on_oom Eiichi Tsukata
2021-02-16 8:12 ` Michal Hocko
2021-02-16 21:53 ` David Rientjes
2021-02-17 7:54 ` Michal Hocko
2021-02-17 14:59 ` Shakeel Butt
2021-02-16 22:30 ` Mike Kravetz
2021-02-17 7:57 ` Michal Hocko
2021-02-17 10:42 ` Eiichi Tsukata
2021-02-17 12:31 ` Michal Hocko
2021-02-17 12:40 ` Michal Hocko
2021-02-18 12:22 ` Eiichi Tsukata
2021-02-18 12:39 ` Chris Down [this message]
2021-02-16 13:38 ` Chris Down
2021-02-17 9:09 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC5f7SalbXhemwV7@chrisdown.name \
--to=chris@chrisdown.name \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=eiichi.tsukata@nutanix.com \
--cc=felipe@nutanix.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=shakeelb@google.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).