From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4425C433DB for ; Thu, 18 Feb 2021 15:36:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3F21064DDA for ; Thu, 18 Feb 2021 15:36:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F21064DDA Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AA2636B006E; Thu, 18 Feb 2021 10:36:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2C606B0070; Thu, 18 Feb 2021 10:36:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CC246B0071; Thu, 18 Feb 2021 10:36:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0088.hostedemail.com [216.40.44.88]) by kanga.kvack.org (Postfix) with ESMTP id 6E22B6B006E for ; Thu, 18 Feb 2021 10:36:08 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2DBCA181AF5E6 for ; Thu, 18 Feb 2021 15:36:08 +0000 (UTC) X-FDA: 77831789616.27.846442B Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf06.hostedemail.com (Postfix) with ESMTP id 4D89CC0001EA for ; Thu, 18 Feb 2021 15:36:08 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1613662566; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J0bYXrkkoPf7gVIUGqIf4ANRouo9dbAcE/WUn/S4mKM=; b=bQvVgdZl5ZzeQ5N4N+rSaHvztptxpoBV6JLXiGija5xYmN7S7MzLGqJuhKzUQXt1AOE0qw +8qZMv8zEhIJbjjpds5/C/T3v3hQei4tRzfneKT7l0oV12t5skMkNnqZ5R5zIFdornAQy8 mw9/delHn81QPDF/I6Rkba1cxdv/Sak= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1AE14ACD4; Thu, 18 Feb 2021 15:36:06 +0000 (UTC) Date: Thu, 18 Feb 2021 16:36:00 +0100 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Johannes Weiner Cc: Andrew Morton , Tejun Heo , Michal Hocko , Roman Gushchin , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v3 6/8] mm: memcontrol: switch to rstat Message-ID: References: <20210209163304.77088-1-hannes@cmpxchg.org> <20210209163304.77088-7-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uZNJgE1PSkaSK3Iw" Content-Disposition: inline In-Reply-To: <20210209163304.77088-7-hannes@cmpxchg.org> X-Stat-Signature: igbaayet16yaejwaofcm3tnenanb1z48 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4D89CC0001EA Received-SPF: none (suse.com>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613662568-534957 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --uZNJgE1PSkaSK3Iw Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 09, 2021 at 11:33:02AM -0500, Johannes Weiner wrote: > Rstat combines the best of both worlds: from the write side, it > cheaply maintains a queue of cgroups that have pending changes, so > that the read side can do selective tree aggregation. This way the > reported stats will always be precise and recent as can be, while the > aggregation can skip over potentially large numbers of idle cgroups. IIUC, on the unified hierarchy the rstat tree built from writer notifications is shared with all controllers. (Currently, it means memory updates are merged with base stats cpu time updates.) This is just for reference, to stress the current rstat design. > --- > include/linux/memcontrol.h | 67 ++++++----- > mm/memcontrol.c | 223 +++++++++++++++---------------------- > 2 files changed, 132 insertions(+), 158 deletions(-) Well done. Reviewed-by: Michal Koutn=FD --uZNJgE1PSkaSK3Iw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEEoQaUCWq8F2Id1tNia1+riC5qSgFAmAuiVwACgkQia1+riC5 qSgMFQ/+P3SjzQZK1rAMCOLKGsCvWS+G4aY2oJqOwqeeoIbEl4mvs2o0K3JTl72o u/NuEl/GEEehOrO6wnWA1QW0fVPFGXIkvFLmprRk9vOhg7nixi7VqAB73FnWyIOW NR0mM5CHnjAR7VfB2eh8rOnMTjA/LL6W+QGc2Z9OTbYHQ8ZHpILIjqlFAvIWa7SL C8y6vGv9wpiB3oZngg1NVtQ5+CS8EkkUNgJRmSzi8DatO4gwjhFVvXpFD1oFjCvk 1aHQeouFOxvpgy2m6LHjKzg3ybP1APXunDnhrPV8d0/hsw3JNUtyGLlDWMGQmJyg q4UVVeUu92jDkD9iWsRSBSxG0AELlHIsxJJKh4lm0VXbYSMprX90+cNLEA7fAOy7 TTEUpzaJvOHM9/KzMKjV5EPL1YQ7ZkKV20Vf09802YRh2FZm9njxneqS0GHHS89f ZtVPB21C7INTntOrNVP8vDT/IcpAUG6eSXWGtrCWL+/Lcbr9IE0jw1Py7rUV1VnR 6CBQgFXf/qckuLdZULmlRjTsy3N3OE5KryOe8EL9c0ikHA+SJBQZ90JW3NapX/q9 KRMdi6oMWEBGp8mUPAWuT5jFrExSKOjemRdeYAF0x+l1kzVIVST7kFc2djkFi3o8 UCQ/yJaL/0En58UKyBOJPmQNBCBNwC2kH5g9ws0hiAdwlDUnxxc= =Dp9h -----END PGP SIGNATURE----- --uZNJgE1PSkaSK3Iw--