From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 542E3C433DB for ; Thu, 18 Feb 2021 16:10:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BC76464E76 for ; Thu, 18 Feb 2021 16:10:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC76464E76 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3B78C6B006C; Thu, 18 Feb 2021 11:10:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 366C96B006E; Thu, 18 Feb 2021 11:10:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27CA86B0070; Thu, 18 Feb 2021 11:10:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 0EF596B006C for ; Thu, 18 Feb 2021 11:10:35 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CC9921DE1 for ; Thu, 18 Feb 2021 16:10:34 +0000 (UTC) X-FDA: 77831876388.08.1CB7836 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf27.hostedemail.com (Postfix) with ESMTP id A84DF80192F3 for ; Thu, 18 Feb 2021 16:10:30 +0000 (UTC) Received: by mail-pg1-f176.google.com with SMTP id o38so1410720pgm.9 for ; Thu, 18 Feb 2021 08:10:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=k/RqDGUNhoNYq3IBZ52eaMQt2gjuVi91yB+Zi9HnIoY=; b=I7rUmNQljY9Jk3djbiDNOojkc4eoNilxIHJ9KUKZjvQsEC0jDer5M0cwdhn8w24b5m 09ZQ0M6lt/GZj1TS8gbFpixow3S6hEMrr2fOrhpD8huHouISOOzDP3WdkMpWDD1BsagS sH/A10O8Ge9LOuuAgJoB28xuhnU8rhUy/sMIiB4IarNb1naKc++OA/Ul8naCmFlyoYhI wSv1QW6MLe8opogR82YsgCwa7q97jbryIxqP8a/xO1ZpWtx9A/xTuwY92ogpU8OKpYNV x3+8WcNebObNrO4Sp9QeQOI7z1bqUQmI2fT1xpwHVV56N+lXwSAp9mR5vPU0otMPc5xj AtJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=k/RqDGUNhoNYq3IBZ52eaMQt2gjuVi91yB+Zi9HnIoY=; b=SxaATh8Qq+e5Fdyy3HjWqDsvRrM2OMwP3FBlp+jh/iBgRlRyzombCZMMMzUwzYMLzE lQ5Wf4Tf1Vf7CMD5vRnCexyDb7lc7g9n0+D93CsFA8SS51w0uNhk2Q0gA9eCKgFyFFrC 0HKHB5OyagtqZHKknNiQ2EBHQg6kB8QU0bGbgo28Z+DfB9hqViofXCTSuWD6U1ABbkp8 IBcPnJovVY0Y35Mar/gpPOwmexIqDiSS/kEqnDp5mhuNiv1A/56NNsAiaBBSCnAkZ7l9 Mva6UYVTzr2kpRj45tmU2VM5JYNSbIA/lGzXVUfaidZKdSUyYrCtfJ5RXdxjCOYOkItv YBKw== X-Gm-Message-State: AOAM5307H3Mp4FLkz/h0zawULdk+vlpxwmdwnDy/HeBoTKap+Rsm1ztM aTO16DfSJa18IHA2DWxF+QE= X-Google-Smtp-Source: ABdhPJxzK3s1aFvwRizRfxBz5x8pjjKoHWjP2ahug80JQzM2nsD4pay2JZfUjYxQB7yKwELPepy1Kw== X-Received: by 2002:a65:458e:: with SMTP id o14mr4517255pgq.444.1613664633349; Thu, 18 Feb 2021 08:10:33 -0800 (PST) Received: from google.com ([2620:15c:211:201:157d:8a19:5427:ea9e]) by smtp.gmail.com with ESMTPSA id g62sm6876628pgc.32.2021.02.18.08.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 08:10:32 -0800 (PST) Date: Thu, 18 Feb 2021 08:10:30 -0800 From: Minchan Kim To: Michal Hocko Cc: Andrew Morton , linux-mm , LKML , david@redhat.com, joaodias@google.com Subject: Re: [PATCH] mm: be more verbose for alloc_contig_range faliures Message-ID: References: <20210217163603.429062-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A84DF80192F3 X-Stat-Signature: 3ha1iu6wddde9f5fijrufbidjm5ieb6t Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=mail-pg1-f176.google.com; client-ip=209.85.215.176 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613664630-38281 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 18, 2021 at 09:56:18AM +0100, Michal Hocko wrote: > On Wed 17-02-21 08:36:03, Minchan Kim wrote: > > alloc_contig_range is usually used on cma area or movable zone. > > It's critical if the page migration fails on those areas so > > dump more debugging message like memory_hotplug unless user > > specifiy __GFP_NOWARN. > > I agree with David that this has a potential to generate a lot of output > and it is not really clear whether it is worth it. Page isolation code > already has REPORT_FAILURE mode which currently used only for the memory > hotplug because this was just too noisy from the CMA path - d381c54760dc > ("mm: only report isolation failures when offlining memory"). > > Maybe migration failures are less likely to fail but still. Doesn't CMA > allocator provide some useful error reporting on its own? Unfortunately, it's very useless. :( ``` in cma.c pr_debug("%s(): memory range at %p is busy, retrying\n", __func__, pfn_to_page(pfn)); ``` even, the pfn is not failed page. Originally, I thought to deal with it from cma.c to minimize changes but it was tough because cma area couldn't get the failed page list.