From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 551CAC433E0 for ; Thu, 18 Feb 2021 17:06:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A414564E15 for ; Thu, 18 Feb 2021 17:06:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A414564E15 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 14DEE6B006E; Thu, 18 Feb 2021 12:06:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D7436B0070; Thu, 18 Feb 2021 12:06:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6BDB6B0071; Thu, 18 Feb 2021 12:06:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CB6FF6B006E for ; Thu, 18 Feb 2021 12:06:46 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 74E521730863 for ; Thu, 18 Feb 2021 17:06:46 +0000 (UTC) X-FDA: 77832018012.23.route71_171132427656 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 52E8A37604 for ; Thu, 18 Feb 2021 17:06:46 +0000 (UTC) X-HE-Tag: route71_171132427656 X-Filterd-Recvd-Size: 4042 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Thu, 18 Feb 2021 17:06:45 +0000 (UTC) Received: by mail-qk1-f181.google.com with SMTP id v206so2787924qkb.3 for ; Thu, 18 Feb 2021 09:06:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=zVENMey1EdFzZhk4Yon7dEXfrybku0MTAsUKJNMONig=; b=Y1SWeFTKNyObDh6T0tVdAgoEZMOAylAVj0RaiIh4kAxsIwLKcsBRG7tkJfxs3cHEKu NOWc39l8M1vBqjKsIMnc+AtNj0YWSFBUUDAUFpgpXHuzPzLnk3MRbun/IK0sJH9iZqCi RdKo6WX4ySkyoeKwlC94IFZsf1Ggdowq/47IJqc+GCWUnkGbAfJudf0kZ1qCFSoUNHHv dY/nu1cl5r8HS/JXRG7goGXAtXL1RrdpPQrPCdy4hfiG1WW/Jl8mkMBXUYgonM//jEni tEXmFMLO5cKxRzFHrI9OfkDp/+N6LspjAeUDpjjPIkd3xT5lsvZV4/93GtGUolxXXHfH c9TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zVENMey1EdFzZhk4Yon7dEXfrybku0MTAsUKJNMONig=; b=onFqvjZkcmfCWxaVV7uL6An3KkayyGQZ4Mz2SgpE+rNr/AMMNwI2n6/whSg7gUAJ8c UQNgpbLhbNFpEyG/3xyGSICFoJZgtOxoU6EtfaAXhZcp2t8iBZpGch+j799/7gA5IFf3 a4A1ByqPMSZFRdDdkYQtwLTaULjwAYyVZglZa9Rdl/RK0jt9aPhGHw0Sbf8QePXtmh+r HE6j/xnzhwcnqKjXIlRPlX7L490dwZPayuLCzJyrz2O/GnddAMYz6iGe6AfkejMOU25y Xkd9iIMBfDrPbF2HD6gxnZhLU80CWa3fJrm1f9J7A45TD9cGTfduRnYVhCh5sqf4gcAt 1yfQ== X-Gm-Message-State: AOAM532zlXUxrm5hrhrfKBKGdlC1uF4wTOeWqQcT6dPYeaDsHLsC8EqX No0+t1SBZxGOyC9jYjHZDvBqGQ== X-Google-Smtp-Source: ABdhPJx9iIU6TFeUSb0A5vm+Lg9Nywr+deM4uatCuWy5lkLBvlxLa/67dT0NGQDC3PG+xNOK/X/C/Q== X-Received: by 2002:ae9:f309:: with SMTP id p9mr5127370qkg.111.1613668004287; Thu, 18 Feb 2021 09:06:44 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:b3a9]) by smtp.gmail.com with ESMTPSA id b9sm890037qkj.90.2021.02.18.09.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 09:06:43 -0800 (PST) Date: Thu, 18 Feb 2021 12:06:42 -0500 From: Johannes Weiner To: Michal =?iso-8859-1?Q?Koutn=FD?= Cc: Andrew Morton , Tejun Heo , Michal Hocko , Roman Gushchin , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v3 4/8] cgroup: rstat: support cgroup1 Message-ID: References: <20210209163304.77088-1-hannes@cmpxchg.org> <20210209163304.77088-5-hannes@cmpxchg.org> <20210217174232.GA19239@blackbody.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 18, 2021 at 04:45:11PM +0100, Michal Koutn=FD wrote: > On Wed, Feb 17, 2021 at 03:52:59PM -0500, Johannes Weiner wrote: > > In this case, we're talking about a relatively small data structure > > and the overhead is per mountpoint. > IIUC, it is per each mountpoint's number of cgroups. But I still accept > the argument above. Furthermore, this can be changed later. Oops, you're right of course. > > The default root group has statically preallocated percpu data before > > and after this patch. See cgroup.c: > I stand corrected, the comment is still valid. >=20 > Therefore, > Reviewed-by: Michal Koutn=FD Thanks for your reviews, Michal!