From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D4A3C433DB for ; Mon, 8 Feb 2021 21:03:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7BB5C64E50 for ; Mon, 8 Feb 2021 21:03:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BB5C64E50 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B33146B0005; Mon, 8 Feb 2021 16:03:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE3296B006C; Mon, 8 Feb 2021 16:03:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9ACAB6B006E; Mon, 8 Feb 2021 16:03:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id 84EB66B0005 for ; Mon, 8 Feb 2021 16:03:00 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 46E25184818CF for ; Mon, 8 Feb 2021 21:03:00 +0000 (UTC) X-FDA: 77796325320.03.glue46_0c019b827601 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 2A8FB28A4E9 for ; Mon, 8 Feb 2021 21:03:00 +0000 (UTC) X-HE-Tag: glue46_0c019b827601 X-Filterd-Recvd-Size: 3999 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Feb 2021 21:02:59 +0000 (UTC) Received: by mail-qt1-f176.google.com with SMTP id e15so11404157qte.9 for ; Mon, 08 Feb 2021 13:02:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yTVAlNOZNa/h2RjRt2M5Ou305u4ysb6/0EoJiOGY+8o=; b=op/01oUWlbCNAjdOj9gvkl0CtDftRT2/UisLx184sVL4C3qbV910sFUhFliXU6Xlr/ 99ybdviATLOoTaI2/HYBZButNPjGV/7zorb0GMeWgiKyQCCNkj/HwJl9JHnbjKWnEj8D fEHHfrkI/p5qlxaAUU/ye6S37z0eYy/2Kvi2PEXrrM/zFjaUMfBGPziYIqwl/jDYqdtj FtBAda3OmOQA5IYdGqZeZS4wCT3ONWsDMmCeWaPAjqSYgC+uUynQ8i7cBx2LaW0E35nc 7OmFZLGKQsjphqv+IpuHlIcDsqHmDGh+M12+y2W/WeO8vruOOpJRz3A5YrAJP09kxKJA +XmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=yTVAlNOZNa/h2RjRt2M5Ou305u4ysb6/0EoJiOGY+8o=; b=eNOahgvOW9bMCTO0UhRe1ZCTPVQogk5rYefvqfUm+Dvtng8F1Pu4Bd7s85YXzhnXLU EPpeg+JhtarMhl4T8YC70Y7r35EGtupvNgpoH+4l8EGFc+JWSHJOw2IuhaK7vroDTU2K YAIt2fTmlcA/3smUuQc9UBE1VWRNgSKrPzVHM142fuGPBQ1vPuP2x1ajX19AX7x0LXzH MAXo8sBoX77OWuzXHlP9TqyfAtrigwh0yRf07ucVGpcrORE2TRKgNgzkPmBENkOV79OA BiwaU2osylHGehVAPHKMUXQjSQ0D0kjutroP/l83V0/nm89PruvbR+L1FQoa38OtxhHR CKng== X-Gm-Message-State: AOAM530VLDqhokdHkbtdX/TtQ7yXNUNAcRff1MYtcCLvXhHB7cfH/KAJ BpDQQsxD/ck9efIzd5GPAgY= X-Google-Smtp-Source: ABdhPJzqWPbUEfdwA1oDEwxPI/kFbYC2A5s4TGF2TWHi5gP7IQdLWMODVYgDsugYf/YH+jFsepi1Gw== X-Received: by 2002:aed:33c4:: with SMTP id v62mr15598048qtd.377.1612818178911; Mon, 08 Feb 2021 13:02:58 -0800 (PST) Received: from localhost (dhcp-6c-ae-f6-dc-d8-61.cpe.echoes.net. [72.28.8.195]) by smtp.gmail.com with ESMTPSA id h63sm15407645qtd.14.2021.02.08.13.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 13:02:58 -0800 (PST) Date: Mon, 8 Feb 2021 11:02:55 -0500 From: Tejun Heo To: Johannes Weiner Cc: Shakeel Butt , Andrew Morton , Michal Hocko , Roman Gushchin , Linux MM , Cgroups , LKML , Kernel Team Subject: Re: [PATCH 7/8] mm: memcontrol: consolidate lruvec stat flushing Message-ID: References: <20210205182806.17220-1-hannes@cmpxchg.org> <20210205182806.17220-8-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Mon, Feb 08, 2021 at 03:54:14PM -0500, Johannes Weiner wrote: > We probably do need a better solution for the lruvecs as well, but in > this case it just started holding up fixing the memory.stat issue for > no reason and so I tabled it for another patch series. rstat doesn't currently have a flush throttling mechanism cuz it doens't expect readers to be super hot but adding one should be pretty easy - e.g. it can just keep track of the number of updates on this cpu since the last flush and then flush iff the it's above a certain threshold. Shouldn't be too difficult to match or exceed the performance and error characteristics of the existing code. Thanks. -- tejun