From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Yafang Shao <laoar.shao@gmail.com>,
willy@infradead.org, david@redhat.com, linmiaohe@huawei.com,
vbabka@suse.cz, cl@linux.com, penberg@kernel.org,
rientjes@google.com, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, rostedt@goodmis.org,
sergey.senozhatsky@gmail.com, joe@perches.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] vsprintf: dump full information of page flags in pGp
Date: Tue, 9 Feb 2021 16:16:01 +0200 [thread overview]
Message-ID: <YCKZIWMYjD33xXnr@smile.fi.intel.com> (raw)
In-Reply-To: <YCKT8WCPGU+HBY91@alley>
On Tue, Feb 09, 2021 at 02:53:53PM +0100, Petr Mladek wrote:
> On Tue 2021-02-09 18:56:13, Yafang Shao wrote:
...
> I am sorry for my ignorance. I am not familiar with MM.
> But it is pretty hard to understand what call does what.
>
> I have found the following comment in include/linux/page_flags.h:
>
> * The page flags field is split into two parts, the main flags area
> * which extends from the low bits upwards, and the fields area which
> * extends from the high bits downwards.
>
> Sigh, I know that you already reworked this several times because
> people "nitpicked" about the code style. But it seems that it
> rather diverged instead of converged.
>
> What about the following?
Isn't is some like v1 or v2?
> Note: It is inpired by the names "main area" and "fields area"
> mentioned in the above comment from page_flags.h.
> I have later realized that "page_flags_layout" actually made
> sense as well. Feel free to rename page_flags_fileds
> back to page_flags_layout.
>
> Anyway, this is my proposal:
What about to create a one format_flags() function which accepts new data
structure and do something like
buf = format_flags(main_area);
buf = format_flags(fields_area);
return buf;
?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-09 14:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 10:56 [PATCH v4 0/3] mm, vsprintf: dump full information of page flags in pGp Yafang Shao
2021-02-09 10:56 ` [PATCH v4 1/3] mm, slub: use pGp to print page flags Yafang Shao
2021-02-09 10:57 ` David Hildenbrand
2021-02-09 10:56 ` [PATCH v4 2/3] mm, slub: don't combine pr_err with INFO Yafang Shao
2021-02-09 10:57 ` David Hildenbrand
2021-02-09 10:56 ` [PATCH v4 3/3] vsprintf: dump full information of page flags in pGp Yafang Shao
2021-02-09 11:00 ` David Hildenbrand
2021-02-09 12:00 ` Vlastimil Babka
2021-02-09 13:53 ` Petr Mladek
2021-02-09 14:16 ` Andy Shevchenko [this message]
2021-02-09 14:57 ` Petr Mladek
2021-02-09 16:21 ` Yafang Shao
2021-02-10 12:51 ` Petr Mladek
2021-02-10 13:04 ` Joe Perches
2021-02-10 15:39 ` Yafang Shao
2021-02-09 12:41 ` [PATCH v4 0/3] mm, " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCKZIWMYjD33xXnr@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=laoar.shao@gmail.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).