From: Michal Hocko <mhocko@suse.com>
To: zhou xianrong <xianrong_zhou@163.com>
Cc: iamjoonsoo.kim@lge.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
rostedt@goodmis.org, mingo@redhat.com, vbabka@suse.cz,
rientjes@google.com, willy@linux.intel.com,
pankaj.gupta.linux@gmail.com, bhe@redhat.com,
ying.huang@intel.com, minchan@kernel.org,
ruxian.feng@transsion.com, kai.cheng@transsion.com,
zhao.xu@transsion.com, yunfeng.lan@transsion.com,
zhouxianrong@tom.com, zhou xianrong <xianrong.zhou@transsion.com>
Subject: Re: [PATCH] kswapd: no need reclaim cma pages triggered by unmovable allocation
Date: Wed, 10 Feb 2021 14:14:46 +0100 [thread overview]
Message-ID: <YCPcRj/e9NdQIV9S@dhcp22.suse.cz> (raw)
In-Reply-To: <bc294334-eec3-f755-cb51-0e302e82809b@163.com>
On Wed 10-02-21 12:07:57, zhou xianrong wrote:
>
> On 2021/2/9 下午5:23, Michal Hocko wrote:
> > On Tue 09-02-21 16:23:13, zhou wrote:
> > > From: zhou xianrong <xianrong.zhou@transsion.com>
> > >
> > > For purpose of better migration cma pages are allocated after
> > > failure movalbe allocations and are used normally for file pages
> > > or anonymous pages.
> > >
> > > In reclaim path so many cma pages if configurated are reclaimed
> > > from lru lists in kswapd mainly or direct reclaim triggered by
> > > unmovable or reclaimable allocations. But these cma pages can not
> > > be used by original unmovable or reclaimable allocations. So the
> > > reclaim are unnecessary.
> > >
> > > In a same system if the cma pages were configurated to large then
> > > more failture unmovable (vmalloc etc.) or reclaimable (slab etc.)
> > > allocations are arised and then more kswapd rounds are triggered
> > > and then more cma pages are reclaimed.
> > Could you be more specific? Do you have any numbers and an example
> > configuration when this is visible?
> It should be implicit.
Right but the scale of the problem is an important part of _any_ patch
justification.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-02-10 13:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 8:23 [PATCH] kswapd: no need reclaim cma pages triggered by unmovable allocation zhou
2021-02-09 9:23 ` Michal Hocko
2021-02-10 4:07 ` zhou xianrong
2021-02-10 13:14 ` Michal Hocko [this message]
2021-02-11 1:58 ` zhouxianrong
2021-02-11 11:01 ` zhou xianrong
2021-03-13 8:31 zhou
2021-03-13 10:50 ` kernel test robot
2021-03-15 15:46 ` David Hildenbrand
2021-03-15 16:09 ` Michal Hocko
2021-03-15 16:12 ` David Hildenbrand
2021-03-16 1:57 ` zhou xianrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCPcRj/e9NdQIV9S@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kai.cheng@transsion.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=ruxian.feng@transsion.com \
--cc=vbabka@suse.cz \
--cc=willy@linux.intel.com \
--cc=xianrong.zhou@transsion.com \
--cc=xianrong_zhou@163.com \
--cc=ying.huang@intel.com \
--cc=yunfeng.lan@transsion.com \
--cc=zhao.xu@transsion.com \
--cc=zhouxianrong@tom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).