From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04947C433DB for ; Thu, 11 Feb 2021 17:23:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 87C1B64DE9 for ; Thu, 11 Feb 2021 17:23:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87C1B64DE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 158B26B0135; Thu, 11 Feb 2021 12:23:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 109CD6B0136; Thu, 11 Feb 2021 12:23:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01FD06B0137; Thu, 11 Feb 2021 12:23:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id E02826B0135 for ; Thu, 11 Feb 2021 12:23:41 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9BE631EE6 for ; Thu, 11 Feb 2021 17:23:41 +0000 (UTC) X-FDA: 77806659042.28.C487327 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf10.hostedemail.com (Postfix) with ESMTP id E7E62407F8C4 for ; Thu, 11 Feb 2021 17:23:39 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1613064219; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eWYmxmlJhWs/eHrgE4qsJfBzpcX3ZdkLwS/bN4B28wE=; b=i4MF4afunucbyASG65Af2ycJnl66rT0KbW4KX8o33ltJbmpgPhMSkafixM8IvVJdDGCU/J 5S1k4YE5oRdNEnv7Tu3dCxJrEqg4N1Wqoe0S5IADrjFRwzPVSl52tXflYojrF8Qgn4+6v6 DCVzbBQgn609lFvGMotjJLk4K7SFwJA= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C4E04AC43; Thu, 11 Feb 2021 17:23:39 +0000 (UTC) Date: Thu, 11 Feb 2021 18:23:38 +0100 From: Petr Mladek To: Timur Tabi Cc: Pavel Machek , Steven Rostedt , Sergey Senozhatsky , Vlastimil Babka , Andy Shevchenko , Matthew Wilcox , akpm@linux-foundation.org, Linus Torvalds , roman.fietze@magna.com, Kees Cook , John Ogness , akinobu.mita@gmail.com, glider@google.com, Andrey Konovalov , Marco Elver , Rasmus Villemoes , Tetsuo Handa , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/3] [v3] lib/vsprintf: debug_never_hash_pointers prints all addresses as unhashed Message-ID: References: <20210210213453.1504219-1-timur@kernel.org> <20210210213453.1504219-4-timur@kernel.org> <20210211123118.GB31708@amd> <9f0c02d9-29d6-95ce-b9b7-27342aa70c6f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f0c02d9-29d6-95ce-b9b7-27342aa70c6f@kernel.org> X-Stat-Signature: kxc4kp4pgpphrrmpwecrn7ctu5ro1auf X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E7E62407F8C4 Received-SPF: none (suse.com>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613064219-802828 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 2021-02-11 11:08:12, Timur Tabi wrote: > > > On 2/11/21 6:31 AM, Pavel Machek wrote: > > Can we make this something shorter? Clearly you don't want people > > placing this in their grub config, so they'll be most likely typing > > this a lot... > > > > debug_pointers or debug_ptrs would be better. > > dbg_unhash_ptrs? "debug_ptrs" is too vague IMHO, and I want to keep the > word "hash" somewhere there to indicate exactly what's happening. I understand that the long name is painful. But I would prefer to avoid another bike shedding over it. There was some pushback against this feature in general. It should be used deliberately and people must be aware of the consequences. This is why it is only boot option and why it prints such a huge warning. The long clear name helps as well. I propose to keep the name as is for now. We could always introduce an alias later when there is a wide preference and consensus. Best Regards, Petr