From: Chris Down <chris@chrisdown.name>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH] ia64: Depend on non-static printk for cmpxchg debug
Date: Fri, 26 Feb 2021 13:14:55 +0000 [thread overview]
Message-ID: <YDj0T7H4ZbuEAYwK@chrisdown.name> (raw)
In-Reply-To: <20210226130029.GC2723601@casper.infradead.org>
Matthew Wilcox writes:
>Why not just fix it?
>
>diff --git a/arch/ia64/include/uapi/asm/cmpxchg.h b/arch/ia64/include/uapi/asm/cmpxchg.h
>index 5d90307fd6e0..d955a8e3ebde 100644
>--- a/arch/ia64/include/uapi/asm/cmpxchg.h
>+++ b/arch/ia64/include/uapi/asm/cmpxchg.h
>@@ -139,7 +139,7 @@ extern long ia64_cmpxchg_called_with_bad_pointer(void);
> do { \
> if (_cmpxchg_bugcheck_count-- <= 0) { \
> void *ip; \
>- extern int printk(const char *fmt, ...); \
>+ int printk(const char *fmt, ...); \
> ip = (void *) ia64_getreg(_IA64_REG_IP); \
> printk("CMPXCHG_BUGCHECK: stuck at %p on word %p\n", ip, (v));\
> break; \
I must confess I have no idea of the history of why it was `extern int` in the
first place -- my fear was somehow we use cmpxchg.h from a different context.
Do you have any idea? :-)
next prev parent reply other threads:[~2021-02-26 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YCflN5zTvo5mxvKY@chrisdown.name>
2021-02-26 12:47 ` [PATCH] ia64: Depend on non-static printk for cmpxchg debug Chris Down
2021-02-26 13:00 ` Matthew Wilcox
2021-02-26 13:14 ` Chris Down [this message]
2021-02-26 13:47 ` Chris Down
2021-02-26 13:50 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDj0T7H4ZbuEAYwK@chrisdown.name \
--to=chris@chrisdown.name \
--cc=akpm@linux-foundation.org \
--cc=fenghua.yu@intel.com \
--cc=kernel-team@fb.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tony.luck@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).