From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DC6CC433DB for ; Thu, 4 Mar 2021 15:39:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9FF6264F21 for ; Thu, 4 Mar 2021 15:39:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FF6264F21 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 000E36B000A; Thu, 4 Mar 2021 10:39:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF0B16B000C; Thu, 4 Mar 2021 10:39:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6BB56B000D; Thu, 4 Mar 2021 10:39:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id B24996B000A for ; Thu, 4 Mar 2021 10:39:47 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6E8B2180A702F for ; Thu, 4 Mar 2021 15:39:47 +0000 (UTC) X-FDA: 77882602014.14.EDBFD5D Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf18.hostedemail.com (Postfix) with ESMTP id 704FB20053D2 for ; Thu, 4 Mar 2021 15:39:45 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id l18so7272051pji.3 for ; Thu, 04 Mar 2021 07:39:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7PEd9K2shZo0+enCRN097OVkI/lutZDfIjtwU/9mChQ=; b=a7QvvD+SuagbYbASgQQVDgior6phI4kmHd/ZTbp9NQ264aGh5YRehmfTz5u9B08YUy HER9OzPPtcQkU6sTgdUkZAofS3xlNHTqZyvGclnXD3DR2f7YSwJPrdEGpGVXN2ht7cD0 QaxyvHHse+pdyjiBQ3TOtMIaRGRwB4sfKMSofKloGjxWRWWnE+X0/aGSzHIV9RjKF0dD 1sS+tBzeKo/n3bKs64syGFA01HClP2RWSdvZiEdXCPEE514XAjrbgD+k6xt2cX7gwlWJ 8eFFOwJWPHmCkFDch00JakWrFcolX1gSHPCCTW5QVLVki7CnrdwL5VbEX/pgJY5iRriA oh1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=7PEd9K2shZo0+enCRN097OVkI/lutZDfIjtwU/9mChQ=; b=RIAKLUKgdvCg/bgDFEWAy65aHpzUL9V9cS9pg+yjPMS+Ti4OzXjvH5tqk8VW8yDTWD ePNp1LAdBkzO1wjkYes9/j7quqZzaeQHgZAEdjZLz1fa84JPF3ONjN1jL3BjhTXbg/aN 3TqI/lSQBN2+zYZ4zT12aWVvPCUHhPngvvT3g/INumD1FAiKmkZf7pGIPa80HdzfuPpi c49bwsTCGGJIWOlSj225TZ8WmowbNpJ4vbRxEx9hPq2CJYYqtM2S6rAretT58imBsfoA 8kZzmJGBTfmlAtB0t4NH5Q5cgA0eOwtgPMYRdRbrVn75sk5Khd6amX+vBNYqanYrBfiP Ieog== X-Gm-Message-State: AOAM5316cYLyKJHZmLcSK2A0JwTg3daV5NCANTmm9B/nIPK/hKmNzf+Y MAuvfE0DDd9aTmPC8RDLa0o= X-Google-Smtp-Source: ABdhPJzLGzILag6pL7kIk9p896rFsyUTaYOrqB3BoKc35ScpRSS3wRaukfTugRRffJEU4ZZSa+cpyA== X-Received: by 2002:a17:90a:cd06:: with SMTP id d6mr5084566pju.138.1614872377877; Thu, 04 Mar 2021 07:39:37 -0800 (PST) Received: from google.com ([2620:15c:211:201:edb1:8010:5c27:a8cc]) by smtp.gmail.com with ESMTPSA id x7sm6842132pjr.7.2021.03.04.07.39.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 07:39:36 -0800 (PST) Date: Thu, 4 Mar 2021 07:39:34 -0800 From: Minchan Kim To: Andrew Morton Cc: linux-mm , LKML , joaodias@google.com, willy@infradead.org, surenb@google.com, Greg Kroah-Hartman , John Hubbard Subject: Re: [PATCH v3] mm: cma: support sysfs Message-ID: References: <20210303205053.2906924-1-minchan@kernel.org> <20210303144449.aa69518bfbaec9c71f799dc7@linux-foundation.org> <20210303220957.0525de2aebc2c55ad9435cdc@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210303220957.0525de2aebc2c55ad9435cdc@linux-foundation.org> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 704FB20053D2 X-Stat-Signature: 43o9cdhrugt94zhsre6bytd81qxqcryf Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=mail-pj1-f44.google.com; client-ip=209.85.216.44 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614872385-688800 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 03, 2021 at 10:09:57PM -0800, Andrew Morton wrote: > On Wed, 3 Mar 2021 17:38:12 -0800 Minchan Kim wrote: > > > > > #endif > > > > char name[CMA_MAX_NAME]; > > > > +#ifdef CONFIG_CMA_SYSFS > > > > + struct cma_stat *stat; > > > > +#endif > > > > }; > > > > > > Why aren't the stat fields simply placed directly into struct cma_stat? > > > > It have a related long discussion. > > https://lore.kernel.org/linux-mm/YCIoHBGELFWAyfMi@kroah.com/ > > https://lore.kernel.org/linux-mm/YCLLKDEQ4NYqb5Y5@kroah.com/ > > > > TLDR - Greg really want to see kobject stuff working as dynamic > > property. > > Please add to changelog? Sure. > > > > > > > ? > > > > > > > + if (!cma_stats) { > > > > + pr_err("failed to create cma_stats\n"); > > > > > > Probably unneeded - the ENOMEM stack backtrace will point straight here. > > > > I failed to find the point you mentioned to print backtrace. > > Where code do you mean to dump the backtrace? > > The thing which __GFP_NOWARN disables. Got the point.